All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-media@vger.kernel.org
Cc: Dafna Hirschfeld <dafna@fastmail.com>,
	Heiko Stuebner <heiko@sntech.de>,
	Paul Elder <paul.elder@ideasonboard.com>,
	Tomasz Figa <tfiga@google.com>,
	linux-rockchip@lists.infradead.org
Subject: [PATCH 00/16] media: rkisp1: Misc bug fixes and cleanups
Date: Sun, 27 Feb 2022 18:01:00 +0200	[thread overview]
Message-ID: <20220227160116.18556-1-laurent.pinchart@ideasonboard.com> (raw)

Hello,

This series fixes multiple issues and performs further cleanups for the
rkisp1 driver.

Patches 01/16 to 07/16 fix issues in the error paths at probe time that
lead to kernel crashes in case of errors. The .remove() path is also
improved as a result.

Patches 08/16 and 09/16 then clean up register definitions, and patch
10/16 simplifies access to the resizer registers.

Patches 11/16 to 15/16 move on to improving debugfs support, with code
first moved to a separate file (11/16) that can be conditionally
compiled (12/16), support for collecting statistics on the input
interface (13/16, very useful to check if the ISP actually receives
data) and for dumping core and ISP registers (14/16). Patch 15/16
completes that rework by moving the resizer register dumps support to
debugfs too.

Finally, patch 16/16 simplifies the V4L2 querycap implementation on
video nodes.

More fixes and improvements should follow, so I'd like to merge sooner
than latter if possible, to avoid having to rebase large series.

Laurent Pinchart (15):
  media: rkisp1: capture: Initialize entity before video device
  media: rkisp1: capture: Fix and simplify (un)registration
  media: rkisp1: isp: Fix and simplify (un)registration
  media: rkisp1: resizer: Fix and simplify (un)registration
  media: rkisp1: params: Fix and simplify (un)registration
  media: rkisp1: stats: Simplify (un)registration
  media: rkisp1: Simplify rkisp1_entities_register() error path
  media: rkisp1: regs: Don't use BIT() macro for multi-bit register
    fields
  media: rkisp1: regs: Rename CCL, ICCL and IRCL registers with VI_
    prefix
  media: rkisp1: resizer: Simplify register access
  media: rkisp1: Move debugfs code to a separate file
  media: rkisp1: Compile debugfs support conditionally
  media: rkisp1: debug: Collect input status by sampling ISP_FLAGS_SHD
  media: rkisp1: debug: Add debugfs files to dump core and ISP registers
  media: rkisp1: debug: Move resizer register dump to debugfs

Paul Elder (1):
  media: rkisp1: capture: Bypass the main device for handling querycap

 .../media/platform/rockchip/rkisp1/Makefile   |  18 +-
 .../platform/rockchip/rkisp1/rkisp1-capture.c |  52 ++---
 .../platform/rockchip/rkisp1/rkisp1-common.h  |  16 ++
 .../platform/rockchip/rkisp1/rkisp1-debug.c   | 209 ++++++++++++++++++
 .../platform/rockchip/rkisp1/rkisp1-dev.c     |  73 ++----
 .../platform/rockchip/rkisp1/rkisp1-isp.c     |  39 ++--
 .../platform/rockchip/rkisp1/rkisp1-params.c  |  23 +-
 .../platform/rockchip/rkisp1/rkisp1-regs.h    | 188 ++++++++--------
 .../platform/rockchip/rkisp1/rkisp1-resizer.c | 192 ++++------------
 .../platform/rockchip/rkisp1/rkisp1-stats.c   |  11 +-
 10 files changed, 464 insertions(+), 357 deletions(-)
 create mode 100644 drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c

-- 
Regards,

Laurent Pinchart


WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-media@vger.kernel.org
Cc: Dafna Hirschfeld <dafna@fastmail.com>,
	Heiko Stuebner <heiko@sntech.de>,
	Paul Elder <paul.elder@ideasonboard.com>,
	Tomasz Figa <tfiga@google.com>,
	linux-rockchip@lists.infradead.org
Subject: [PATCH 00/16] media: rkisp1: Misc bug fixes and cleanups
Date: Sun, 27 Feb 2022 18:01:00 +0200	[thread overview]
Message-ID: <20220227160116.18556-1-laurent.pinchart@ideasonboard.com> (raw)

Hello,

This series fixes multiple issues and performs further cleanups for the
rkisp1 driver.

Patches 01/16 to 07/16 fix issues in the error paths at probe time that
lead to kernel crashes in case of errors. The .remove() path is also
improved as a result.

Patches 08/16 and 09/16 then clean up register definitions, and patch
10/16 simplifies access to the resizer registers.

Patches 11/16 to 15/16 move on to improving debugfs support, with code
first moved to a separate file (11/16) that can be conditionally
compiled (12/16), support for collecting statistics on the input
interface (13/16, very useful to check if the ISP actually receives
data) and for dumping core and ISP registers (14/16). Patch 15/16
completes that rework by moving the resizer register dumps support to
debugfs too.

Finally, patch 16/16 simplifies the V4L2 querycap implementation on
video nodes.

More fixes and improvements should follow, so I'd like to merge sooner
than latter if possible, to avoid having to rebase large series.

Laurent Pinchart (15):
  media: rkisp1: capture: Initialize entity before video device
  media: rkisp1: capture: Fix and simplify (un)registration
  media: rkisp1: isp: Fix and simplify (un)registration
  media: rkisp1: resizer: Fix and simplify (un)registration
  media: rkisp1: params: Fix and simplify (un)registration
  media: rkisp1: stats: Simplify (un)registration
  media: rkisp1: Simplify rkisp1_entities_register() error path
  media: rkisp1: regs: Don't use BIT() macro for multi-bit register
    fields
  media: rkisp1: regs: Rename CCL, ICCL and IRCL registers with VI_
    prefix
  media: rkisp1: resizer: Simplify register access
  media: rkisp1: Move debugfs code to a separate file
  media: rkisp1: Compile debugfs support conditionally
  media: rkisp1: debug: Collect input status by sampling ISP_FLAGS_SHD
  media: rkisp1: debug: Add debugfs files to dump core and ISP registers
  media: rkisp1: debug: Move resizer register dump to debugfs

Paul Elder (1):
  media: rkisp1: capture: Bypass the main device for handling querycap

 .../media/platform/rockchip/rkisp1/Makefile   |  18 +-
 .../platform/rockchip/rkisp1/rkisp1-capture.c |  52 ++---
 .../platform/rockchip/rkisp1/rkisp1-common.h  |  16 ++
 .../platform/rockchip/rkisp1/rkisp1-debug.c   | 209 ++++++++++++++++++
 .../platform/rockchip/rkisp1/rkisp1-dev.c     |  73 ++----
 .../platform/rockchip/rkisp1/rkisp1-isp.c     |  39 ++--
 .../platform/rockchip/rkisp1/rkisp1-params.c  |  23 +-
 .../platform/rockchip/rkisp1/rkisp1-regs.h    | 188 ++++++++--------
 .../platform/rockchip/rkisp1/rkisp1-resizer.c | 192 ++++------------
 .../platform/rockchip/rkisp1/rkisp1-stats.c   |  11 +-
 10 files changed, 464 insertions(+), 357 deletions(-)
 create mode 100644 drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c

-- 
Regards,

Laurent Pinchart


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

             reply	other threads:[~2022-02-27 16:01 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-27 16:01 Laurent Pinchart [this message]
2022-02-27 16:01 ` [PATCH 00/16] media: rkisp1: Misc bug fixes and cleanups Laurent Pinchart
2022-02-27 16:01 ` [PATCH 01/16] media: rkisp1: capture: Initialize entity before video device Laurent Pinchart
2022-02-27 16:01   ` Laurent Pinchart
2022-03-02 14:25   ` Dafna Hirschfeld
2022-03-02 14:25     ` Dafna Hirschfeld
2022-02-27 16:01 ` [PATCH 02/16] media: rkisp1: capture: Fix and simplify (un)registration Laurent Pinchart
2022-02-27 16:01   ` Laurent Pinchart
2022-03-02 17:10   ` Dafna Hirschfeld
2022-03-02 17:10     ` Dafna Hirschfeld
2022-03-04 12:21     ` Laurent Pinchart
2022-03-04 12:21       ` Laurent Pinchart
2022-02-27 16:01 ` [PATCH 03/16] media: rkisp1: isp: " Laurent Pinchart
2022-02-27 16:01   ` Laurent Pinchart
2022-02-27 16:01 ` [PATCH 04/16] media: rkisp1: resizer: " Laurent Pinchart
2022-02-27 16:01   ` Laurent Pinchart
2022-03-02 19:12   ` Dafna Hirschfeld
2022-03-02 19:12     ` Dafna Hirschfeld
2022-02-27 16:01 ` [PATCH 05/16] media: rkisp1: params: " Laurent Pinchart
2022-02-27 16:01   ` Laurent Pinchart
2022-02-27 16:01 ` [PATCH 06/16] media: rkisp1: stats: Simplify (un)registration Laurent Pinchart
2022-02-27 16:01   ` Laurent Pinchart
2022-02-27 16:01 ` [PATCH 07/16] media: rkisp1: Simplify rkisp1_entities_register() error path Laurent Pinchart
2022-02-27 16:01   ` Laurent Pinchart
2022-03-02 19:16   ` Dafna Hirschfeld
2022-03-02 19:16     ` Dafna Hirschfeld
2022-02-27 16:01 ` [PATCH 08/16] media: rkisp1: regs: Don't use BIT() macro for multi-bit register fields Laurent Pinchart
2022-02-27 16:01   ` Laurent Pinchart
2022-02-27 16:01 ` [PATCH 09/16] media: rkisp1: regs: Rename CCL, ICCL and IRCL registers with VI_ prefix Laurent Pinchart
2022-02-27 16:01   ` Laurent Pinchart
2022-02-27 16:01 ` [PATCH 10/16] media: rkisp1: resizer: Simplify register access Laurent Pinchart
2022-02-27 16:01   ` Laurent Pinchart
2022-02-27 16:10   ` [PATCH v1.1 " Laurent Pinchart
2022-02-27 16:10     ` Laurent Pinchart
2022-03-03  6:32     ` Dafna Hirschfeld
2022-03-03  6:32       ` Dafna Hirschfeld
2022-03-03  8:21       ` Laurent Pinchart
2022-03-03  8:21         ` Laurent Pinchart
2022-03-02 19:34   ` [PATCH " Dafna Hirschfeld
2022-03-02 19:34     ` Dafna Hirschfeld
2022-02-27 16:01 ` [PATCH 11/16] media: rkisp1: Move debugfs code to a separate file Laurent Pinchart
2022-02-27 16:01   ` Laurent Pinchart
2022-02-27 16:01 ` [PATCH 12/16] media: rkisp1: Compile debugfs support conditionally Laurent Pinchart
2022-02-27 16:01   ` Laurent Pinchart
2022-02-28  3:27   ` kernel test robot
2022-02-28  3:27     ` kernel test robot
2022-02-27 16:01 ` [PATCH 13/16] media: rkisp1: debug: Collect input status by sampling ISP_FLAGS_SHD Laurent Pinchart
2022-02-27 16:01   ` Laurent Pinchart
2022-02-27 16:01 ` [PATCH 14/16] media: rkisp1: debug: Add debugfs files to dump core and ISP registers Laurent Pinchart
2022-02-27 16:01   ` Laurent Pinchart
2022-02-27 16:01 ` [PATCH 15/16] media: rkisp1: debug: Move resizer register dump to debugfs Laurent Pinchart
2022-02-27 16:01   ` Laurent Pinchart
2022-02-27 16:01 ` [PATCH 16/16] media: rkisp1: capture: Bypass the main device for handling querycap Laurent Pinchart
2022-02-27 16:01   ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220227160116.18556-1-laurent.pinchart@ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=dafna@fastmail.com \
    --cc=heiko@sntech.de \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=paul.elder@ideasonboard.com \
    --cc=tfiga@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.