All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eugen Hristev <eugen.hristev@microchip.com>
To: <linux-media@vger.kernel.org>, <jacopo@jmondi.org>
Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<claudiu.beznea@microchip.com>, <robh+dt@kernel.org>,
	<nicolas.ferre@microchip.com>,
	Eugen Hristev <eugen.hristev@microchip.com>,
	Hans Verkuil <hverkuil@xs4all.nl>
Subject: [PATCH v6 02/13] media: atmel: atmel-isc-base: replace is_streaming call in s_fmt_vid_cap
Date: Thu, 3 Mar 2022 17:36:07 +0200	[thread overview]
Message-ID: <20220303153618.2084156-3-eugen.hristev@microchip.com> (raw)
In-Reply-To: <20220303153618.2084156-1-eugen.hristev@microchip.com>

In s_fmt_vid_cap, we should check if vb2_is_busy and return EBUSY,
not check if it's streaming to return the busy state.

Suggested-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
---
 drivers/media/platform/atmel/atmel-isc-base.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/atmel/atmel-isc-base.c b/drivers/media/platform/atmel/atmel-isc-base.c
index d2cc6c99984f..67b4a2323fed 100644
--- a/drivers/media/platform/atmel/atmel-isc-base.c
+++ b/drivers/media/platform/atmel/atmel-isc-base.c
@@ -1029,7 +1029,7 @@ static int isc_s_fmt_vid_cap(struct file *file, void *priv,
 {
 	struct isc_device *isc = video_drvdata(file);
 
-	if (vb2_is_streaming(&isc->vb2_vidq))
+	if (vb2_is_busy(&isc->vb2_vidq))
 		return -EBUSY;
 
 	return isc_set_fmt(isc, f);
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Eugen Hristev <eugen.hristev@microchip.com>
To: <linux-media@vger.kernel.org>, <jacopo@jmondi.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Hans Verkuil <hverkuil@xs4all.nl>,
	robh+dt@kernel.org, Eugen Hristev <eugen.hristev@microchip.com>,
	claudiu.beznea@microchip.com,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 02/13] media: atmel: atmel-isc-base: replace is_streaming call in s_fmt_vid_cap
Date: Thu, 3 Mar 2022 17:36:07 +0200	[thread overview]
Message-ID: <20220303153618.2084156-3-eugen.hristev@microchip.com> (raw)
In-Reply-To: <20220303153618.2084156-1-eugen.hristev@microchip.com>

In s_fmt_vid_cap, we should check if vb2_is_busy and return EBUSY,
not check if it's streaming to return the busy state.

Suggested-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
---
 drivers/media/platform/atmel/atmel-isc-base.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/atmel/atmel-isc-base.c b/drivers/media/platform/atmel/atmel-isc-base.c
index d2cc6c99984f..67b4a2323fed 100644
--- a/drivers/media/platform/atmel/atmel-isc-base.c
+++ b/drivers/media/platform/atmel/atmel-isc-base.c
@@ -1029,7 +1029,7 @@ static int isc_s_fmt_vid_cap(struct file *file, void *priv,
 {
 	struct isc_device *isc = video_drvdata(file);
 
-	if (vb2_is_streaming(&isc->vb2_vidq))
+	if (vb2_is_busy(&isc->vb2_vidq))
 		return -EBUSY;
 
 	return isc_set_fmt(isc, f);
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-03-03 15:36 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-03 15:36 [PATCH v6 00/13] media: atmel: atmel-isc: implement media controller Eugen Hristev
2022-03-03 15:36 ` Eugen Hristev
2022-03-03 15:36 ` [PATCH v6 01/13] media: atmel: atmel-isc-base: use streaming status when queueing buffers Eugen Hristev
2022-03-03 15:36   ` Eugen Hristev
2022-03-03 15:36 ` Eugen Hristev [this message]
2022-03-03 15:36   ` [PATCH v6 02/13] media: atmel: atmel-isc-base: replace is_streaming call in s_fmt_vid_cap Eugen Hristev
2022-03-03 15:36 ` [PATCH v6 03/13] media: atmel: atmel-isc: remove redundant comments Eugen Hristev
2022-03-03 15:36   ` Eugen Hristev
2022-03-03 15:36 ` [PATCH v6 04/13] media: atmel: atmel-isc: implement media controller Eugen Hristev
2022-03-03 15:36   ` Eugen Hristev
2022-03-07  8:46   ` Jacopo Mondi
2022-03-07  8:46     ` Jacopo Mondi
2022-03-07 10:31     ` Eugen.Hristev
2022-03-07 10:31       ` Eugen.Hristev
2022-03-07 11:48       ` Eugen.Hristev
2022-03-07 11:48         ` Eugen.Hristev
2022-03-03 15:36 ` [PATCH v6 05/13] media: atmel: atmel-sama5d2-isc: fix wrong mask in YUYV format check Eugen Hristev
2022-03-03 15:36   ` Eugen Hristev
2022-03-03 15:36 ` [PATCH v6 06/13] media: atmel: atmel-isc-base: use mutex to lock awb workqueue from streaming Eugen Hristev
2022-03-03 15:36   ` Eugen Hristev
2022-03-03 15:36 ` [PATCH v6 07/13] media: atmel: atmel-isc: compact the controller formats list Eugen Hristev
2022-03-03 15:36   ` Eugen Hristev
2022-03-03 15:36 ` [PATCH v6 08/13] media: atmel: atmel-isc: change format propagation to subdev into only verification Eugen Hristev
2022-03-03 15:36   ` Eugen Hristev
2022-03-07 10:29   ` Jacopo Mondi
2022-03-07 10:29     ` Jacopo Mondi
2022-03-03 15:36 ` [PATCH v6 09/13] media: atmel: atmel-sama7g5-isc: remove stray line Eugen Hristev
2022-03-03 15:36   ` Eugen Hristev
2022-03-03 15:36 ` [PATCH v6 10/13] dt-bindings: media: microchip,xisc: add bus-width of 14 Eugen Hristev
2022-03-03 15:36   ` [PATCH v6 10/13] dt-bindings: media: microchip, xisc: " Eugen Hristev
2022-03-03 15:36 ` [PATCH v6 11/13] ARM: dts: at91: sama7g5: add nodes for video capture Eugen Hristev
2022-03-03 15:36   ` Eugen Hristev
2022-03-03 15:36 ` [PATCH v6 12/13] ARM: configs: at91: sama7: add xisc and csi2dc Eugen Hristev
2022-03-03 15:36   ` Eugen Hristev
2022-03-03 15:36 ` [PATCH v6 13/13] ARM: multi_v7_defconfig: add atmel video pipeline modules Eugen Hristev
2022-03-03 15:36   ` Eugen Hristev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220303153618.2084156-3-eugen.hristev@microchip.com \
    --to=eugen.hristev@microchip.com \
    --cc=claudiu.beznea@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hverkuil@xs4all.nl \
    --cc=jacopo@jmondi.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=nicolas.ferre@microchip.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.