All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, broonie@kernel.org,
	"Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>,
	"Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
	"Ranjani Sridharan" <ranjani.sridharan@intel.com>
Subject: [PATCH 09/10] ASoC: SOF: debug: clarify operator precedence
Date: Fri,  4 Mar 2022 14:57:32 -0600	[thread overview]
Message-ID: <20220304205733.62233-10-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20220304205733.62233-1-pierre-louis.bossart@linux.intel.com>

cppcheck warning:

sound/soc/sof/debug.c:398:46: style: Clarify calculation precedence
for '&' and '?'. [clarifyCalculation]
 char *level = flags & SOF_DBG_DUMP_OPTIONAL ? KERN_DEBUG : KERN_ERR;
                                             ^
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/sof/debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/sof/debug.c b/sound/soc/sof/debug.c
index 145fd0d1e166..7b1139961a99 100644
--- a/sound/soc/sof/debug.c
+++ b/sound/soc/sof/debug.c
@@ -395,7 +395,7 @@ static void snd_sof_dbg_print_fw_state(struct snd_sof_dev *sdev, const char *lev
 
 void snd_sof_dsp_dbg_dump(struct snd_sof_dev *sdev, const char *msg, u32 flags)
 {
-	char *level = flags & SOF_DBG_DUMP_OPTIONAL ? KERN_DEBUG : KERN_ERR;
+	char *level = (flags & SOF_DBG_DUMP_OPTIONAL) ? KERN_DEBUG : KERN_ERR;
 	bool print_all = sof_debug_check_flag(SOF_DBG_PRINT_ALL_DUMPS);
 
 	if (flags & SOF_DBG_DUMP_OPTIONAL && !print_all)
-- 
2.30.2


  parent reply	other threads:[~2022-03-04 21:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-04 20:57 [PATCH 00/10] ASoC: SOF: updates for 5.18 Pierre-Louis Bossart
2022-03-04 20:57 ` [PATCH 01/10] ASoC: SOF: Intel: pci-tgl: add RPL-S support Pierre-Louis Bossart
2022-03-04 20:57 ` [PATCH 02/10] ASoC: SOF: amd: acp-pcm: Take buffer information directly from runtime Pierre-Louis Bossart
2022-03-04 20:57 ` [PATCH 03/10] ASoC: SOF: amd: Do not set ipc_pcm_params ops as it is optional Pierre-Louis Bossart
2022-03-04 20:57 ` [PATCH 04/10] ASoC: SOF: amd: Flush cache after ATU_BASE_ADDR_GRP register update Pierre-Louis Bossart
2022-03-04 20:57 ` [PATCH 05/10] ASoC: SOF: amd: Use semaphore register to synchronize ipc's irq Pierre-Louis Bossart
2022-03-04 20:57 ` [PATCH 06/10] ASoC: SOF: amd: Move group register configuration to acp-loader Pierre-Louis Bossart
2022-03-04 20:57 ` [PATCH 07/10] ASoC: SOF: amd: Increase ACP_HW_SEM_RETRY_COUNT value Pierre-Louis Bossart
2022-03-04 20:57 ` [PATCH 08/10] ASoC: SOF: fix 32 signed bit overflow Pierre-Louis Bossart
2022-03-04 20:57 ` Pierre-Louis Bossart [this message]
2022-03-04 20:57 ` [PATCH 10/10] ASoC: SOF: Intel: hda: clarify operator precedence Pierre-Louis Bossart
2022-03-07 20:39 ` [PATCH 00/10] ASoC: SOF: updates for 5.18 Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220304205733.62233-10-pierre-louis.bossart@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=peter.ujfalusi@linux.intel.com \
    --cc=ranjani.sridharan@intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.