All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, broonie@kernel.org,
	Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
	Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: [PATCH 07/10] ASoC: SOF: amd: Increase ACP_HW_SEM_RETRY_COUNT value
Date: Fri,  4 Mar 2022 14:57:30 -0600	[thread overview]
Message-ID: <20220304205733.62233-8-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20220304205733.62233-1-pierre-louis.bossart@linux.intel.com>

From: Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>

Host is trying to acquire semaphore lock based on HW_SEM_RETRY_COUNT
value which is set to 10 by default. So host will loop for 10 times
trying to acquire lock before giving error msg "Failed to acquire HW
lock". Though this loop count of 10 is good enough with most of the
times but we have observed such failure msg in very few cases(~5 %).

Increase ACP_HW_SEM_RETRY_COUNT to avoid such issue and loop for a
significant time period before throwing error. We're setting newer
loop count to quite higher value of 10K but it's very unlikely that
it will loop for this count, since for most of the cases lock will
get acquired at much lesser loop iterations.

Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Signed-off-by: Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/sof/amd/acp.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/sof/amd/acp.h b/sound/soc/sof/amd/acp.h
index db1030d36811..f550a5010a91 100644
--- a/sound/soc/sof/amd/acp.h
+++ b/sound/soc/sof/amd/acp.h
@@ -17,7 +17,7 @@
 
 #define ACP_DSP_BAR	0
 
-#define ACP_HW_SEM_RETRY_COUNT			10
+#define ACP_HW_SEM_RETRY_COUNT			10000
 #define ACP_REG_POLL_INTERVAL                   500
 #define ACP_REG_POLL_TIMEOUT_US                 2000
 #define ACP_DMA_COMPLETE_TIMEOUT_US		5000
-- 
2.30.2


  parent reply	other threads:[~2022-03-04 21:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-04 20:57 [PATCH 00/10] ASoC: SOF: updates for 5.18 Pierre-Louis Bossart
2022-03-04 20:57 ` [PATCH 01/10] ASoC: SOF: Intel: pci-tgl: add RPL-S support Pierre-Louis Bossart
2022-03-04 20:57 ` [PATCH 02/10] ASoC: SOF: amd: acp-pcm: Take buffer information directly from runtime Pierre-Louis Bossart
2022-03-04 20:57 ` [PATCH 03/10] ASoC: SOF: amd: Do not set ipc_pcm_params ops as it is optional Pierre-Louis Bossart
2022-03-04 20:57 ` [PATCH 04/10] ASoC: SOF: amd: Flush cache after ATU_BASE_ADDR_GRP register update Pierre-Louis Bossart
2022-03-04 20:57 ` [PATCH 05/10] ASoC: SOF: amd: Use semaphore register to synchronize ipc's irq Pierre-Louis Bossart
2022-03-04 20:57 ` [PATCH 06/10] ASoC: SOF: amd: Move group register configuration to acp-loader Pierre-Louis Bossart
2022-03-04 20:57 ` Pierre-Louis Bossart [this message]
2022-03-04 20:57 ` [PATCH 08/10] ASoC: SOF: fix 32 signed bit overflow Pierre-Louis Bossart
2022-03-04 20:57 ` [PATCH 09/10] ASoC: SOF: debug: clarify operator precedence Pierre-Louis Bossart
2022-03-04 20:57 ` [PATCH 10/10] ASoC: SOF: Intel: hda: " Pierre-Louis Bossart
2022-03-07 20:39 ` [PATCH 00/10] ASoC: SOF: updates for 5.18 Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220304205733.62233-8-pierre-louis.bossart@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=AjitKumar.Pandey@amd.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=ranjani.sridharan@linux.intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.