All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Matthew Wilcox <willy@infradead.org>, Gao Xiang <xiang@kernel.org>
Cc: Gao Xiang <hsiangkao@linux.alibaba.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: linux-next: manual merge of the folio tree with the erofs tree
Date: Tue, 15 Mar 2022 20:31:12 +1100	[thread overview]
Message-ID: <20220315203112.03f6120c@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 2050 bytes --]

Hi all,

Today's linux-next merge of the folio tree got a conflict in:

  fs/erofs/super.c

between commit:

  ab6bfa6e1e22 ("erofs: refine managed inode stuffs")

from the erofs tree and commit:

  8c5b1ba024af ("erofs: Convert from invalidatepage to invalidate_folio")

from the folio tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc fs/erofs/super.c
index e178100c162a,a64c422f6763..000000000000
--- a/fs/erofs/super.c
+++ b/fs/erofs/super.c
@@@ -532,24 -535,18 +532,23 @@@ static int erofs_managed_cache_releasep
  	return ret;
  }
  
 +/*
 + * It will be called only on inode eviction. In case that there are still some
 + * decompression requests in progress, wait with rescheduling for a bit here.
 + * We could introduce an extra locking instead but it seems unnecessary.
 + */
- static void erofs_managed_cache_invalidatepage(struct page *page,
- 					       unsigned int offset,
- 					       unsigned int length)
+ static void erofs_managed_cache_invalidate_folio(struct folio *folio,
+ 					       size_t offset, size_t length)
  {
- 	const unsigned int stop = length + offset;
+ 	const size_t stop = length + offset;
  
- 	DBG_BUGON(!PageLocked(page));
+ 	DBG_BUGON(!folio_test_locked(folio));
  
  	/* Check for potential overflow in debug mode */
- 	DBG_BUGON(stop > PAGE_SIZE || stop < length);
+ 	DBG_BUGON(stop > folio_size(folio) || stop < length);
  
- 	if (offset == 0 && stop == PAGE_SIZE)
- 		while (!erofs_managed_cache_releasepage(page, GFP_NOFS))
+ 	if (offset == 0 && stop == folio_size(folio))
+ 		while (!erofs_managed_cache_releasepage(&folio->page, GFP_NOFS))
  			cond_resched();
  }
  

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

                 reply	other threads:[~2022-03-15  9:31 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220315203112.03f6120c@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=hsiangkao@linux.alibaba.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=willy@infradead.org \
    --cc=xiang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.