From: Lukasz Luba <lukasz.luba@arm.com>
To: linux-kernel@vger.kernel.org
Cc: lukasz.luba@arm.com, dietmar.eggemann@arm.com,
Pierre.Gondois@arm.com, ionela.voinescu@arm.com,
viresh.kumar@linaro.org, rafael@kernel.org,
daniel.lezcano@linaro.org, linux-pm@vger.kernel.org,
mka@chromium.org, nm@ti.com, sboyd@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, cristian.marussi@arm.com,
sudeep.holla@arm.com, matthias.bgg@gmail.com
Subject: [[PATCH 8/8] powercap: DTPM: Check for Energy Model type
Date: Wed, 16 Mar 2022 23:52:11 +0000 [thread overview]
Message-ID: <20220316235211.29370-9-lukasz.luba@arm.com> (raw)
In-Reply-To: <20220316235211.29370-1-lukasz.luba@arm.com>
The Energy Model power values might be artificial. In such case
it's safe to bail out during the registration, since the PowerCap
framework supports only micro-Watts.
Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
---
drivers/powercap/dtpm_cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/powercap/dtpm_cpu.c b/drivers/powercap/dtpm_cpu.c
index bca2f912d349..f5eced0842b3 100644
--- a/drivers/powercap/dtpm_cpu.c
+++ b/drivers/powercap/dtpm_cpu.c
@@ -211,7 +211,7 @@ static int __dtpm_cpu_setup(int cpu, struct dtpm *parent)
return 0;
pd = em_cpu_get(cpu);
- if (!pd)
+ if (!pd || em_is_artificial(pd))
return -EINVAL;
dtpm_cpu = kzalloc(sizeof(*dtpm_cpu), GFP_KERNEL);
--
2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Lukasz Luba <lukasz.luba@arm.com>
To: linux-kernel@vger.kernel.org
Cc: lukasz.luba@arm.com, dietmar.eggemann@arm.com,
Pierre.Gondois@arm.com, ionela.voinescu@arm.com,
viresh.kumar@linaro.org, rafael@kernel.org,
daniel.lezcano@linaro.org, linux-pm@vger.kernel.org,
mka@chromium.org, nm@ti.com, sboyd@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, cristian.marussi@arm.com,
sudeep.holla@arm.com, matthias.bgg@gmail.com
Subject: [[PATCH 8/8] powercap: DTPM: Check for Energy Model type
Date: Wed, 16 Mar 2022 23:52:11 +0000 [thread overview]
Message-ID: <20220316235211.29370-9-lukasz.luba@arm.com> (raw)
In-Reply-To: <20220316235211.29370-1-lukasz.luba@arm.com>
The Energy Model power values might be artificial. In such case
it's safe to bail out during the registration, since the PowerCap
framework supports only micro-Watts.
Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
---
drivers/powercap/dtpm_cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/powercap/dtpm_cpu.c b/drivers/powercap/dtpm_cpu.c
index bca2f912d349..f5eced0842b3 100644
--- a/drivers/powercap/dtpm_cpu.c
+++ b/drivers/powercap/dtpm_cpu.c
@@ -211,7 +211,7 @@ static int __dtpm_cpu_setup(int cpu, struct dtpm *parent)
return 0;
pd = em_cpu_get(cpu);
- if (!pd)
+ if (!pd || em_is_artificial(pd))
return -EINVAL;
dtpm_cpu = kzalloc(sizeof(*dtpm_cpu), GFP_KERNEL);
--
2.17.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Lukasz Luba <lukasz.luba@arm.com>
To: linux-kernel@vger.kernel.org
Cc: lukasz.luba@arm.com, dietmar.eggemann@arm.com,
Pierre.Gondois@arm.com, ionela.voinescu@arm.com,
viresh.kumar@linaro.org, rafael@kernel.org,
daniel.lezcano@linaro.org, linux-pm@vger.kernel.org,
mka@chromium.org, nm@ti.com, sboyd@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, cristian.marussi@arm.com,
sudeep.holla@arm.com, matthias.bgg@gmail.com
Subject: [[PATCH 8/8] powercap: DTPM: Check for Energy Model type
Date: Wed, 16 Mar 2022 23:52:11 +0000 [thread overview]
Message-ID: <20220316235211.29370-9-lukasz.luba@arm.com> (raw)
In-Reply-To: <20220316235211.29370-1-lukasz.luba@arm.com>
The Energy Model power values might be artificial. In such case
it's safe to bail out during the registration, since the PowerCap
framework supports only micro-Watts.
Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
---
drivers/powercap/dtpm_cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/powercap/dtpm_cpu.c b/drivers/powercap/dtpm_cpu.c
index bca2f912d349..f5eced0842b3 100644
--- a/drivers/powercap/dtpm_cpu.c
+++ b/drivers/powercap/dtpm_cpu.c
@@ -211,7 +211,7 @@ static int __dtpm_cpu_setup(int cpu, struct dtpm *parent)
return 0;
pd = em_cpu_get(cpu);
- if (!pd)
+ if (!pd || em_is_artificial(pd))
return -EINVAL;
dtpm_cpu = kzalloc(sizeof(*dtpm_cpu), GFP_KERNEL);
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-16 23:53 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-16 23:52 [0/8] Introduce support for artificial Energy Model Lukasz Luba
2022-03-16 23:52 ` Lukasz Luba
2022-03-16 23:52 ` Lukasz Luba
2022-03-16 23:52 ` [[PATCH 1/8] PM: EM: Add .get_cost() callback Lukasz Luba
2022-03-16 23:52 ` Lukasz Luba
2022-03-16 23:52 ` Lukasz Luba
2022-03-16 23:52 ` [[PATCH 2/8] PM: EM: Add artificial EM flag Lukasz Luba
2022-03-16 23:52 ` Lukasz Luba
2022-03-16 23:52 ` Lukasz Luba
2022-03-16 23:52 ` [[PATCH 3/8] PM: EM: Use the new .get_cost() callback while registering EM Lukasz Luba
2022-03-16 23:52 ` Lukasz Luba
2022-03-16 23:52 ` Lukasz Luba
2022-03-16 23:52 ` [[PATCH 4/8] PM: EM: Change the order of arguments in the .active_power() callback Lukasz Luba
2022-03-16 23:52 ` Lukasz Luba
2022-03-16 23:52 ` Lukasz Luba
2022-03-16 23:52 ` [[PATCH 5/8] PM: EM: Remove old debugfs files and print all 'flags' Lukasz Luba
2022-03-16 23:52 ` Lukasz Luba
2022-03-16 23:52 ` Lukasz Luba
2022-03-16 23:52 ` [[PATCH 6/8] Documentation: EM: Add artificial EM registration description Lukasz Luba
2022-03-16 23:52 ` Lukasz Luba
2022-03-16 23:52 ` Lukasz Luba
2022-03-16 23:52 ` [[PATCH 7/8] thermal: cooling: Check Energy Model type in cpufreq_cooling and devfreq_cooling Lukasz Luba
2022-03-16 23:52 ` Lukasz Luba
2022-03-16 23:52 ` Lukasz Luba
2022-03-16 23:52 ` Lukasz Luba [this message]
2022-03-16 23:52 ` [[PATCH 8/8] powercap: DTPM: Check for Energy Model type Lukasz Luba
2022-03-16 23:52 ` Lukasz Luba
2022-03-29 13:29 ` [0/8] Introduce support for artificial Energy Model Cristian Marussi
2022-03-29 13:29 ` Cristian Marussi
2022-03-29 13:29 ` Cristian Marussi
2022-03-29 13:39 ` Lukasz Luba
2022-03-29 13:39 ` Lukasz Luba
2022-03-29 13:39 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220316235211.29370-9-lukasz.luba@arm.com \
--to=lukasz.luba@arm.com \
--cc=Pierre.Gondois@arm.com \
--cc=cristian.marussi@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=ionela.voinescu@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mka@chromium.org \
--cc=nm@ti.com \
--cc=rafael@kernel.org \
--cc=sboyd@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.