From: kernel test robot <lkp@intel.com>
To: Roopa Prabhu <roopa@nvidia.com>
Cc: kbuild-all@lists.01.org,
Linux Memory Management List <linux-mm@kvack.org>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Eelco Chaudron <echaudro@redhat.com>,
Ido Schimmel <idosch@nvidia.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] vxlan: fix returnvar.cocci warnings
Date: Mon, 21 Mar 2022 23:44:57 +0800 [thread overview]
Message-ID: <20220321154456.GA30106@e0e7ddfdfbf7> (raw)
In-Reply-To: <202203212331.4ZEJaAXK-lkp@intel.com>
From: kernel test robot <lkp@intel.com>
drivers/net/vxlan/vxlan_core.c:2962:5-8: Unneeded variable: "ret". Return "0" on line 2971
Remove unneeded variable used to store return value.
Generated by: scripts/coccinelle/misc/returnvar.cocci
Fixes: f9c4bb0b245c ("vxlan: vni filtering support on collect metadata device")
CC: Roopa Prabhu <roopa@nvidia.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 6d72dda014a4753974eb08950089ddf71fec4f60
commit: f9c4bb0b245cee35ef66f75bf409c9573d934cf9 [8808/13988] vxlan: vni filtering support on collect metadata device
:::::: branch date: 3 days ago
:::::: commit date: 3 weeks ago
drivers/net/vxlan/vxlan_core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/net/vxlan/vxlan_core.c
+++ b/drivers/net/vxlan/vxlan_core.c
@@ -2959,7 +2959,6 @@ static void vxlan_flush(struct vxlan_dev
static int vxlan_stop(struct net_device *dev)
{
struct vxlan_dev *vxlan = netdev_priv(dev);
- int ret = 0;
vxlan_multicast_leave(vxlan);
@@ -2968,7 +2967,7 @@ static int vxlan_stop(struct net_device
vxlan_flush(vxlan, false);
vxlan_sock_release(vxlan);
- return ret;
+ return 0;
}
/* Stub, nothing needs to be done. */
next prev parent reply other threads:[~2022-03-21 15:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 15:46 [linux-next:master 8808/13988] drivers/net/vxlan/vxlan_core.c:2962:5-8: Unneeded variable: "ret". Return "0" on line 2971 kernel test robot
2022-03-21 15:44 ` kernel test robot [this message]
2022-03-21 19:16 ` [PATCH] vxlan: fix returnvar.cocci warnings Jakub Kicinski
2022-03-21 19:16 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220321154456.GA30106@e0e7ddfdfbf7 \
--to=lkp@intel.com \
--cc=bigeasy@linutronix.de \
--cc=echaudro@redhat.com \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=kbuild-all@lists.01.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.