All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephane Eranian <eranian@google.com>
To: linux-kernel@vger.kernel.org
Cc: peterz@infradead.org, kim.phillips@amd.com, acme@redhat.com,
	jolsa@redhat.com, songliubraving@fb.com, rafael@kernel.org,
	ravi.bangoria@amd.com, sandipan.das@amd.com
Subject: [PATCH v7 04/13] perf/x86/amd: add branch-brs helper event for Fam19h BRS
Date: Tue, 22 Mar 2022 15:15:08 -0700	[thread overview]
Message-ID: <20220322221517.2510440-5-eranian@google.com> (raw)
In-Reply-To: <20220322221517.2510440-1-eranian@google.com>

Add a pseudo event called branch-brs to help use the FAM Fam19h
Branch Sampling feature (BRS). BRS samples taken branches, so it is best used
when sampling on a retired taken branch event (0xc4) which is what BRS
captures.  Instead of trying to remember the event code or actual event name,
users can simply do:

$ perf record -b -e cpu/branch-brs/ -c 1000037 .....

Signed-off-by: Stephane Eranian <eranian@google.com>
---
 arch/x86/events/amd/core.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/x86/events/amd/core.c b/arch/x86/events/amd/core.c
index c7ac70d8ed9a..f7bce8364fe4 100644
--- a/arch/x86/events/amd/core.c
+++ b/arch/x86/events/amd/core.c
@@ -1145,8 +1145,23 @@ static struct attribute_group group_caps_amd_brs = {
 	.is_visible = amd_brs_is_visible,
 };
 
+EVENT_ATTR_STR(branch-brs, amd_branch_brs,
+	       "event=" __stringify(AMD_FAM19H_BRS_EVENT)"\n");
+
+static struct attribute *amd_brs_events_attrs[] = {
+	EVENT_PTR(amd_branch_brs),
+	NULL,
+};
+
+static struct attribute_group group_events_amd_brs = {
+	.name       = "events",
+	.attrs      = amd_brs_events_attrs,
+	.is_visible = amd_brs_is_visible,
+};
+
 static const struct attribute_group *amd_attr_update[] = {
 	&group_caps_amd_brs,
+	&group_events_amd_brs,
 	NULL,
 };
 
-- 
2.35.1.894.gb6a874cedc-goog


  parent reply	other threads:[~2022-03-22 22:15 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-22 22:15 [PATCH v7 00/13] perf/x86/amd: Add AMD Fam19h Branch Sampling support Stephane Eranian
2022-03-22 22:15 ` [PATCH v7 01/13] perf/core: add perf_clear_branch_entry_bitfields() helper Stephane Eranian
2022-04-05  8:36   ` [tip: perf/core] perf/core: Add " tip-bot2 for Stephane Eranian
2022-03-22 22:15 ` [PATCH v7 02/13] x86/cpufeatures: add AMD Fam19h Branch Sampling feature Stephane Eranian
2022-04-05  8:36   ` [tip: perf/core] x86/cpufeatures: Add " tip-bot2 for Stephane Eranian
2022-03-22 22:15 ` [PATCH v7 03/13] perf/x86/amd: add AMD Fam19h Branch Sampling support Stephane Eranian
2022-04-05  8:36   ` [tip: perf/core] perf/x86/amd: Add " tip-bot2 for Stephane Eranian
2022-03-22 22:15 ` Stephane Eranian [this message]
2022-04-05  8:36   ` [tip: perf/core] perf/x86/amd: Add branch-brs helper event for Fam19h BRS tip-bot2 for Stephane Eranian
2022-03-22 22:15 ` [PATCH v7 05/13] perf/x86/amd: enable branch sampling priv level filtering Stephane Eranian
2022-04-05  8:36   ` [tip: perf/core] perf/x86/amd: Enable " tip-bot2 for Stephane Eranian
2022-03-22 22:15 ` [PATCH v7 06/13] perf/x86/amd: add AMD branch sampling period adjustment Stephane Eranian
2022-04-05  8:36   ` [tip: perf/core] perf/x86/amd: Add " tip-bot2 for Stephane Eranian
2022-03-22 22:15 ` [PATCH v7 07/13] perf/x86/amd: make Zen3 branch sampling opt-in Stephane Eranian
2022-04-05  8:36   ` [tip: perf/core] perf/x86/amd: Make " tip-bot2 for Stephane Eranian
2022-03-22 22:15 ` [PATCH v7 08/13] ACPI: add perf low power callback Stephane Eranian
2022-04-05  8:36   ` [tip: perf/core] ACPI: Add " tip-bot2 for Stephane Eranian
2022-03-22 22:15 ` [PATCH v7 09/13] perf/x86/amd: add idle hooks for branch sampling Stephane Eranian
2022-04-05  8:36   ` [tip: perf/core] perf/x86/amd: Add " tip-bot2 for Stephane Eranian
2022-03-22 22:15 ` [PATCH v7 10/13] perf tools: fix NULL point in evsel__env() Stephane Eranian
2022-03-23 19:01   ` Kim Phillips
2022-03-25 18:27   ` Arnaldo Carvalho de Melo
2022-03-25 20:02     ` Stephane Eranian
2022-03-22 22:15 ` [PATCH v7 11/13] perf tools: Improve IBS error handling Stephane Eranian
2022-03-25 21:46   ` Arnaldo Carvalho de Melo
2022-03-25 21:53     ` Arnaldo Carvalho de Melo
2022-03-22 22:15 ` [PATCH v7 12/13] perf tools: Improve error handling of AMD Branch Sampling Stephane Eranian
2022-03-22 22:15 ` [PATCH v7 13/13] perf report: add addr_from/addr_to sort dimensions Stephane Eranian
2022-03-24 14:59 ` [PATCH v7 00/13] perf/x86/amd: Add AMD Fam19h Branch Sampling support Peter Zijlstra
2022-03-25  5:31   ` Stephane Eranian
2022-03-25  8:28     ` Peter Zijlstra
2022-03-29 21:58       ` Stephane Eranian
2022-03-29 23:47         ` Stephane Eranian
2022-03-30 11:01           ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220322221517.2510440-5-eranian@google.com \
    --to=eranian@google.com \
    --cc=acme@redhat.com \
    --cc=jolsa@redhat.com \
    --cc=kim.phillips@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=rafael@kernel.org \
    --cc=ravi.bangoria@amd.com \
    --cc=sandipan.das@amd.com \
    --cc=songliubraving@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.