All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephane Eranian <eranian@google.com>
To: linux-kernel@vger.kernel.org
Cc: peterz@infradead.org, kim.phillips@amd.com, acme@redhat.com,
	jolsa@redhat.com, songliubraving@fb.com, rafael@kernel.org,
	ravi.bangoria@amd.com, sandipan.das@amd.com
Subject: [PATCH v7 08/13] ACPI: add perf low power callback
Date: Tue, 22 Mar 2022 15:15:12 -0700	[thread overview]
Message-ID: <20220322221517.2510440-9-eranian@google.com> (raw)
In-Reply-To: <20220322221517.2510440-1-eranian@google.com>

Add an optional callback needed by some PMU features, e.g., AMD
BRS, to give a chance to the perf_events code to change its state before
a CPU goes to low power and after it comes back.

The callback is void when the PERF_NEEDS_LOPWR_CB flag is not set.
This flag must be set in arch specific perf_event.h header whenever needed.
When not set, there is no impact on the ACPI code.

Signed-off-by: Stephane Eranian <eranian@google.com>
---
 drivers/acpi/acpi_pad.c       | 6 ++++++
 drivers/acpi/processor_idle.c | 5 +++++
 include/linux/perf_event.h    | 6 ++++++
 3 files changed, 17 insertions(+)

diff --git a/drivers/acpi/acpi_pad.c b/drivers/acpi/acpi_pad.c
index f45979aa2d64..a306a07a60b5 100644
--- a/drivers/acpi/acpi_pad.c
+++ b/drivers/acpi/acpi_pad.c
@@ -164,6 +164,9 @@ static int power_saving_thread(void *data)
 				tsc_marked_unstable = 1;
 			}
 			local_irq_disable();
+
+			perf_lopwr_cb(true);
+
 			tick_broadcast_enable();
 			tick_broadcast_enter();
 			stop_critical_timings();
@@ -172,6 +175,9 @@ static int power_saving_thread(void *data)
 
 			start_critical_timings();
 			tick_broadcast_exit();
+
+			perf_lopwr_cb(false);
+
 			local_irq_enable();
 
 			if (time_before(expire_time, jiffies)) {
diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
index f8e9fa82cb9b..f83596960d9a 100644
--- a/drivers/acpi/processor_idle.c
+++ b/drivers/acpi/processor_idle.c
@@ -21,6 +21,7 @@
 #include <linux/cpuidle.h>
 #include <linux/cpu.h>
 #include <linux/minmax.h>
+#include <linux/perf_event.h>
 #include <acpi/processor.h>
 
 /*
@@ -549,6 +550,8 @@ static void wait_for_freeze(void)
  */
 static void __cpuidle acpi_idle_do_entry(struct acpi_processor_cx *cx)
 {
+	perf_lopwr_cb(true);
+
 	if (cx->entry_method == ACPI_CSTATE_FFH) {
 		/* Call into architectural FFH based C-state */
 		acpi_processor_ffh_cstate_enter(cx);
@@ -559,6 +562,8 @@ static void __cpuidle acpi_idle_do_entry(struct acpi_processor_cx *cx)
 		inb(cx->address);
 		wait_for_freeze();
 	}
+
+	perf_lopwr_cb(false);
 }
 
 /**
diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
index 496eb6aa6e54..1b98e46588bc 100644
--- a/include/linux/perf_event.h
+++ b/include/linux/perf_event.h
@@ -1676,4 +1676,10 @@ typedef int (perf_snapshot_branch_stack_t)(struct perf_branch_entry *entries,
 					   unsigned int cnt);
 DECLARE_STATIC_CALL(perf_snapshot_branch_stack, perf_snapshot_branch_stack_t);
 
+#ifndef PERF_NEEDS_LOPWR_CB
+static inline void perf_lopwr_cb(bool mode)
+{
+}
+#endif
+
 #endif /* _LINUX_PERF_EVENT_H */
-- 
2.35.1.894.gb6a874cedc-goog


  parent reply	other threads:[~2022-03-22 22:16 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-22 22:15 [PATCH v7 00/13] perf/x86/amd: Add AMD Fam19h Branch Sampling support Stephane Eranian
2022-03-22 22:15 ` [PATCH v7 01/13] perf/core: add perf_clear_branch_entry_bitfields() helper Stephane Eranian
2022-04-05  8:36   ` [tip: perf/core] perf/core: Add " tip-bot2 for Stephane Eranian
2022-03-22 22:15 ` [PATCH v7 02/13] x86/cpufeatures: add AMD Fam19h Branch Sampling feature Stephane Eranian
2022-04-05  8:36   ` [tip: perf/core] x86/cpufeatures: Add " tip-bot2 for Stephane Eranian
2022-03-22 22:15 ` [PATCH v7 03/13] perf/x86/amd: add AMD Fam19h Branch Sampling support Stephane Eranian
2022-04-05  8:36   ` [tip: perf/core] perf/x86/amd: Add " tip-bot2 for Stephane Eranian
2022-03-22 22:15 ` [PATCH v7 04/13] perf/x86/amd: add branch-brs helper event for Fam19h BRS Stephane Eranian
2022-04-05  8:36   ` [tip: perf/core] perf/x86/amd: Add " tip-bot2 for Stephane Eranian
2022-03-22 22:15 ` [PATCH v7 05/13] perf/x86/amd: enable branch sampling priv level filtering Stephane Eranian
2022-04-05  8:36   ` [tip: perf/core] perf/x86/amd: Enable " tip-bot2 for Stephane Eranian
2022-03-22 22:15 ` [PATCH v7 06/13] perf/x86/amd: add AMD branch sampling period adjustment Stephane Eranian
2022-04-05  8:36   ` [tip: perf/core] perf/x86/amd: Add " tip-bot2 for Stephane Eranian
2022-03-22 22:15 ` [PATCH v7 07/13] perf/x86/amd: make Zen3 branch sampling opt-in Stephane Eranian
2022-04-05  8:36   ` [tip: perf/core] perf/x86/amd: Make " tip-bot2 for Stephane Eranian
2022-03-22 22:15 ` Stephane Eranian [this message]
2022-04-05  8:36   ` [tip: perf/core] ACPI: Add perf low power callback tip-bot2 for Stephane Eranian
2022-03-22 22:15 ` [PATCH v7 09/13] perf/x86/amd: add idle hooks for branch sampling Stephane Eranian
2022-04-05  8:36   ` [tip: perf/core] perf/x86/amd: Add " tip-bot2 for Stephane Eranian
2022-03-22 22:15 ` [PATCH v7 10/13] perf tools: fix NULL point in evsel__env() Stephane Eranian
2022-03-23 19:01   ` Kim Phillips
2022-03-25 18:27   ` Arnaldo Carvalho de Melo
2022-03-25 20:02     ` Stephane Eranian
2022-03-22 22:15 ` [PATCH v7 11/13] perf tools: Improve IBS error handling Stephane Eranian
2022-03-25 21:46   ` Arnaldo Carvalho de Melo
2022-03-25 21:53     ` Arnaldo Carvalho de Melo
2022-03-22 22:15 ` [PATCH v7 12/13] perf tools: Improve error handling of AMD Branch Sampling Stephane Eranian
2022-03-22 22:15 ` [PATCH v7 13/13] perf report: add addr_from/addr_to sort dimensions Stephane Eranian
2022-03-24 14:59 ` [PATCH v7 00/13] perf/x86/amd: Add AMD Fam19h Branch Sampling support Peter Zijlstra
2022-03-25  5:31   ` Stephane Eranian
2022-03-25  8:28     ` Peter Zijlstra
2022-03-29 21:58       ` Stephane Eranian
2022-03-29 23:47         ` Stephane Eranian
2022-03-30 11:01           ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220322221517.2510440-9-eranian@google.com \
    --to=eranian@google.com \
    --cc=acme@redhat.com \
    --cc=jolsa@redhat.com \
    --cc=kim.phillips@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=rafael@kernel.org \
    --cc=ravi.bangoria@amd.com \
    --cc=sandipan.das@amd.com \
    --cc=songliubraving@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.