All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adam Ford <aford173@gmail.com>
To: linux-mmc@vger.kernel.org
Cc: haibo.chen@nxp.com, aford@beaconembedded.com,
	Adam Ford <aford173@gmail.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/3] dt-bindings: mmc: imx-esdhc: Update compatible fallbacks
Date: Sat,  2 Apr 2022 14:39:39 -0500	[thread overview]
Message-ID: <20220402193942.744737-2-aford173@gmail.com> (raw)
In-Reply-To: <20220402193942.744737-1-aford173@gmail.com>

The SDHC controller in the imx8mn and imx8mp have the same controller
as the imx8mm which is slightly different than that of the imx7d.
Using the fallback of the imx8mm enables the controllers to support
HS400-ES which is not available on the imx7d. After discussion with NXP,
it turns out that the imx8qm should fall back to the imx8qxp, because
those have some additional flags not present in the imx8mm.

Suggested-by: haibo.chen@nxp.com
Signed-off-by: Adam Ford <aford173@gmail.com>
---
V3:  Marked the imx7d-usdhc as deprecated when there are better
     fallback options or the fallback isn't needed.
     Leave the deprecated fallback in the YAML to prevent errors
     Remove Reviewed-by from Krzysztof Kozlowski due to the above

V2:  Update the table per recomendation from Haibo.

diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
index 7dbbcae9485c..11f039320d79 100644
--- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
+++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
@@ -34,23 +34,34 @@ properties:
           - fsl,imx6ull-usdhc
           - fsl,imx7d-usdhc
           - fsl,imx7ulp-usdhc
+          - fsl,imx8mm-usdhc
+          - fsl,imx8qxp-usdhc
           - fsl,imxrt1050-usdhc
           - nxp,s32g2-usdhc
       - items:
           - enum:
               - fsl,imx8mm-usdhc
+              - fsl,imx8mq-usdhc
+            # fsl,imx7d-usdhc fallback is deprecated for imx8mm-usdhc
+          - const: fsl,imx7d-usdhc
+      - items:
+          - enum:
               - fsl,imx8mn-usdhc
               - fsl,imx8mp-usdhc
-              - fsl,imx8mq-usdhc
-              - fsl,imx8qm-usdhc
-              - fsl,imx8qxp-usdhc
+          - const: fsl,imx8mm-usdhc
+            # fsl,imx7d-usdhc fallback is deprecated
           - const: fsl,imx7d-usdhc
       - items:
           - enum:
-              - fsl,imx93-usdhc
               - fsl,imx8ulp-usdhc
+              - fsl,imx93-usdhc
           - const: fsl,imx8mm-usdhc
-
+      - items:
+          - enum:
+              - fsl,imx8qm-usdhc
+          - const: fsl,imx8qxp-usdhc
+            # fsl,imx7d-usdhc fallback is deprecated
+          - const: fsl,imx7d-usdhc
   reg:
     maxItems: 1
 
-- 
2.34.1


WARNING: multiple messages have this Message-ID (diff)
From: Adam Ford <aford173@gmail.com>
To: linux-mmc@vger.kernel.org
Cc: haibo.chen@nxp.com, aford@beaconembedded.com,
	Adam Ford <aford173@gmail.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH V3 1/3] dt-bindings: mmc: imx-esdhc: Update compatible fallbacks
Date: Sat,  2 Apr 2022 14:39:39 -0500	[thread overview]
Message-ID: <20220402193942.744737-2-aford173@gmail.com> (raw)
In-Reply-To: <20220402193942.744737-1-aford173@gmail.com>

The SDHC controller in the imx8mn and imx8mp have the same controller
as the imx8mm which is slightly different than that of the imx7d.
Using the fallback of the imx8mm enables the controllers to support
HS400-ES which is not available on the imx7d. After discussion with NXP,
it turns out that the imx8qm should fall back to the imx8qxp, because
those have some additional flags not present in the imx8mm.

Suggested-by: haibo.chen@nxp.com
Signed-off-by: Adam Ford <aford173@gmail.com>
---
V3:  Marked the imx7d-usdhc as deprecated when there are better
     fallback options or the fallback isn't needed.
     Leave the deprecated fallback in the YAML to prevent errors
     Remove Reviewed-by from Krzysztof Kozlowski due to the above

V2:  Update the table per recomendation from Haibo.

diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
index 7dbbcae9485c..11f039320d79 100644
--- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
+++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
@@ -34,23 +34,34 @@ properties:
           - fsl,imx6ull-usdhc
           - fsl,imx7d-usdhc
           - fsl,imx7ulp-usdhc
+          - fsl,imx8mm-usdhc
+          - fsl,imx8qxp-usdhc
           - fsl,imxrt1050-usdhc
           - nxp,s32g2-usdhc
       - items:
           - enum:
               - fsl,imx8mm-usdhc
+              - fsl,imx8mq-usdhc
+            # fsl,imx7d-usdhc fallback is deprecated for imx8mm-usdhc
+          - const: fsl,imx7d-usdhc
+      - items:
+          - enum:
               - fsl,imx8mn-usdhc
               - fsl,imx8mp-usdhc
-              - fsl,imx8mq-usdhc
-              - fsl,imx8qm-usdhc
-              - fsl,imx8qxp-usdhc
+          - const: fsl,imx8mm-usdhc
+            # fsl,imx7d-usdhc fallback is deprecated
           - const: fsl,imx7d-usdhc
       - items:
           - enum:
-              - fsl,imx93-usdhc
               - fsl,imx8ulp-usdhc
+              - fsl,imx93-usdhc
           - const: fsl,imx8mm-usdhc
-
+      - items:
+          - enum:
+              - fsl,imx8qm-usdhc
+          - const: fsl,imx8qxp-usdhc
+            # fsl,imx7d-usdhc fallback is deprecated
+          - const: fsl,imx7d-usdhc
   reg:
     maxItems: 1
 
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-04-02 19:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-02 19:39 [PATCH V3 0/4] Fixup fsl-imx-ehci fallback Adam Ford
2022-04-02 19:39 ` Adam Ford
2022-04-02 19:39 ` Adam Ford [this message]
2022-04-02 19:39   ` [PATCH V3 1/3] dt-bindings: mmc: imx-esdhc: Update compatible fallbacks Adam Ford
2022-04-02 20:12   ` Krzysztof Kozlowski
2022-04-02 20:12     ` Krzysztof Kozlowski
2022-04-10 14:36     ` Adam Ford
2022-04-10 14:36       ` Adam Ford
2022-04-10 15:22       ` Krzysztof Kozlowski
2022-04-10 15:22         ` Krzysztof Kozlowski
2022-04-02 19:39 ` [PATCH V3 2/3] arm64: dts: imx8mn: Enable HS400-ES Adam Ford
2022-04-02 19:39   ` Adam Ford
2022-04-02 19:39 ` [PATCH V3 3/3] arm64: dts: imx8mp: " Adam Ford
2022-04-02 19:39   ` Adam Ford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220402193942.744737-2-aford173@gmail.com \
    --to=aford173@gmail.com \
    --cc=aford@beaconembedded.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=haibo.chen@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.