All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>
Cc: Stuart Yoder <stuyoder@gmail.com>,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Stephen Hemminger <sthemmin@microsoft.com>,
	Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Vineeth Vijayan <vneethv@linux.ibm.com>,
	Peter Oberparleiter <oberpar@linux.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	Sven Schnelle <svens@linux.ibm.com>,
	Andy Gross <agross@kernel.org>,
	linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org,
	linux-spi@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH v6 11/12] rpmsg: Constify local variable in field store macro
Date: Sun,  3 Apr 2022 20:37:57 +0200	[thread overview]
Message-ID: <20220403183758.192236-12-krzysztof.kozlowski@linaro.org> (raw)
In-Reply-To: <20220403183758.192236-1-krzysztof.kozlowski@linaro.org>

Memory pointed by variable 'old' in field store macro is not modified,
so it can be made a pointer to const.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/rpmsg/rpmsg_core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c
index 79368a957d89..95fc283f6af7 100644
--- a/drivers/rpmsg/rpmsg_core.c
+++ b/drivers/rpmsg/rpmsg_core.c
@@ -400,7 +400,8 @@ field##_store(struct device *dev, struct device_attribute *attr,	\
 	      const char *buf, size_t sz)				\
 {									\
 	struct rpmsg_device *rpdev = to_rpmsg_device(dev);		\
-	char *new, *old;						\
+	const char *old;						\
+	char *new;							\
 									\
 	new = kstrndup(buf, sz, GFP_KERNEL);				\
 	if (!new)							\
-- 
2.32.0


WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>
Cc: Stuart Yoder <stuyoder@gmail.com>,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Stephen Hemminger <sthemmin@microsoft.com>,
	Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Vineeth Vijayan <vneethv@linux.ibm.com>,
	Peter Oberparleiter <oberpar@linux.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	Sven Schnelle <svens@linux.ibm.com>,
	Andy Gross <agross@kernel.org>,
	linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org,
	linux-spi@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH v6 11/12] rpmsg: Constify local variable in field store macro
Date: Sun,  3 Apr 2022 20:37:57 +0200	[thread overview]
Message-ID: <20220403183758.192236-12-krzysztof.kozlowski@linaro.org> (raw)
In-Reply-To: <20220403183758.192236-1-krzysztof.kozlowski@linaro.org>

Memory pointed by variable 'old' in field store macro is not modified,
so it can be made a pointer to const.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/rpmsg/rpmsg_core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c
index 79368a957d89..95fc283f6af7 100644
--- a/drivers/rpmsg/rpmsg_core.c
+++ b/drivers/rpmsg/rpmsg_core.c
@@ -400,7 +400,8 @@ field##_store(struct device *dev, struct device_attribute *attr,	\
 	      const char *buf, size_t sz)				\
 {									\
 	struct rpmsg_device *rpdev = to_rpmsg_device(dev);		\
-	char *new, *old;						\
+	const char *old;						\
+	char *new;							\
 									\
 	new = kstrndup(buf, sz, GFP_KERNEL);				\
 	if (!new)							\
-- 
2.32.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-04-03 18:39 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-03 18:37 [PATCH v6 00/12] Fix broken usage of driver_override (and kfree of static memory) Krzysztof Kozlowski
2022-04-03 18:37 ` Krzysztof Kozlowski
2022-04-03 18:37 ` [PATCH v6 01/12] driver: platform: Add helper for safer setting of driver_override Krzysztof Kozlowski
2022-04-03 18:37   ` Krzysztof Kozlowski
2022-04-04  9:16   ` Andy Shevchenko
2022-04-04  9:16     ` Andy Shevchenko
2022-04-04  9:16     ` Andy Shevchenko
2022-04-04  9:16     ` Andy Shevchenko
2022-04-04  9:34     ` Krzysztof Kozlowski
2022-04-04  9:34       ` Krzysztof Kozlowski
2022-04-04  9:34       ` Krzysztof Kozlowski
2022-04-04 10:14       ` Andy Shevchenko
2022-04-04 10:14         ` Andy Shevchenko
2022-04-04 10:14         ` Andy Shevchenko
2022-04-04 10:14         ` Andy Shevchenko
2022-04-03 18:37 ` [PATCH v6 02/12] amba: Use driver_set_override() instead of open-coding Krzysztof Kozlowski
2022-04-03 18:37   ` Krzysztof Kozlowski
2022-04-03 18:37 ` [PATCH v6 03/12] fsl-mc: " Krzysztof Kozlowski
2022-04-03 18:37   ` Krzysztof Kozlowski
2022-04-03 18:37 ` [PATCH v6 04/12] hv: " Krzysztof Kozlowski
2022-04-03 18:37   ` Krzysztof Kozlowski
2022-04-03 18:37 ` [PATCH v6 05/12] PCI: " Krzysztof Kozlowski
2022-04-03 18:37   ` Krzysztof Kozlowski
2022-04-03 18:37 ` [PATCH v6 06/12] s390/cio: " Krzysztof Kozlowski
2022-04-03 18:37   ` Krzysztof Kozlowski
2022-04-03 18:37 ` [PATCH v6 07/12] spi: Use helper for safer setting of driver_override Krzysztof Kozlowski
2022-04-03 18:37   ` Krzysztof Kozlowski
2022-04-03 18:37 ` [PATCH v6 08/12] vdpa: " Krzysztof Kozlowski
2022-04-03 18:37   ` Krzysztof Kozlowski
2022-04-03 18:37 ` [PATCH v6 09/12] clk: imx: scu: Fix kfree() of static memory on setting driver_override Krzysztof Kozlowski
2022-04-03 18:37   ` Krzysztof Kozlowski
2022-04-03 18:37 ` [PATCH v6 10/12] slimbus: qcom-ngd: " Krzysztof Kozlowski
2022-04-03 18:37   ` Krzysztof Kozlowski
2022-04-03 18:37 ` Krzysztof Kozlowski [this message]
2022-04-03 18:37   ` [PATCH v6 11/12] rpmsg: Constify local variable in field store macro Krzysztof Kozlowski
2022-04-03 18:37 ` [PATCH v6 12/12] rpmsg: Fix kfree() of static memory on setting driver_override Krzysztof Kozlowski
2022-04-03 18:37   ` Krzysztof Kozlowski
2022-04-12 14:10   ` Biju Das
2022-04-12 14:10     ` Biju Das
2022-04-12 14:10     ` Biju Das
2022-04-13  8:40     ` Krzysztof Kozlowski
2022-04-13  8:40       ` Krzysztof Kozlowski
2022-04-13  8:40       ` Krzysztof Kozlowski
2022-04-13  8:47       ` Biju Das
2022-04-13  8:47         ` Biju Das
2022-04-13  8:47         ` Biju Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220403183758.192236-12-krzysztof.kozlowski@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=agordeev@linux.ibm.com \
    --cc=agross@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=borntraeger@linux.ibm.com \
    --cc=decui@microsoft.com \
    --cc=gor@linux.ibm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=haiyangz@microsoft.com \
    --cc=hca@linux.ibm.com \
    --cc=kys@microsoft.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=mathieu.poirier@linaro.org \
    --cc=oberpar@linux.ibm.com \
    --cc=rafael@kernel.org \
    --cc=sthemmin@microsoft.com \
    --cc=stuyoder@gmail.com \
    --cc=svens@linux.ibm.com \
    --cc=torvalds@linux-foundation.org \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=vneethv@linux.ibm.com \
    --cc=wei.liu@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.