All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.com>
Subject: [PATCH 02/11] ALSA: usb-audio: Fix undefined behavior due to shift overflowing the constant
Date: Tue,  5 Apr 2022 17:15:08 +0200	[thread overview]
Message-ID: <20220405151517.29753-3-bp@alien8.de> (raw)
In-Reply-To: <20220405151517.29753-1-bp@alien8.de>

From: Borislav Petkov <bp@suse.de>

Fix:

  sound/usb/midi.c: In function ‘snd_usbmidi_out_endpoint_create’:
  sound/usb/midi.c:1389:2: error: case label does not reduce to an integer constant
    case USB_ID(0xfc08, 0x0101): /* Unknown vendor Cable */
    ^~~~

See https://lore.kernel.org/r/YkwQ6%2BtIH8GQpuct@zn.tnic for the gory
details as to why it triggers with older gccs only.

Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.com>
Cc: alsa-devel@alsa-project.org
---
 sound/usb/usbaudio.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/usb/usbaudio.h b/sound/usb/usbaudio.h
index 167834133b9b..2b3dd55e8ee0 100644
--- a/sound/usb/usbaudio.h
+++ b/sound/usb/usbaudio.h
@@ -8,7 +8,7 @@
  */
 
 /* handling of USB vendor/product ID pairs as 32-bit numbers */
-#define USB_ID(vendor, product) (((vendor) << 16) | (product))
+#define USB_ID(vendor, product) ((((unsigned int)vendor) << 16) | (product))
 #define USB_ID_VENDOR(id) ((id) >> 16)
 #define USB_ID_PRODUCT(id) ((u16)(id))
 
-- 
2.35.1


WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	alsa-devel@alsa-project.org
Subject: [PATCH 02/11] ALSA: usb-audio: Fix undefined behavior due to shift overflowing the constant
Date: Tue,  5 Apr 2022 17:15:08 +0200	[thread overview]
Message-ID: <20220405151517.29753-3-bp@alien8.de> (raw)
In-Reply-To: <20220405151517.29753-1-bp@alien8.de>

From: Borislav Petkov <bp@suse.de>

Fix:

  sound/usb/midi.c: In function ‘snd_usbmidi_out_endpoint_create’:
  sound/usb/midi.c:1389:2: error: case label does not reduce to an integer constant
    case USB_ID(0xfc08, 0x0101): /* Unknown vendor Cable */
    ^~~~

See https://lore.kernel.org/r/YkwQ6%2BtIH8GQpuct@zn.tnic for the gory
details as to why it triggers with older gccs only.

Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.com>
Cc: alsa-devel@alsa-project.org
---
 sound/usb/usbaudio.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/usb/usbaudio.h b/sound/usb/usbaudio.h
index 167834133b9b..2b3dd55e8ee0 100644
--- a/sound/usb/usbaudio.h
+++ b/sound/usb/usbaudio.h
@@ -8,7 +8,7 @@
  */
 
 /* handling of USB vendor/product ID pairs as 32-bit numbers */
-#define USB_ID(vendor, product) (((vendor) << 16) | (product))
+#define USB_ID(vendor, product) ((((unsigned int)vendor) << 16) | (product))
 #define USB_ID_VENDOR(id) ((id) >> 16)
 #define USB_ID_PRODUCT(id) ((u16)(id))
 
-- 
2.35.1


  parent reply	other threads:[~2022-04-05 15:16 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-05 15:15 [PATCH 00/11] treewide: Fix a bunch of shift overflows Borislav Petkov
2022-04-05 15:15 ` [PATCH 01/11] scsi: aacraid: Fix undefined behavior due to shift overflowing the constant Borislav Petkov
2022-04-25 18:47   ` Randy Dunlap
2022-04-26  3:05   ` Martin K. Petersen
2022-05-03  0:51   ` Martin K. Petersen
2022-04-05 15:15 ` Borislav Petkov [this message]
2022-04-05 15:15   ` [PATCH 02/11] ALSA: usb-audio: " Borislav Petkov
2022-04-05 15:32   ` Takashi Iwai
2022-04-05 15:32     ` Takashi Iwai
2022-04-05 16:06     ` Borislav Petkov
2022-04-05 16:06       ` Borislav Petkov
2022-04-05 16:16       ` Takashi Iwai
2022-04-05 16:16         ` Takashi Iwai
2022-04-05 15:15 ` [PATCH 03/11] bnx2x: " Borislav Petkov
2022-04-05 19:53   ` Jakub Kicinski
2022-04-05 19:59     ` Borislav Petkov
2022-04-05 15:15 ` [PATCH 04/11] drm/r128: " Borislav Petkov
2022-04-05 15:15   ` Borislav Petkov
2022-04-25 18:46   ` Randy Dunlap
2022-04-25 18:46     ` Randy Dunlap
2022-05-19 13:05     ` Daniel Vetter
2022-05-19 13:05       ` Daniel Vetter
2022-06-16 16:06       ` Randy Dunlap
2022-06-24 20:13         ` Daniel Vetter
2022-06-24 20:13           ` Daniel Vetter
2022-04-05 15:15 ` [PATCH 05/11] i2c: ismt: " Borislav Petkov
2022-04-05 21:18   ` Seth Heasley
2022-04-05 15:15 ` [PATCH 06/11] brcmfmac: sdio: " Borislav Petkov
2022-04-05 15:25   ` Kalle Valo
2022-04-05 16:06     ` Borislav Petkov
2022-04-05 16:37       ` Kalle Valo
2022-04-05 16:55         ` [RESEND PATCH " Borislav Petkov
2022-04-05 19:11           ` Arend van Spriel
2022-04-10 12:20           ` Kalle Valo
2022-04-05 15:15 ` [PATCH 07/11] usb: typec: tcpm: " Borislav Petkov
2022-04-05 15:15 ` [PATCH 08/11] mt76: " Borislav Petkov
2022-04-06  5:43   ` Kalle Valo
2022-04-10 12:20   ` Kalle Valo
2022-04-05 15:15 ` [PATCH 09/11] perf/imx_ddr: " Borislav Petkov
2022-04-05 15:15   ` Borislav Petkov
2022-04-08 10:47   ` Will Deacon
2022-04-08 10:47     ` Will Deacon
2022-04-08 11:01     ` Borislav Petkov
2022-04-08 11:01       ` Borislav Petkov
2022-04-05 15:15 ` [PATCH 10/11] IB/mlx5: " Borislav Petkov
2022-04-05 18:31   ` Leon Romanovsky
2022-04-05 19:42     ` Borislav Petkov
2022-04-06  7:17   ` Leon Romanovsky
2022-04-05 15:15 ` [PATCH 11/11] drm/i915: " Borislav Petkov
2022-04-05 15:15   ` Borislav Petkov
2022-04-05 15:15   ` [Intel-gfx] " Borislav Petkov
2022-05-17 23:05   ` Randy Dunlap
2022-05-17 23:05     ` [Intel-gfx] " Randy Dunlap
2022-05-17 23:05     ` Randy Dunlap
2022-05-18  7:44     ` Borislav Petkov
2022-05-18  7:44       ` [Intel-gfx] " Borislav Petkov
2022-05-18  7:44       ` Borislav Petkov
2022-05-18 11:39       ` Jani Nikula
2022-05-18 11:39         ` [Intel-gfx] " Jani Nikula
2022-05-18 11:39         ` Jani Nikula
2022-04-06  9:23 ` [PATCH 00/11] treewide: Fix a bunch of shift overflows David Laight
2022-04-08 13:58 ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220405151517.29753-3-bp@alien8.de \
    --to=bp@alien8.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.