All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Alexander Aring <alex.aring@gmail.com>,
	Stefan Schmidt <stefan@datenfreihafen.org>,
	linux-wpan@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	netdev@vger.kernel.org, David Girault <david.girault@qorvo.com>,
	Romuald Despres <romuald.despres@qorvo.com>,
	Frederic Blain <frederic.blain@qorvo.com>,
	Nicolas Schodet <nico@ni.fr.eu.org>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Miquel Raynal <miquel.raynal@bootlin.com>
Subject: [PATCH v6 08/10] net: ieee802154: atusb: Call _xmit_hw_error() upon transmission error
Date: Thu,  7 Apr 2022 12:09:01 +0200	[thread overview]
Message-ID: <20220407100903.1695973-9-miquel.raynal@bootlin.com> (raw)
In-Reply-To: <20220407100903.1695973-1-miquel.raynal@bootlin.com>

ieee802154_xmit_hw_error() is the right helper to call when a transmission
has failed for a non-determined (and probably not IEEE802.15.4 specific)
reason. Let's use this helper instead of open-coding it.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
 drivers/net/ieee802154/atusb.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/ieee802154/atusb.c b/drivers/net/ieee802154/atusb.c
index f27a5f535808..46a63646f2a0 100644
--- a/drivers/net/ieee802154/atusb.c
+++ b/drivers/net/ieee802154/atusb.c
@@ -271,9 +271,7 @@ static void atusb_tx_done(struct atusb *atusb, u8 seq)
 		 * unlikely case now that seq == expect is then true, but can
 		 * happen and fail with a tx_skb = NULL;
 		 */
-		ieee802154_wake_queue(atusb->hw);
-		if (atusb->tx_skb)
-			dev_kfree_skb_irq(atusb->tx_skb);
+		ieee802154_xmit_hw_error(atusb->hw, atusb->tx_skb);
 	}
 }
 
-- 
2.27.0


  parent reply	other threads:[~2022-04-07 10:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-07 10:08 [PATCH v6 00/10] ieee802154: Better Tx error handling Miquel Raynal
2022-04-07 10:08 ` [PATCH v6 01/10] net: ieee802154: Enhance/fix the names of the MLME return codes Miquel Raynal
2022-04-07 10:08 ` [PATCH v6 02/10] net: ieee802154: Fill the list of " Miquel Raynal
2022-04-07 10:08 ` [PATCH v6 03/10] net: mac802154: Save a global error code on transmissions Miquel Raynal
2022-04-07 10:08 ` [PATCH v6 04/10] net: mac802154: Create an offloaded transmission error helper Miquel Raynal
2022-04-07 10:08 ` [PATCH v6 05/10] net: mac802154: Create an error helper for asynchronous offloading errors Miquel Raynal
2022-04-07 10:08 ` [PATCH v6 06/10] net: ieee802154: at86rf230: Call _xmit_hw_error() when failing to offload frames Miquel Raynal
2022-04-07 10:09 ` [PATCH v6 07/10] net: ieee802154: at86rf230: Forward Tx trac errors Miquel Raynal
2022-04-07 10:09 ` Miquel Raynal [this message]
2022-04-07 10:09 ` [PATCH v6 09/10] net: ieee802154: ca8210: Use core return codes instead of hardcoding them Miquel Raynal
2022-04-07 10:09 ` [PATCH v6 10/10] net: ieee802154: ca8210: Call _xmit_error() when a transmission fails Miquel Raynal
2022-04-25 12:37 ` [PATCH v6 00/10] ieee802154: Better Tx error handling Alexander Aring
2022-04-25 19:25   ` Stefan Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220407100903.1695973-9-miquel.raynal@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=alex.aring@gmail.com \
    --cc=davem@davemloft.net \
    --cc=david.girault@qorvo.com \
    --cc=frederic.blain@qorvo.com \
    --cc=kuba@kernel.org \
    --cc=linux-wpan@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nico@ni.fr.eu.org \
    --cc=romuald.despres@qorvo.com \
    --cc=stefan@datenfreihafen.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.