All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guangbin Huang <huangguangbin2@huawei.com>
To: <davem@davemloft.net>, <kuba@kernel.org>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<lipeng321@huawei.com>, <huangguangbin2@huawei.com>,
	<chenhao288@hisilicon.com>
Subject: [PATCH net-next 4/9] net: hns3: add failure logs in hclge_set_vport_mtu
Date: Sat, 16 Apr 2022 17:13:38 +0800	[thread overview]
Message-ID: <20220416091343.35817-5-huangguangbin2@huawei.com> (raw)
In-Reply-To: <20220416091343.35817-1-huangguangbin2@huawei.com>

From: Jie Wang <wangjie125@huawei.com>

Currently, There is a low probability that pf mtu configuration fails, but
the information in logs is insufficient for problem locating when the VF
mtu value is illegally modified.

So record the vf index and vf mtu value at the failure scenario.

Signed-off-by: Jie Wang <wangjie125@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
---
 drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
index 8cebb180c812..a5dd2c8c244a 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
@@ -10449,6 +10449,9 @@ int hclge_set_vport_mtu(struct hclge_vport *vport, int new_mtu)
 	/* PF's mps must be greater then VF's mps */
 	for (i = 1; i < hdev->num_alloc_vport; i++)
 		if (max_frm_size < hdev->vport[i].mps) {
+			dev_err(&hdev->pdev->dev,
+				"failed to set pf mtu for less than vport %d, mps = %u.\n",
+				i, hdev->vport[i].mps);
 			mutex_unlock(&hdev->vport_lock);
 			return -EINVAL;
 		}
-- 
2.33.0


  parent reply	other threads:[~2022-04-16  9:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-16  9:13 [PATCH net-next 0/9] net: hns3: updates for -next Guangbin Huang
2022-04-16  9:13 ` [PATCH net-next 1/9] net: hns3: add ethtool parameter check for CQE/EQE mode Guangbin Huang
2022-04-16  9:13 ` [PATCH net-next 2/9] net: hns3: refactor hns3_set_ringparam() Guangbin Huang
2022-04-16  9:13 ` [PATCH net-next 3/9] net: hns3: refine the definition for struct hclge_pf_to_vf_msg Guangbin Huang
2022-04-16  9:13 ` Guangbin Huang [this message]
2022-04-16  9:13 ` [PATCH net-next 5/9] net: hns3: add log for setting tx spare buf size Guangbin Huang
2022-04-16  9:13 ` [PATCH net-next 6/9] net: hns3: update the comment of function hclgevf_get_mbx_resp Guangbin Huang
2022-04-16  9:13 ` [PATCH net-next 7/9] net: hns3: fix the wrong words in comments Guangbin Huang
2022-04-16  9:13 ` [PATCH net-next 8/9] net: hns3: replace magic value by HCLGE_RING_REG_OFFSET Guangbin Huang
2022-04-16  9:13 ` [PATCH net-next 9/9] net: hns3: remove unnecessary line wrap for hns3_set_tunable Guangbin Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220416091343.35817-5-huangguangbin2@huawei.com \
    --to=huangguangbin2@huawei.com \
    --cc=chenhao288@hisilicon.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lipeng321@huawei.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.