All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cixi Geng <gengcixi@gmail.com>
To: jic23@kernel.org, lars@metafoo.de, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, orsonzhai@gmail.com,
	baolin.wang7@gmail.com, zhang.lyra@gmail.com,
	yuming.zhu1@unisoc.com
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH V4 2/7] iio: adc: sc27xx: fix read big scale voltage not right
Date: Tue, 19 Apr 2022 22:24:53 +0800	[thread overview]
Message-ID: <20220419142458.884933-3-gengcixi@gmail.com> (raw)
In-Reply-To: <20220419142458.884933-1-gengcixi@gmail.com>

From: Cixi Geng <cixi.geng1@unisoc.com>

Fix wrong configuration value of SC27XX_ADC_SCALE_MASK and
SC27XX_ADC_SCALE_SHIFT by spec documetation.
Fixes: 5df362a6cf49c (iio: adc: Add Spreadtrum SC27XX PMICs ADC support)

Signed-off-by: Cixi Geng <cixi.geng1@unisoc.com>
Reviewed-by: Baolin Wang <baolin.wang7@gmail.com>
---
 drivers/iio/adc/sc27xx_adc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/adc/sc27xx_adc.c b/drivers/iio/adc/sc27xx_adc.c
index 00098caf6d9e..aee076c8e2b1 100644
--- a/drivers/iio/adc/sc27xx_adc.c
+++ b/drivers/iio/adc/sc27xx_adc.c
@@ -36,8 +36,8 @@
 
 /* Bits and mask definition for SC27XX_ADC_CH_CFG register */
 #define SC27XX_ADC_CHN_ID_MASK		GENMASK(4, 0)
-#define SC27XX_ADC_SCALE_MASK		GENMASK(10, 8)
-#define SC27XX_ADC_SCALE_SHIFT		8
+#define SC27XX_ADC_SCALE_MASK		GENMASK(10, 9)
+#define SC27XX_ADC_SCALE_SHIFT		9
 
 /* Bits definitions for SC27XX_ADC_INT_EN registers */
 #define SC27XX_ADC_IRQ_EN		BIT(0)
-- 
2.25.1


  parent reply	other threads:[~2022-04-19 14:26 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-19 14:24 [PATCH V4 0/7] iio: adc: sc27xx: adjust structure and add PMIC's support Cixi Geng
2022-04-19 14:24 ` [PATCH V4 1/7] dt-bindings:iio:adc: add sprd,ump9620-adc dt-binding Cixi Geng
2022-04-20  7:01   ` Krzysztof Kozlowski
2022-04-24 17:21     ` Jonathan Cameron
2022-04-19 14:24 ` Cixi Geng [this message]
2022-04-24 17:00   ` [PATCH V4 2/7] iio: adc: sc27xx: fix read big scale voltage not right Jonathan Cameron
2022-04-19 14:24 ` [PATCH V4 3/7] iio: adc: Fine tune the scale calibration values Cixi Geng
2022-04-24 17:01   ` Jonathan Cameron
2022-04-24 17:28     ` Jonathan Cameron
2022-04-19 14:24 ` [PATCH V4 4/7] iio: adc: sc27xx: structure adjustment and optimization Cixi Geng
2022-04-19 14:24 ` [PATCH V4 5/7] iio: adc: refactor some functions for support more PMiCs Cixi Geng
2022-04-24 17:30   ` Jonathan Cameron
2022-04-19 14:24 ` [PATCH V4 6/7] iio: adc: sc27xx: add support for PMIC sc2720 and sc2721 Cixi Geng
2022-04-19 14:24 ` [PATCH V4 7/7] iio: adc: sc27xx: add support for PMIC sc2730 Cixi Geng
2022-04-24 17:34 ` [PATCH V4 0/7] iio: adc: sc27xx: adjust structure and add PMIC's support Jonathan Cameron
2022-04-29  4:25   ` Cixi Geng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220419142458.884933-3-gengcixi@gmail.com \
    --to=gengcixi@gmail.com \
    --cc=baolin.wang7@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=orsonzhai@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=yuming.zhu1@unisoc.com \
    --cc=zhang.lyra@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.