From: Mark Brown <broonie@kernel.org> To: Jerome Brunet <jbrunet@baylibre.com>, Liam Girdwood <lgirdwood@gmail.com> Cc: Neil Armstrong <narmstrong@baylibre.com>, Kevin Hilman <khilman@baylibre.com>, Martin Blumenstingl <martin.blumenstingl@googlemail.com>, alsa-devel@alsa-project.org, linux-amlogic@lists.infradead.org, Mark Brown <broonie@kernel.org> Subject: [PATCH v1 1/3] ASoC: meson: Fix event generation for AUI ACODEC mux Date: Thu, 21 Apr 2022 13:38:01 +0100 [thread overview] Message-ID: <20220421123803.292063-2-broonie@kernel.org> (raw) In-Reply-To: <20220421123803.292063-1-broonie@kernel.org> The AIU ACODEC has a custom put() operation which returns 0 when the value of the mux changes, meaning that events are not generated for userspace. Change to return 1 in this case, the function returns early in the case where there is no change. Signed-off-by: Mark Brown <broonie@kernel.org> --- sound/soc/meson/aiu-acodec-ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/meson/aiu-acodec-ctrl.c b/sound/soc/meson/aiu-acodec-ctrl.c index 27a6d3259c50..442c215936d9 100644 --- a/sound/soc/meson/aiu-acodec-ctrl.c +++ b/sound/soc/meson/aiu-acodec-ctrl.c @@ -58,7 +58,7 @@ static int aiu_acodec_ctrl_mux_put_enum(struct snd_kcontrol *kcontrol, snd_soc_dapm_mux_update_power(dapm, kcontrol, mux, e, NULL); - return 0; + return 1; } static SOC_ENUM_SINGLE_DECL(aiu_acodec_ctrl_mux_enum, AIU_ACODEC_CTRL, -- 2.30.2 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org> To: Jerome Brunet <jbrunet@baylibre.com>, Liam Girdwood <lgirdwood@gmail.com> Cc: alsa-devel@alsa-project.org, Neil Armstrong <narmstrong@baylibre.com>, Martin Blumenstingl <martin.blumenstingl@googlemail.com>, Kevin Hilman <khilman@baylibre.com>, Mark Brown <broonie@kernel.org>, linux-amlogic@lists.infradead.org Subject: [PATCH v1 1/3] ASoC: meson: Fix event generation for AUI ACODEC mux Date: Thu, 21 Apr 2022 13:38:01 +0100 [thread overview] Message-ID: <20220421123803.292063-2-broonie@kernel.org> (raw) In-Reply-To: <20220421123803.292063-1-broonie@kernel.org> The AIU ACODEC has a custom put() operation which returns 0 when the value of the mux changes, meaning that events are not generated for userspace. Change to return 1 in this case, the function returns early in the case where there is no change. Signed-off-by: Mark Brown <broonie@kernel.org> --- sound/soc/meson/aiu-acodec-ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/meson/aiu-acodec-ctrl.c b/sound/soc/meson/aiu-acodec-ctrl.c index 27a6d3259c50..442c215936d9 100644 --- a/sound/soc/meson/aiu-acodec-ctrl.c +++ b/sound/soc/meson/aiu-acodec-ctrl.c @@ -58,7 +58,7 @@ static int aiu_acodec_ctrl_mux_put_enum(struct snd_kcontrol *kcontrol, snd_soc_dapm_mux_update_power(dapm, kcontrol, mux, e, NULL); - return 0; + return 1; } static SOC_ENUM_SINGLE_DECL(aiu_acodec_ctrl_mux_enum, AIU_ACODEC_CTRL, -- 2.30.2
next prev parent reply other threads:[~2022-04-21 12:38 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-21 12:38 [PATCH v1 0/3] ASoC: meson: Fix mixer-test issues Mark Brown 2022-04-21 12:38 ` Mark Brown 2022-04-21 12:38 ` Mark Brown [this message] 2022-04-21 12:38 ` [PATCH v1 1/3] ASoC: meson: Fix event generation for AUI ACODEC mux Mark Brown 2022-04-21 12:38 ` [PATCH v1 2/3] ASoC: meson: Fix event generation for AUI CODEC mux Mark Brown 2022-04-21 12:38 ` Mark Brown 2022-04-21 12:38 ` [PATCH v1 3/3] ASoC: meson: Fix event generation for G12A tohdmi mux Mark Brown 2022-04-21 12:38 ` Mark Brown 2022-04-21 13:02 ` [PATCH v1 0/3] ASoC: meson: Fix mixer-test issues Jerome Brunet 2022-04-21 13:02 ` Jerome Brunet 2022-04-21 13:39 ` Mark Brown 2022-04-21 13:39 ` Mark Brown 2022-04-21 17:24 ` Mark Brown 2022-04-21 17:24 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220421123803.292063-2-broonie@kernel.org \ --to=broonie@kernel.org \ --cc=alsa-devel@alsa-project.org \ --cc=jbrunet@baylibre.com \ --cc=khilman@baylibre.com \ --cc=lgirdwood@gmail.com \ --cc=linux-amlogic@lists.infradead.org \ --cc=martin.blumenstingl@googlemail.com \ --cc=narmstrong@baylibre.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.