From: Hailong Tu <tuhailong@gmail.com>
To: tuhailong@gmail.com, akpm@linux-foundation.org, sj@kernel.org,
torvalds@linux-foundation.org, gregkh@google.com,
surenb@google.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Cc: tuhailong@oppo.com, lichunpeng@oppo.com, aaron.qiu@oppo.com,
fanguoze@oppo.com, wangdesuo@oppo.com, lizhihua@oppo.com
Subject: [PATCH v5] mm/damon/reclaim: Fix the timer always stays active
Date: Thu, 21 Apr 2022 20:59:11 +0800 [thread overview]
Message-ID: <20220421125910.1052459-1-tuhailong@gmail.com> (raw)
The timer stays active even if the reclaim mechanism is never enabled.
It is unnecessary overhead can be completely avoided by using module_param_cb() for enabled flag.
Signed-off-by: Hailong Tu <tuhailong@gmail.com>
---
mm/damon/reclaim.c | 27 +++++++++++++++++++++++++--
1 file changed, 25 insertions(+), 2 deletions(-)
diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c
index e34c4d0c4d93..75cfd96a6060 100644
--- a/mm/damon/reclaim.c
+++ b/mm/damon/reclaim.c
@@ -28,7 +28,6 @@
* this.
*/
static bool enabled __read_mostly;
-module_param(enabled, bool, 0600);
/*
* Time threshold for cold memory regions identification in microseconds.
@@ -358,11 +357,35 @@ static void damon_reclaim_timer_fn(struct work_struct *work)
enabled = last_enabled;
}
- schedule_delayed_work(&damon_reclaim_timer,
+ if (enabled)
+ schedule_delayed_work(&damon_reclaim_timer,
msecs_to_jiffies(ENABLE_CHECK_INTERVAL_MS));
}
static DECLARE_DELAYED_WORK(damon_reclaim_timer, damon_reclaim_timer_fn);
+static int enabled_store(const char *val,
+ const struct kernel_param *kp)
+{
+ int rc = param_set_bool(val, kp);
+
+ if (rc < 0)
+ return rc;
+
+ if (enabled)
+ schedule_delayed_work(&damon_reclaim_timer, 0);
+
+ return 0;
+}
+
+static const struct kernel_param_ops enabled_param_ops = {
+ .set = enabled_store,
+ .get = param_get_bool,
+};
+
+module_param_cb(enabled, &enabled_param_ops, &enabled, 0600);
+MODULE_PARM_DESC(enabled,
+ "Enable or disable DAMON_RECLAIM (default: disabled)");
+
static int damon_reclaim_after_aggregation(struct damon_ctx *c)
{
struct damos *s;
--
2.25.1
reply other threads:[~2022-04-21 12:59 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220421125910.1052459-1-tuhailong@gmail.com \
--to=tuhailong@gmail.com \
--cc=aaron.qiu@oppo.com \
--cc=akpm@linux-foundation.org \
--cc=fanguoze@oppo.com \
--cc=gregkh@google.com \
--cc=lichunpeng@oppo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizhihua@oppo.com \
--cc=sj@kernel.org \
--cc=surenb@google.com \
--cc=torvalds@linux-foundation.org \
--cc=tuhailong@oppo.com \
--cc=wangdesuo@oppo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.