From: Yosry Ahmed <yosryahmed@google.com> To: Johannes Weiner <hannes@cmpxchg.org>, Michal Hocko <mhocko@kernel.org>, Shakeel Butt <shakeelb@google.com>, Andrew Morton <akpm@linux-foundation.org>, Roman Gushchin <roman.gushchin@linux.dev> Cc: "David Rientjes" <rientjes@google.com>, "Tejun Heo" <tj@kernel.org>, "Zefan Li" <lizefan.x@bytedance.com>, "Jonathan Corbet" <corbet@lwn.net>, "Shuah Khan" <shuah@kernel.org>, "Yu Zhao" <yuzhao@google.com>, "Dave Hansen" <dave.hansen@linux.intel.com>, "Wei Xu" <weixugc@google.com>, "Greg Thelen" <gthelen@google.com>, "Chen Wandun" <chenwandun@huawei.com>, "Vaibhav Jain" <vaibhav@linux.ibm.com>, "Michal Koutný" <mkoutny@suse.com>, "Tim Chen" <tim.c.chen@linux.intel.com>, "Dan Schatzberg" <schatzberg.dan@gmail.com>, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, "Yosry Ahmed" <yosryahmed@google.com> Subject: [PATCH v4 3/4] selftests: cgroup: fix alloc_anon_noexit() instantly freeing memory Date: Thu, 21 Apr 2022 23:44:25 +0000 [thread overview] Message-ID: <20220421234426.3494842-4-yosryahmed@google.com> (raw) In-Reply-To: <20220421234426.3494842-1-yosryahmed@google.com> Currently, alloc_anon_noexit() calls alloc_anon() which instantly frees the allocated memory. alloc_anon_noexit() is usually used with cg_run_nowait() to run a process in the background that allocates memory. It makes sense for the background process to keep the memory allocated and not instantly free it (otherwise there is no point of running it in the background). Signed-off-by: Yosry Ahmed <yosryahmed@google.com> Acked-by: Roman Gushchin <roman.gushchin@linux.dev> --- tools/testing/selftests/cgroup/test_memcontrol.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/cgroup/test_memcontrol.c b/tools/testing/selftests/cgroup/test_memcontrol.c index 36ccf2322e21..f2ffb3a30194 100644 --- a/tools/testing/selftests/cgroup/test_memcontrol.c +++ b/tools/testing/selftests/cgroup/test_memcontrol.c @@ -211,13 +211,17 @@ static int alloc_pagecache_50M_noexit(const char *cgroup, void *arg) static int alloc_anon_noexit(const char *cgroup, void *arg) { int ppid = getppid(); + size_t size = (unsigned long)arg; + char *buf, *ptr; - if (alloc_anon(cgroup, arg)) - return -1; + buf = malloc(size); + for (ptr = buf; ptr < buf + size; ptr += PAGE_SIZE) + *ptr = 0; while (getppid() == ppid) sleep(1); + free(buf); return 0; } -- 2.36.0.rc2.479.g8af0fa9b8e-goog
WARNING: multiple messages have this Message-ID (diff)
From: Yosry Ahmed <yosryahmed-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> To: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>, Michal Hocko <mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Shakeel Butt <shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>, Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>, Roman Gushchin <roman.gushchin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org> Cc: "David Rientjes" <rientjes-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>, "Tejun Heo" <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, "Zefan Li" <lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>, "Jonathan Corbet" <corbet-T1hC0tSOHrs@public.gmane.org>, "Shuah Khan" <shuah-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, "Yu Zhao" <yuzhao-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>, "Dave Hansen" <dave.hansen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>, "Wei Xu" <weixugc-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>, "Greg Thelen" <gthelen-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>, "Chen Wandun" <chenwandun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>, "Vaibhav Jain" <vaibhav-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org>, "Michal Koutný" <mkoutny-IBi9RG/b67k@public.gmane.org>, "Tim Chen" <tim.c.chen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>, "Dan Schatzberg" <schatzberg.dan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, linux-kselftest-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Yosry Ahmed" <yosryahmed-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> Subject: [PATCH v4 3/4] selftests: cgroup: fix alloc_anon_noexit() instantly freeing memory Date: Thu, 21 Apr 2022 23:44:25 +0000 [thread overview] Message-ID: <20220421234426.3494842-4-yosryahmed@google.com> (raw) In-Reply-To: <20220421234426.3494842-1-yosryahmed-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> Currently, alloc_anon_noexit() calls alloc_anon() which instantly frees the allocated memory. alloc_anon_noexit() is usually used with cg_run_nowait() to run a process in the background that allocates memory. It makes sense for the background process to keep the memory allocated and not instantly free it (otherwise there is no point of running it in the background). Signed-off-by: Yosry Ahmed <yosryahmed-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> Acked-by: Roman Gushchin <roman.gushchin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org> --- tools/testing/selftests/cgroup/test_memcontrol.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/cgroup/test_memcontrol.c b/tools/testing/selftests/cgroup/test_memcontrol.c index 36ccf2322e21..f2ffb3a30194 100644 --- a/tools/testing/selftests/cgroup/test_memcontrol.c +++ b/tools/testing/selftests/cgroup/test_memcontrol.c @@ -211,13 +211,17 @@ static int alloc_pagecache_50M_noexit(const char *cgroup, void *arg) static int alloc_anon_noexit(const char *cgroup, void *arg) { int ppid = getppid(); + size_t size = (unsigned long)arg; + char *buf, *ptr; - if (alloc_anon(cgroup, arg)) - return -1; + buf = malloc(size); + for (ptr = buf; ptr < buf + size; ptr += PAGE_SIZE) + *ptr = 0; while (getppid() == ppid) sleep(1); + free(buf); return 0; } -- 2.36.0.rc2.479.g8af0fa9b8e-goog
next prev parent reply other threads:[~2022-04-21 23:45 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-21 23:44 [PATCH v4 0/4] memcg: introduce per-memcg proactive reclaim Yosry Ahmed 2022-04-21 23:44 ` [PATCH v4 1/4] memcg: introduce per-memcg reclaim interface Yosry Ahmed 2022-04-21 23:44 ` Yosry Ahmed 2022-04-23 13:30 ` Shakeel Butt 2022-04-23 13:30 ` Shakeel Butt 2022-04-23 21:44 ` Yosry Ahmed 2022-04-23 21:44 ` Yosry Ahmed 2022-04-21 23:44 ` [PATCH v4 2/4] selftests: cgroup: return -errno from cg_read()/cg_write() on failure Yosry Ahmed 2022-04-23 14:01 ` Shakeel Butt 2022-04-23 14:01 ` Shakeel Butt 2022-04-21 23:44 ` Yosry Ahmed [this message] 2022-04-21 23:44 ` [PATCH v4 3/4] selftests: cgroup: fix alloc_anon_noexit() instantly freeing memory Yosry Ahmed 2022-04-23 14:03 ` Shakeel Butt 2022-04-23 14:03 ` Shakeel Butt 2022-04-21 23:44 ` [PATCH v4 4/4] selftests: cgroup: add a selftest for memory.reclaim Yosry Ahmed 2022-04-23 14:28 ` Shakeel Butt 2022-04-23 14:28 ` Shakeel Butt 2022-04-23 21:43 ` Yosry Ahmed 2022-04-23 21:43 ` Yosry Ahmed 2022-04-25 15:16 ` Shakeel Butt 2022-04-25 15:16 ` Shakeel Butt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220421234426.3494842-4-yosryahmed@google.com \ --to=yosryahmed@google.com \ --cc=akpm@linux-foundation.org \ --cc=cgroups@vger.kernel.org \ --cc=chenwandun@huawei.com \ --cc=corbet@lwn.net \ --cc=dave.hansen@linux.intel.com \ --cc=gthelen@google.com \ --cc=hannes@cmpxchg.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-kselftest@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=lizefan.x@bytedance.com \ --cc=mhocko@kernel.org \ --cc=mkoutny@suse.com \ --cc=rientjes@google.com \ --cc=roman.gushchin@linux.dev \ --cc=schatzberg.dan@gmail.com \ --cc=shakeelb@google.com \ --cc=shuah@kernel.org \ --cc=tim.c.chen@linux.intel.com \ --cc=tj@kernel.org \ --cc=vaibhav@linux.ibm.com \ --cc=weixugc@google.com \ --cc=yuzhao@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.