From: Tom Rix <trix@redhat.com>
To: sanju.mehta@amd.com, vkoul@kernel.org
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
Tom Rix <trix@redhat.com>
Subject: [PATCH] dmaengine: ptdma: change pt_tx_status to static
Date: Sat, 23 Apr 2022 09:10:26 -0400 [thread overview]
Message-ID: <20220423131026.798269-1-trix@redhat.com> (raw)
Sparse reports thise issue
ptdma-dmaengine.c:262:1: warning: symbol 'pt_tx_status' was not declared. Should it be static?
pt_tx_status, like other pt_* functions in ptdam-dmaengine.c, is assigned
to a function pointer and is not used directly outside of this file.
So change its storage-class specifier to static.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/dma/ptdma/ptdma-dmaengine.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/ptdma/ptdma-dmaengine.c b/drivers/dma/ptdma/ptdma-dmaengine.c
index ea07cc42f4d0..cc22d162ce25 100644
--- a/drivers/dma/ptdma/ptdma-dmaengine.c
+++ b/drivers/dma/ptdma/ptdma-dmaengine.c
@@ -258,7 +258,7 @@ static void pt_issue_pending(struct dma_chan *dma_chan)
pt_cmd_callback(desc, 0);
}
-enum dma_status
+static enum dma_status
pt_tx_status(struct dma_chan *c, dma_cookie_t cookie,
struct dma_tx_state *txstate)
{
--
2.27.0
next reply other threads:[~2022-04-23 13:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-23 13:10 Tom Rix [this message]
2022-04-27 2:48 ` [PATCH] dmaengine: ptdma: change pt_tx_status to static Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220423131026.798269-1-trix@redhat.com \
--to=trix@redhat.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sanju.mehta@amd.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.