From: Yosry Ahmed <yosryahmed@google.com> To: Johannes Weiner <hannes@cmpxchg.org>, Michal Hocko <mhocko@kernel.org>, Shakeel Butt <shakeelb@google.com>, Andrew Morton <akpm@linux-foundation.org>, Roman Gushchin <roman.gushchin@linux.dev> Cc: "David Rientjes" <rientjes@google.com>, "Tejun Heo" <tj@kernel.org>, "Zefan Li" <lizefan.x@bytedance.com>, "Jonathan Corbet" <corbet@lwn.net>, "Shuah Khan" <shuah@kernel.org>, "Yu Zhao" <yuzhao@google.com>, "Dave Hansen" <dave.hansen@linux.intel.com>, "Wei Xu" <weixugc@google.com>, "Greg Thelen" <gthelen@google.com>, "Chen Wandun" <chenwandun@huawei.com>, "Vaibhav Jain" <vaibhav@linux.ibm.com>, "Michal Koutný" <mkoutny@suse.com>, "Tim Chen" <tim.c.chen@linux.intel.com>, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, "Yosry Ahmed" <yosryahmed@google.com> Subject: [PATCH v5 0/4] memcg: introduce per-memcg proactive reclaim Date: Mon, 25 Apr 2022 19:00:36 +0000 [thread overview] Message-ID: <20220425190040.2475377-1-yosryahmed@google.com> (raw) This patch series adds a memory.reclaim proactive reclaim interface. The rationale behind the interface and how it works are in the first patch. --- Changes in V5: - Fixed comment formating and added Co-developed-by in patch 1. - Modified selftest to work if swap is enabled or not, and retry multiple times to wait for background allocation before failing with a clear message. Changes in V4: mm/memcontrol.c: - Return -EINTR on signal_pending(). - On the final retry, drain percpu lru caches hoping that it might introduce some evictable pages for reclaim. - Simplified the retry loop as suggested by Dan Schatzberg. selftests: - Always return -errno on failure from cg_write() (whether open() or write() fail), also update cg_read() and read_text() to return -errno as well for consistency. Also make sure to correctly check that the whole buffer was written in cg_write(). - Added a maximum number of retries for the reclaim selftest. Changes in V3: - Fix cg_write() (in patch 2) to properly return -1 if open() fails and not fail if len == errno. - Remove debug printf() in patch 3. Changes in V2: - Add the interface to root as well. - Added a selftest. - Documented the interface as a nested-keyed interface, which makes adding optional arguments in the future easier (see doc updates in the first patch). - Modified the commit message to reflect changes and added a timeout argument as a suggested possible extension - Return -EAGAIN if the kernel fails to reclaim the full requested amount. --- Shakeel Butt (1): memcg: introduce per-memcg reclaim interface Yosry Ahmed (3): selftests: cgroup: return -errno from cg_read()/cg_write() on failure selftests: cgroup: fix alloc_anon_noexit() instantly freeing memory selftests: cgroup: add a selftest for memory.reclaim Documentation/admin-guide/cgroup-v2.rst | 21 ++++ mm/memcontrol.c | 45 +++++++ tools/testing/selftests/cgroup/cgroup_util.c | 44 +++---- .../selftests/cgroup/test_memcontrol.c | 114 +++++++++++++++++- 4 files changed, 197 insertions(+), 27 deletions(-) -- 2.36.0.rc2.479.g8af0fa9b8e-goog
WARNING: multiple messages have this Message-ID (diff)
From: Yosry Ahmed <yosryahmed-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> To: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>, Michal Hocko <mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Shakeel Butt <shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>, Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>, Roman Gushchin <roman.gushchin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org> Cc: "David Rientjes" <rientjes-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>, "Tejun Heo" <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, "Zefan Li" <lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>, "Jonathan Corbet" <corbet-T1hC0tSOHrs@public.gmane.org>, "Shuah Khan" <shuah-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, "Yu Zhao" <yuzhao-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>, "Dave Hansen" <dave.hansen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>, "Wei Xu" <weixugc-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>, "Greg Thelen" <gthelen-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>, "Chen Wandun" <chenwandun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>, "Vaibhav Jain" <vaibhav-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org>, "Michal Koutný" <mkoutny-IBi9RG/b67k@public.gmane.org>, "Tim Chen" <tim.c.chen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, linux-kselftest-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Yosry Ahmed" <yosryahmed-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> Subject: [PATCH v5 0/4] memcg: introduce per-memcg proactive reclaim Date: Mon, 25 Apr 2022 19:00:36 +0000 [thread overview] Message-ID: <20220425190040.2475377-1-yosryahmed@google.com> (raw) This patch series adds a memory.reclaim proactive reclaim interface. The rationale behind the interface and how it works are in the first patch. --- Changes in V5: - Fixed comment formating and added Co-developed-by in patch 1. - Modified selftest to work if swap is enabled or not, and retry multiple times to wait for background allocation before failing with a clear message. Changes in V4: mm/memcontrol.c: - Return -EINTR on signal_pending(). - On the final retry, drain percpu lru caches hoping that it might introduce some evictable pages for reclaim. - Simplified the retry loop as suggested by Dan Schatzberg. selftests: - Always return -errno on failure from cg_write() (whether open() or write() fail), also update cg_read() and read_text() to return -errno as well for consistency. Also make sure to correctly check that the whole buffer was written in cg_write(). - Added a maximum number of retries for the reclaim selftest. Changes in V3: - Fix cg_write() (in patch 2) to properly return -1 if open() fails and not fail if len == errno. - Remove debug printf() in patch 3. Changes in V2: - Add the interface to root as well. - Added a selftest. - Documented the interface as a nested-keyed interface, which makes adding optional arguments in the future easier (see doc updates in the first patch). - Modified the commit message to reflect changes and added a timeout argument as a suggested possible extension - Return -EAGAIN if the kernel fails to reclaim the full requested amount. --- Shakeel Butt (1): memcg: introduce per-memcg reclaim interface Yosry Ahmed (3): selftests: cgroup: return -errno from cg_read()/cg_write() on failure selftests: cgroup: fix alloc_anon_noexit() instantly freeing memory selftests: cgroup: add a selftest for memory.reclaim Documentation/admin-guide/cgroup-v2.rst | 21 ++++ mm/memcontrol.c | 45 +++++++ tools/testing/selftests/cgroup/cgroup_util.c | 44 +++---- .../selftests/cgroup/test_memcontrol.c | 114 +++++++++++++++++- 4 files changed, 197 insertions(+), 27 deletions(-) -- 2.36.0.rc2.479.g8af0fa9b8e-goog
next reply other threads:[~2022-04-25 19:01 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-25 19:00 Yosry Ahmed [this message] 2022-04-25 19:00 ` [PATCH v5 0/4] memcg: introduce per-memcg proactive reclaim Yosry Ahmed 2022-04-25 19:00 ` [PATCH v5 1/4] memcg: introduce per-memcg reclaim interface Yosry Ahmed 2022-04-25 19:00 ` Yosry Ahmed 2022-04-25 19:15 ` David Rientjes 2022-04-25 19:15 ` David Rientjes 2022-04-25 19:31 ` Yosry Ahmed 2022-04-25 19:31 ` Yosry Ahmed 2022-04-26 8:22 ` Michal Hocko 2022-04-26 8:22 ` Michal Hocko 2022-05-04 0:13 ` Davidlohr Bueso 2022-05-04 0:13 ` Davidlohr Bueso 2022-04-25 19:00 ` [PATCH v5 2/4] selftests: cgroup: return -errno from cg_read()/cg_write() on failure Yosry Ahmed 2022-04-25 19:17 ` David Rientjes 2022-04-25 19:17 ` David Rientjes 2022-04-26 1:53 ` Roman Gushchin 2022-04-26 1:53 ` Roman Gushchin 2022-04-25 19:00 ` [PATCH v5 3/4] selftests: cgroup: fix alloc_anon_noexit() instantly freeing memory Yosry Ahmed 2022-04-25 19:18 ` David Rientjes 2022-04-25 19:00 ` [PATCH v5 4/4] selftests: cgroup: add a selftest for memory.reclaim Yosry Ahmed 2022-04-25 19:00 ` Yosry Ahmed 2022-04-25 19:21 ` David Rientjes
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220425190040.2475377-1-yosryahmed@google.com \ --to=yosryahmed@google.com \ --cc=akpm@linux-foundation.org \ --cc=cgroups@vger.kernel.org \ --cc=chenwandun@huawei.com \ --cc=corbet@lwn.net \ --cc=dave.hansen@linux.intel.com \ --cc=gthelen@google.com \ --cc=hannes@cmpxchg.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-kselftest@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=lizefan.x@bytedance.com \ --cc=mhocko@kernel.org \ --cc=mkoutny@suse.com \ --cc=rientjes@google.com \ --cc=roman.gushchin@linux.dev \ --cc=shakeelb@google.com \ --cc=shuah@kernel.org \ --cc=tim.c.chen@linux.intel.com \ --cc=tj@kernel.org \ --cc=vaibhav@linux.ibm.com \ --cc=weixugc@google.com \ --cc=yuzhao@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.