All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: ceph-devel@vger.kernel.org
Cc: xiubli@redhat.com, lhenriques@suse.de, idryomov@gmail.com
Subject: [PATCH v14 22/64] ceph: send altname in MClientRequest
Date: Wed, 27 Apr 2022 15:12:32 -0400	[thread overview]
Message-ID: <20220427191314.222867-23-jlayton@kernel.org> (raw)
In-Reply-To: <20220427191314.222867-1-jlayton@kernel.org>

In the event that we have a filename longer than CEPH_NOHASH_NAME_MAX,
we'll need to hash the tail of the filename. The client however will
still need to know the full name of the file if it has a key.

To support this, the MClientRequest field has grown a new alternate_name
field that we populate with the full (binary) crypttext of the filename.
This is then transmitted to the clients in readdir or traces as part of
the dentry lease.

Add support for populating this field when the filenames are very long.

Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
 fs/ceph/mds_client.c | 75 +++++++++++++++++++++++++++++++++++++++++---
 fs/ceph/mds_client.h |  3 ++
 2 files changed, 73 insertions(+), 5 deletions(-)

diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
index e31a5bec9afc..cc3c507c03eb 100644
--- a/fs/ceph/mds_client.c
+++ b/fs/ceph/mds_client.c
@@ -972,6 +972,7 @@ void ceph_mdsc_release_request(struct kref *kref)
 	if (req->r_pagelist)
 		ceph_pagelist_release(req->r_pagelist);
 	kfree(req->r_fscrypt_auth);
+	kfree(req->r_altname);
 	put_request_session(req);
 	ceph_unreserve_caps(req->r_mdsc, &req->r_caps_reservation);
 	WARN_ON_ONCE(!list_empty(&req->r_wait));
@@ -2386,6 +2387,63 @@ static inline  u64 __get_oldest_tid(struct ceph_mds_client *mdsc)
 	return mdsc->oldest_tid;
 }
 
+#if IS_ENABLED(CONFIG_FS_ENCRYPTION)
+static u8 *get_fscrypt_altname(const struct ceph_mds_request *req, u32 *plen)
+{
+	struct inode *dir = req->r_parent;
+	struct dentry *dentry = req->r_dentry;
+	u8 *cryptbuf = NULL;
+	u32 len = 0;
+	int ret = 0;
+
+	/* only encode if we have parent and dentry */
+	if (!dir || !dentry)
+		goto success;
+
+	/* No-op unless this is encrypted */
+	if (!IS_ENCRYPTED(dir))
+		goto success;
+
+	ret = __fscrypt_prepare_readdir(dir);
+	if (ret)
+		return ERR_PTR(ret);
+
+	/* No key? Just ignore it. */
+	if (!fscrypt_has_encryption_key(dir))
+		goto success;
+
+	if (!fscrypt_fname_encrypted_size(dir, dentry->d_name.len, NAME_MAX, &len)) {
+		WARN_ON_ONCE(1);
+		return ERR_PTR(-ENAMETOOLONG);
+	}
+
+	/* No need to append altname if name is short enough */
+	if (len <= CEPH_NOHASH_NAME_MAX) {
+		len = 0;
+		goto success;
+	}
+
+	cryptbuf = kmalloc(len, GFP_KERNEL);
+	if (!cryptbuf)
+		return ERR_PTR(-ENOMEM);
+
+	ret = fscrypt_fname_encrypt(dir, &dentry->d_name, cryptbuf, len);
+	if (ret) {
+		kfree(cryptbuf);
+		return ERR_PTR(ret);
+	}
+success:
+	*plen = len;
+	return cryptbuf;
+}
+#else
+static u8 *get_fscrypt_altname(const struct ceph_mds_request *req, u32 *plen)
+{
+	*plen = 0;
+	return NULL;
+}
+#endif
+
 /**
  * ceph_mdsc_build_path - build a path string to a given dentry
  * @dentry: dentry to which path should be built
@@ -2606,14 +2664,15 @@ static void encode_mclientrequest_tail(void **p, const struct ceph_mds_request *
 	ceph_encode_timespec64(&ts, &req->r_stamp);
 	ceph_encode_copy(p, &ts, sizeof(ts));
 
-	/* gid_list */
+	/* v4: gid_list */
 	ceph_encode_32(p, req->r_cred->group_info->ngroups);
 	for (i = 0; i < req->r_cred->group_info->ngroups; i++)
 		ceph_encode_64(p, from_kgid(&init_user_ns,
 					    req->r_cred->group_info->gid[i]));
 
-	/* v5: altname (TODO: skip for now) */
-	ceph_encode_32(p, 0);
+	/* v5: altname */
+	ceph_encode_32(p, req->r_altname_len);
+	ceph_encode_copy(p, req->r_altname, req->r_altname_len);
 
 	/* v6: fscrypt_auth and fscrypt_file */
 	if (req->r_fscrypt_auth) {
@@ -2669,7 +2728,13 @@ static struct ceph_msg *create_request_message(struct ceph_mds_session *session,
 		goto out_free1;
 	}
 
-	/* head */
+	req->r_altname = get_fscrypt_altname(req, &req->r_altname_len);
+	if (IS_ERR(req->r_altname)) {
+		msg = ERR_CAST(req->r_altname);
+		req->r_altname = NULL;
+		goto out_free2;
+	}
+
 	len = legacy ? sizeof(*head) : sizeof(struct ceph_mds_request_head);
 
 	/* filepaths */
@@ -2695,7 +2760,7 @@ static struct ceph_msg *create_request_message(struct ceph_mds_session *session,
 	len += sizeof(u32) + (sizeof(u64) * req->r_cred->group_info->ngroups);
 
 	/* alternate name */
-	len += sizeof(u32);	// TODO
+	len += sizeof(u32) + req->r_altname_len;
 
 	/* fscrypt_auth */
 	len += sizeof(u32); // fscrypt_auth
diff --git a/fs/ceph/mds_client.h b/fs/ceph/mds_client.h
index 2cc75f9ae7c7..cd719691a86d 100644
--- a/fs/ceph/mds_client.h
+++ b/fs/ceph/mds_client.h
@@ -290,6 +290,9 @@ struct ceph_mds_request {
 
 	struct ceph_fscrypt_auth *r_fscrypt_auth;
 
+	u8 *r_altname;		    /* fscrypt binary crypttext for long filenames */
+	u32 r_altname_len;	    /* length of r_altname */
+
 	int r_fmode;        /* file mode, if expecting cap */
 	int r_request_release_offset;
 	const struct cred *r_cred;
-- 
2.35.1


  parent reply	other threads:[~2022-04-27 19:16 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-27 19:12 [PATCH v14 00/64] ceph+fscrypt: full support Jeff Layton
2022-04-27 19:12 ` [PATCH v14 01/64] libceph: add spinlock around osd->o_requests Jeff Layton
2022-04-27 19:12 ` [PATCH v14 02/64] libceph: define struct ceph_sparse_extent and add some helpers Jeff Layton
2022-04-27 19:12 ` [PATCH v14 03/64] libceph: add sparse read support to msgr2 crc state machine Jeff Layton
2022-04-27 19:12 ` [PATCH v14 04/64] libceph: add sparse read support to OSD client Jeff Layton
2022-04-27 19:12 ` [PATCH v14 05/64] libceph: support sparse reads on msgr2 secure codepath Jeff Layton
2022-04-27 19:12 ` [PATCH v14 06/64] libceph: add sparse read support to msgr1 Jeff Layton
2022-04-27 19:12 ` [PATCH v14 07/64] ceph: add new mount option to enable sparse reads Jeff Layton
2022-04-27 19:12 ` [PATCH v14 08/64] fs: change test in inode_insert5 for adding to the sb list Jeff Layton
2022-04-27 19:12 ` [PATCH v14 09/64] fscrypt: export fscrypt_fname_encrypt and fscrypt_fname_encrypted_size Jeff Layton
2022-04-27 19:12 ` [PATCH v14 10/64] fscrypt: add fscrypt_context_for_new_inode Jeff Layton
2022-04-27 19:12 ` [PATCH v14 11/64] ceph: preallocate inode for ops that may create one Jeff Layton
2022-04-27 19:12 ` [PATCH v14 12/64] ceph: fscrypt_auth handling for ceph Jeff Layton
2022-04-27 19:12 ` [PATCH v14 13/64] ceph: ensure that we accept a new context from MDS for new inodes Jeff Layton
2022-04-27 19:12 ` [PATCH v14 14/64] ceph: add support for fscrypt_auth/fscrypt_file to cap messages Jeff Layton
2022-04-27 19:12 ` [PATCH v14 15/64] ceph: implement -o test_dummy_encryption mount option Jeff Layton
2022-04-27 19:12 ` [PATCH v14 16/64] ceph: decode alternate_name in lease info Jeff Layton
2022-04-27 19:12 ` [PATCH v14 17/64] ceph: add fscrypt ioctls Jeff Layton
2022-04-27 19:12 ` [PATCH v14 18/64] ceph: make the ioctl cmd more readable in debug log Jeff Layton
2022-04-27 19:12 ` [PATCH v14 19/64] ceph: make ceph_msdc_build_path use ref-walk Jeff Layton
2022-04-27 19:12 ` [PATCH v14 20/64] ceph: add base64 endcoding routines for encrypted names Jeff Layton
2022-04-27 19:12 ` [PATCH v14 21/64] ceph: add encrypted fname handling to ceph_mdsc_build_path Jeff Layton
2022-04-27 19:12 ` Jeff Layton [this message]
2022-04-27 19:12 ` [PATCH v14 23/64] ceph: encode encrypted name in dentry release Jeff Layton
2022-04-27 19:12 ` [PATCH v14 24/64] ceph: properly set DCACHE_NOKEY_NAME flag in lookup Jeff Layton
2022-04-27 19:12 ` [PATCH v14 25/64] ceph: set DCACHE_NOKEY_NAME in atomic open Jeff Layton
2022-04-27 19:12 ` [PATCH v14 26/64] ceph: make d_revalidate call fscrypt revalidator for encrypted dentries Jeff Layton
2022-04-27 19:12 ` [PATCH v14 27/64] ceph: add helpers for converting names for userland presentation Jeff Layton
2022-04-27 19:12 ` [PATCH v14 28/64] ceph: fix base64 encoded name's length check in ceph_fname_to_usr() Jeff Layton
2022-04-27 19:12 ` [PATCH v14 29/64] ceph: add fscrypt support to ceph_fill_trace Jeff Layton
2022-04-27 19:12 ` [PATCH v14 30/64] ceph: pass the request to parse_reply_info_readdir() Jeff Layton
2022-04-27 19:12 ` [PATCH v14 31/64] ceph: add ceph_encode_encrypted_dname() helper Jeff Layton
2022-04-27 19:12 ` [PATCH v14 32/64] ceph: add support to readdir for encrypted filenames Jeff Layton
2022-04-27 19:12 ` [PATCH v14 33/64] ceph: create symlinks with encrypted and base64-encoded targets Jeff Layton
2022-04-27 19:12 ` [PATCH v14 34/64] ceph: make ceph_get_name decrypt filenames Jeff Layton
2022-04-27 19:12 ` [PATCH v14 35/64] ceph: add a new ceph.fscrypt.auth vxattr Jeff Layton
2022-04-27 19:12 ` [PATCH v14 36/64] ceph: add some fscrypt guardrails Jeff Layton
2022-04-27 19:12 ` [PATCH v14 37/64] ceph: don't allow changing layout on encrypted files/directories Jeff Layton
2022-04-27 19:12 ` [PATCH v14 38/64] libceph: add CEPH_OSD_OP_ASSERT_VER support Jeff Layton
2022-04-27 19:12 ` [PATCH v14 39/64] ceph: size handling for encrypted inodes in cap updates Jeff Layton
2022-04-27 19:12 ` [PATCH v14 40/64] ceph: fscrypt_file field handling in MClientRequest messages Jeff Layton
2022-04-27 19:12 ` [PATCH v14 41/64] ceph: get file size from fscrypt_file when present in inode traces Jeff Layton
2022-04-27 19:12 ` [PATCH v14 42/64] ceph: handle fscrypt fields in cap messages from MDS Jeff Layton
2022-04-27 19:12 ` [PATCH v14 43/64] ceph: update WARN_ON message to pr_warn Jeff Layton
2022-04-27 19:12 ` [PATCH v14 44/64] ceph: add __ceph_get_caps helper support Jeff Layton
2022-04-27 19:12 ` [PATCH v14 45/64] ceph: add __ceph_sync_read " Jeff Layton
2022-04-27 19:12 ` [PATCH v14 46/64] ceph: add object version support for sync read Jeff Layton
2022-04-27 19:12 ` [PATCH v14 47/64] ceph: add infrastructure for file encryption and decryption Jeff Layton
2022-04-27 19:12 ` [PATCH v14 48/64] ceph: add truncate size handling support for fscrypt Jeff Layton
2022-04-27 19:12 ` [PATCH v14 49/64] libceph: allow ceph_osdc_new_request to accept a multi-op read Jeff Layton
2022-04-27 19:13 ` [PATCH v14 50/64] ceph: disable fallocate for encrypted inodes Jeff Layton
2022-04-27 19:13 ` [PATCH v14 51/64] ceph: disable copy offload on " Jeff Layton
2022-04-27 19:13 ` [PATCH v14 52/64] ceph: don't use special DIO path for " Jeff Layton
2022-04-27 19:13 ` [PATCH v14 53/64] ceph: align data in pages in ceph_sync_write Jeff Layton
2022-04-27 19:13 ` [PATCH v14 54/64] ceph: add read/modify/write to ceph_sync_write Jeff Layton
2022-04-27 19:13 ` [PATCH v14 55/64] ceph: plumb in decryption during sync reads Jeff Layton
2022-04-27 19:13 ` [PATCH v14 56/64] ceph: add fscrypt decryption support to ceph_netfs_issue_op Jeff Layton
2022-04-27 19:13 ` [PATCH v14 57/64] ceph: set i_blkbits to crypto block size for encrypted inodes Jeff Layton
2022-04-27 19:13 ` [PATCH v14 58/64] ceph: add encryption support to writepage Jeff Layton
2022-05-05  9:34   ` Xiubo Li
2022-05-05 10:53     ` Jeff Layton
2022-05-05 11:05       ` Xiubo Li
2022-05-05 11:12         ` Jeff Layton
2022-05-05 11:27           ` Xiubo Li
2022-06-02 16:08   ` Jeff Layton
2022-06-03  9:17     ` Luís Henriques
2022-06-03 12:24       ` Jeff Layton
2022-06-03 12:48         ` Xiubo Li
2022-06-03 11:33     ` Xiubo Li
2022-04-27 19:13 ` [PATCH v14 59/64] ceph: fscrypt support for writepages Jeff Layton
2022-04-27 19:13 ` [PATCH v14 60/64] ceph: invalidate pages when doing direct/sync writes Jeff Layton
2022-04-27 19:13 ` [PATCH v14 61/64] ceph: add support for encrypted snapshot names Jeff Layton
2022-04-27 19:13 ` [PATCH v14 62/64] ceph: add support for handling " Jeff Layton
2022-04-27 19:13 ` [PATCH v14 63/64] ceph: update documentation regarding snapshot naming limitations Jeff Layton
2022-04-27 19:13 ` [PATCH v14 64/64] ceph: prevent snapshots to be created in encrypted locked directories Jeff Layton
2022-05-09 11:53 ` [PATCH v14 00/64] ceph+fscrypt: full support Xiubo Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220427191314.222867-23-jlayton@kernel.org \
    --to=jlayton@kernel.org \
    --cc=ceph-devel@vger.kernel.org \
    --cc=idryomov@gmail.com \
    --cc=lhenriques@suse.de \
    --cc=xiubli@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.