From: Petr Vorel <pvorel@suse.cz> To: ltp@lists.linux.it Cc: "Petr Vorel" <pvorel@suse.cz>, "Steve Dickson" <steved@redhat.com>, libtirpc-devel@lists.sourceforge.net, linux-nfs@vger.kernel.org, "Cyril Hrubis" <chrubis@suse.cz>, automated-testing@yoctoproject.org, "Li Wang" <liwang@redhat.com>, "Jan Stancek" <jstancek@redhat.com>, "Yang Xu" <xuyang2018.jy@fujitsu.com>, "Anders Roxell" <anders.roxell@linaro.org>, "Naresh Kamboju" <naresh.kamboju@linaro.org>, "Daniel Díaz" <daniel.diaz@linaro.org>, "Chuck Lever" <chuck.lever@oracle.com>, "J . Bruce Fields" <bfields@fieldses.org>, "Trond Myklebust" <trondmy@hammerspace.com>, "Veronika Kabatova" <vkabatov@redhat.com>, "Alexey Kodanev" <aleksei.kodanev@bell-sw.com> Subject: [RFC PATCH 2/3] rpc: Remove rusers01.sh test Date: Thu, 28 Apr 2022 16:43:07 +0200 [thread overview] Message-ID: <20220428144308.32639-3-pvorel@suse.cz> (raw) In-Reply-To: <20220428144308.32639-1-pvorel@suse.cz> rusersd is a RPC daemon which returns information about users currently logged in to the system. It uses rusers on client side. Latest release of netkit-rusers 0.17 was in 2001. Although it's still installable on Debian, IMHO whole technology is not used nowadays. As we have other RPC tests (both RPC/TI-RPC and RPC integration, i.e. NFS), we don't need to test this particular implementation. If this implementation is really useful, it should be moved into libtirpc project. Signed-off-by: Petr Vorel <pvorel@suse.cz> --- runtest/net.rpc | 1 - .../network/rpc/basic_tests/rusers/Makefile | 29 ----------- .../rpc/basic_tests/rusers/rusers01.sh | 50 ------------------- 3 files changed, 80 deletions(-) delete mode 100644 testcases/network/rpc/basic_tests/rusers/Makefile delete mode 100755 testcases/network/rpc/basic_tests/rusers/rusers01.sh diff --git a/runtest/net.rpc b/runtest/net.rpc index ccee1dda7..d2cec5b93 100644 --- a/runtest/net.rpc +++ b/runtest/net.rpc @@ -4,4 +4,3 @@ # rpc01 rpc01.sh rpcinfo rpcinfo01.sh -rusers rusers01.sh diff --git a/testcases/network/rpc/basic_tests/rusers/Makefile b/testcases/network/rpc/basic_tests/rusers/Makefile deleted file mode 100644 index 345365171..000000000 --- a/testcases/network/rpc/basic_tests/rusers/Makefile +++ /dev/null @@ -1,29 +0,0 @@ -# -# network/rpc/basic_tests/rusers01.sh test suite Makefile. -# -# Copyright (C) 2009, Cisco Systems Inc. -# -# This program is free software; you can redistribute it and/or modify -# it under the terms of the GNU General Public License as published by -# the Free Software Foundation; either version 2 of the License, or -# (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. -# -# Ngie Cooper, July 2009 -# - -top_srcdir ?= ../../../../.. - -include $(top_srcdir)/include/mk/env_pre.mk - -INSTALL_TARGETS := rusers01.sh - -include $(top_srcdir)/include/mk/generic_leaf_target.mk diff --git a/testcases/network/rpc/basic_tests/rusers/rusers01.sh b/testcases/network/rpc/basic_tests/rusers/rusers01.sh deleted file mode 100755 index 554bfa01c..000000000 --- a/testcases/network/rpc/basic_tests/rusers/rusers01.sh +++ /dev/null @@ -1,50 +0,0 @@ -#!/bin/sh -# Copyright (c) 2017 Oracle and/or its affiliates. All Rights Reserved. -# Copyright (c) International Business Machines Corp., 2000 -# -# This program is free software; you can redistribute it and/or -# modify it under the terms of the GNU General Public License as -# published by the Free Software Foundation; either version 2 of -# the License, or (at your option) any later version. -# -# This program is distributed in the hope that it would be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program. If not, see <http://www.gnu.org/licenses/>. - -TCID="rusers01" -TST_TOTAL=5 - -TST_USE_LEGACY_API=1 -. tst_net.sh - -do_setup() -{ - tst_resm TINFO "Checking for rusersd on $(tst_ipaddr)" - rpcinfo -u $(tst_ipaddr) rusersd > /dev/null 2>&1 || \ - tst_brkm TCONF "rusersd is inactive on $(tst_ipaddr)" -} - -do_test() -{ - tst_resm TINFO "Test rusers with options set" - - EXPECT_RHOST_PASS rusers $(tst_ipaddr) - - local opts="-a -l" - for opt in $opts; do - EXPECT_RHOST_PASS rusers $opt $(tst_ipaddr) - done - - tst_resm TINFO "Test rusers with bad options" - EXPECT_RHOST_FAIL rusers bogushost - EXPECT_RHOST_FAIL rusers -bogusflag $(tst_ipaddr) -} - -do_setup -do_test - -tst_exit -- 2.35.3
WARNING: multiple messages have this Message-ID (diff)
From: Petr Vorel <pvorel@suse.cz> To: ltp@lists.linux.it Cc: "J . Bruce Fields" <bfields@fieldses.org>, linux-nfs@vger.kernel.org, Steve Dickson <steved@redhat.com>, Chuck Lever <chuck.lever@oracle.com>, automated-testing@yoctoproject.org, Trond Myklebust <trondmy@hammerspace.com>, libtirpc-devel@lists.sourceforge.net Subject: [LTP] [RFC PATCH 2/3] rpc: Remove rusers01.sh test Date: Thu, 28 Apr 2022 16:43:07 +0200 [thread overview] Message-ID: <20220428144308.32639-3-pvorel@suse.cz> (raw) In-Reply-To: <20220428144308.32639-1-pvorel@suse.cz> rusersd is a RPC daemon which returns information about users currently logged in to the system. It uses rusers on client side. Latest release of netkit-rusers 0.17 was in 2001. Although it's still installable on Debian, IMHO whole technology is not used nowadays. As we have other RPC tests (both RPC/TI-RPC and RPC integration, i.e. NFS), we don't need to test this particular implementation. If this implementation is really useful, it should be moved into libtirpc project. Signed-off-by: Petr Vorel <pvorel@suse.cz> --- runtest/net.rpc | 1 - .../network/rpc/basic_tests/rusers/Makefile | 29 ----------- .../rpc/basic_tests/rusers/rusers01.sh | 50 ------------------- 3 files changed, 80 deletions(-) delete mode 100644 testcases/network/rpc/basic_tests/rusers/Makefile delete mode 100755 testcases/network/rpc/basic_tests/rusers/rusers01.sh diff --git a/runtest/net.rpc b/runtest/net.rpc index ccee1dda7..d2cec5b93 100644 --- a/runtest/net.rpc +++ b/runtest/net.rpc @@ -4,4 +4,3 @@ # rpc01 rpc01.sh rpcinfo rpcinfo01.sh -rusers rusers01.sh diff --git a/testcases/network/rpc/basic_tests/rusers/Makefile b/testcases/network/rpc/basic_tests/rusers/Makefile deleted file mode 100644 index 345365171..000000000 --- a/testcases/network/rpc/basic_tests/rusers/Makefile +++ /dev/null @@ -1,29 +0,0 @@ -# -# network/rpc/basic_tests/rusers01.sh test suite Makefile. -# -# Copyright (C) 2009, Cisco Systems Inc. -# -# This program is free software; you can redistribute it and/or modify -# it under the terms of the GNU General Public License as published by -# the Free Software Foundation; either version 2 of the License, or -# (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. -# -# Ngie Cooper, July 2009 -# - -top_srcdir ?= ../../../../.. - -include $(top_srcdir)/include/mk/env_pre.mk - -INSTALL_TARGETS := rusers01.sh - -include $(top_srcdir)/include/mk/generic_leaf_target.mk diff --git a/testcases/network/rpc/basic_tests/rusers/rusers01.sh b/testcases/network/rpc/basic_tests/rusers/rusers01.sh deleted file mode 100755 index 554bfa01c..000000000 --- a/testcases/network/rpc/basic_tests/rusers/rusers01.sh +++ /dev/null @@ -1,50 +0,0 @@ -#!/bin/sh -# Copyright (c) 2017 Oracle and/or its affiliates. All Rights Reserved. -# Copyright (c) International Business Machines Corp., 2000 -# -# This program is free software; you can redistribute it and/or -# modify it under the terms of the GNU General Public License as -# published by the Free Software Foundation; either version 2 of -# the License, or (at your option) any later version. -# -# This program is distributed in the hope that it would be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program. If not, see <http://www.gnu.org/licenses/>. - -TCID="rusers01" -TST_TOTAL=5 - -TST_USE_LEGACY_API=1 -. tst_net.sh - -do_setup() -{ - tst_resm TINFO "Checking for rusersd on $(tst_ipaddr)" - rpcinfo -u $(tst_ipaddr) rusersd > /dev/null 2>&1 || \ - tst_brkm TCONF "rusersd is inactive on $(tst_ipaddr)" -} - -do_test() -{ - tst_resm TINFO "Test rusers with options set" - - EXPECT_RHOST_PASS rusers $(tst_ipaddr) - - local opts="-a -l" - for opt in $opts; do - EXPECT_RHOST_PASS rusers $opt $(tst_ipaddr) - done - - tst_resm TINFO "Test rusers with bad options" - EXPECT_RHOST_FAIL rusers bogushost - EXPECT_RHOST_FAIL rusers -bogusflag $(tst_ipaddr) -} - -do_setup -do_test - -tst_exit -- 2.35.3 -- Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-04-28 14:43 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-28 14:43 [RFC PATCH 0/3] Remove RPC rup and rusers tests Petr Vorel 2022-04-28 14:43 ` [LTP] " Petr Vorel 2022-04-28 14:43 ` [RFC PATCH 1/3] rpc: Remove rup01.sh test Petr Vorel 2022-04-28 14:43 ` [LTP] " Petr Vorel 2022-04-28 14:43 ` Petr Vorel [this message] 2022-04-28 14:43 ` [LTP] [RFC PATCH 2/3] rpc: Remove rusers01.sh test Petr Vorel 2022-04-28 14:43 ` [RFC PATCH 3/3] rpc: Move rest of RPC tests to runtest/net.rpc_tests Petr Vorel 2022-04-28 14:43 ` [LTP] " Petr Vorel 2022-04-29 7:48 ` [RFC PATCH 0/3] Remove RPC rup and rusers tests Petr Vorel 2022-04-29 7:48 ` [LTP] " Petr Vorel 2022-05-12 14:37 ` Cyril Hrubis 2022-05-12 14:37 ` [LTP] " Cyril Hrubis 2022-05-12 14:46 ` Petr Vorel 2022-05-12 14:46 ` [LTP] " Petr Vorel 2022-05-12 14:54 ` Cyril Hrubis 2022-05-12 14:54 ` [LTP] " Cyril Hrubis 2022-05-12 15:06 ` Petr Vorel 2022-05-12 15:06 ` [LTP] " Petr Vorel 2022-05-31 13:27 ` Cyril Hrubis 2022-05-31 13:27 ` [LTP] " Cyril Hrubis
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220428144308.32639-3-pvorel@suse.cz \ --to=pvorel@suse.cz \ --cc=aleksei.kodanev@bell-sw.com \ --cc=anders.roxell@linaro.org \ --cc=automated-testing@yoctoproject.org \ --cc=bfields@fieldses.org \ --cc=chrubis@suse.cz \ --cc=chuck.lever@oracle.com \ --cc=daniel.diaz@linaro.org \ --cc=jstancek@redhat.com \ --cc=libtirpc-devel@lists.sourceforge.net \ --cc=linux-nfs@vger.kernel.org \ --cc=liwang@redhat.com \ --cc=ltp@lists.linux.it \ --cc=naresh.kamboju@linaro.org \ --cc=steved@redhat.com \ --cc=trondmy@hammerspace.com \ --cc=vkabatov@redhat.com \ --cc=xuyang2018.jy@fujitsu.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.