All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Suchanek <msuchanek@suse.de>
To: nvdimm@lists.linux.dev
Cc: Michal Suchanek <msuchanek@suse.de>
Subject: [PATCH ndctl] test: monitor: Use in-tree configuration file
Date: Thu, 28 Apr 2022 21:08:31 +0200	[thread overview]
Message-ID: <20220428190831.15251-1-msuchanek@suse.de> (raw)

When ndctl is not installed /etc/ndctl.conf.d does not exist and the
monitor fails to start. Use in-tree configuration for testing.

Signed-off-by: Michal Suchanek <msuchanek@suse.de>
---
 test/monitor.sh | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/test/monitor.sh b/test/monitor.sh
index e58c908..c5beb2c 100755
--- a/test/monitor.sh
+++ b/test/monitor.sh
@@ -13,6 +13,8 @@ smart_supported_bus=""
 
 . $(dirname $0)/common
 
+monitor_conf="$TEST_PATH/../ndctl"
+
 check_prereq "jq"
 
 trap 'err $LINENO' ERR
@@ -22,7 +24,7 @@ check_min_kver "4.15" || do_skip "kernel $KVER may not support monitor service"
 start_monitor()
 {
 	logfile=$(mktemp)
-	$NDCTL monitor -l $logfile $1 &
+	$NDCTL monitor -c "$monitor_conf" -l $logfile $1 &
 	monitor_pid=$!
 	sync; sleep 3
 	truncate --size 0 $logfile #remove startup log
-- 
2.36.0


             reply	other threads:[~2022-04-28 19:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-28 19:08 Michal Suchanek [this message]
2022-04-28 20:59 ` [PATCH ndctl] test: monitor: Use in-tree configuration file Dan Williams
2022-05-02  9:33 ` [PATCH] " Shivaprasad G Bhat
2022-05-02  9:41   ` Michal Suchánek
2022-06-17 10:17   ` Michal Suchánek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220428190831.15251-1-msuchanek@suse.de \
    --to=msuchanek@suse.de \
    --cc=nvdimm@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.