All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: linux-omap@vger.kernel.org
Cc: "Benoît Cousson" <bcousson@baylibre.com>, devicetree@vger.kernel.org
Subject: [PATCH 15/19] ARM: dts: Group omap3 CM_FCLKEN_CAM clocks
Date: Fri, 29 Apr 2022 10:06:09 +0300	[thread overview]
Message-ID: <20220429070613.62360-16-tony@atomide.com> (raw)
In-Reply-To: <20220429070613.62360-1-tony@atomide.com>

The clksel related registers on omap3 cause unique_unit_address and
node_name_chars_strict warnings with the W=1 or W=2 make flags enabled.

With the clock drivers updated, we can now avoid most of these warnings
by grouping the TI component clocks using the TI clksel binding, and
with the use of clock-output-names property to avoid non-standard node
names for the clocks.

Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 .../boot/dts/omap34xx-omap36xx-clocks.dtsi    | 38 +++++++++++--------
 1 file changed, 23 insertions(+), 15 deletions(-)

diff --git a/arch/arm/boot/dts/omap34xx-omap36xx-clocks.dtsi b/arch/arm/boot/dts/omap34xx-omap36xx-clocks.dtsi
--- a/arch/arm/boot/dts/omap34xx-omap36xx-clocks.dtsi
+++ b/arch/arm/boot/dts/omap34xx-omap36xx-clocks.dtsi
@@ -60,13 +60,29 @@ pka_ick: clock-pka-ick {
 		};
 	};
 
-	cam_mclk: cam_mclk@f00 {
-		#clock-cells = <0>;
-		compatible = "ti,gate-clock";
-		clocks = <&dpll4_m5x2_ck>;
-		ti,bit-shift = <0>;
-		reg = <0x0f00>;
-		ti,set-rate-parent;
+	/* CM_FCLKEN_CAM */
+	clock@f00 {
+		compatible = "ti,clksel";
+		reg = <0xf00>;
+		#clock-cells = <2>;
+		#address-cells = <0>;
+
+		cam_mclk: clock-cam-mclk {
+			#clock-cells = <0>;
+			compatible = "ti,gate-clock";
+			clock-output-names = "cam_mclk";
+			clocks = <&dpll4_m5x2_ck>;
+			ti,bit-shift = <0>;
+			ti,set-rate-parent;
+		};
+
+		csi2_96m_fck: clock-csi2-96m-fck {
+			#clock-cells = <0>;
+			compatible = "ti,gate-clock";
+			clock-output-names = "csi2_96m_fck";
+			clocks = <&core_96m_fck>;
+			ti,bit-shift = <1>;
+		};
 	};
 
 	cam_ick: cam_ick@f10 {
@@ -77,14 +93,6 @@ cam_ick: cam_ick@f10 {
 		ti,bit-shift = <0>;
 	};
 
-	csi2_96m_fck: csi2_96m_fck@f00 {
-		#clock-cells = <0>;
-		compatible = "ti,gate-clock";
-		clocks = <&core_96m_fck>;
-		reg = <0x0f00>;
-		ti,bit-shift = <1>;
-	};
-
 	security_l3_ick: security_l3_ick {
 		#clock-cells = <0>;
 		compatible = "fixed-factor-clock";
-- 
2.35.2

  parent reply	other threads:[~2022-04-29  7:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-29  7:05 [PATCH 00/19] Clean-up for lots of omap dtb warnings Tony Lindgren
2022-04-29  7:05 ` [PATCH 01/19] ARM: dts: Group omap3 CONTROL_DEVCONF0 clocks Tony Lindgren
2022-04-29  7:05 ` [PATCH 02/19] ARM: dts: Group omap3 CONTROL_DEVCONF1 clocks Tony Lindgren
2022-04-29  7:05 ` [PATCH 03/19] ARM: dts: Group omap3 CM_FCLKEN1_CORE clocks Tony Lindgren
2022-04-29  7:05 ` [PATCH 04/19] ARM: dts: Group omap3 crypto accelerator clocks Tony Lindgren
2022-04-29  7:05 ` [PATCH 05/19] ARM: dts: Group omap3 CM_ICLKEN1_CORE clocks Tony Lindgren
2022-04-29  7:06 ` [PATCH 06/19] ARM: dts: Group omap3 CM_ICLKEN3_CORE clocks Tony Lindgren
2022-04-29  7:06 ` [PATCH 07/19] ARM: dts: Group omap3 CM_CLKSEL_CORE clocks Tony Lindgren
2022-04-29  7:06 ` [PATCH 08/19] ARM: dts: Group omap3 CM_FCLKEN_WKUP clocks Tony Lindgren
2022-04-29  7:06 ` [PATCH 09/19] ARM: dts: Group omap3 CM_ICLKEN_WKUP clocks Tony Lindgren
2022-04-29  7:06 ` [PATCH 10/19] ARM: dts: Group omap3 CM_CLKSEL_WKUP clocks Tony Lindgren
2022-04-29  7:06 ` [PATCH 11/19] ARM: dts: Group omap3 CM_CLKSEL1_PLL clocks Tony Lindgren
2022-04-29  7:06 ` [PATCH 12/19] ARM: dts: Group omap3 CM_CLKOUT_CTRL clocks Tony Lindgren
2022-04-29  7:06 ` [PATCH 13/19] ARM: dts: Group omap3 CM_FCLKEN_DSS clocks Tony Lindgren
2022-04-29  7:06 ` [PATCH 14/19] ARM: dts: Group omap3 CM_CLKSEL_DSS clocks Tony Lindgren
2022-04-29  7:06 ` Tony Lindgren [this message]
2022-04-29  7:06 ` [PATCH 16/19] ARM: dts: Group omap3 CM_FCLKEN_PER clocks Tony Lindgren
2022-04-29  7:06 ` [PATCH 17/19] ARM: dts: Group omap3 CM_ICLKEN_PER clocks Tony Lindgren
2022-04-29  7:06 ` [PATCH 18/19] ARM: dts: Group omap3 CM_CLKSEL_PER clocks Tony Lindgren
2022-04-29  7:06 ` [PATCH 19/19] ARM: dts: Group omap3 CM_CLKSEL1_EMU clocks Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220429070613.62360-16-tony@atomide.com \
    --to=tony@atomide.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.