All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian Göttsche" <cgzones@googlemail.com>
To: selinux@vger.kernel.org
Cc: Serge Hallyn <serge@hallyn.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Alexander Aring <aahringo@redhat.com>,
	Ziyang Xuan <william.xuanziyang@huawei.com>,
	Eric Dumazet <edumazet@google.com>,
	linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH v2 8/8] net: use new capable_or functionality
Date: Mon,  2 May 2022 18:00:29 +0200	[thread overview]
Message-ID: <20220502160030.131168-7-cgzones@googlemail.com> (raw)
In-Reply-To: <20220502160030.131168-1-cgzones@googlemail.com>

Use the new added capable_or function in appropriate cases, where a task
is required to have any of two capabilities.

Reorder CAP_SYS_ADMIN last.

Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
---
 net/caif/caif_socket.c | 2 +-
 net/unix/scm.c         | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/caif/caif_socket.c b/net/caif/caif_socket.c
index 2b8892d502f7..60498148126c 100644
--- a/net/caif/caif_socket.c
+++ b/net/caif/caif_socket.c
@@ -1036,7 +1036,7 @@ static int caif_create(struct net *net, struct socket *sock, int protocol,
 		.usersize = sizeof_field(struct caifsock, conn_req.param)
 	};
 
-	if (!capable(CAP_SYS_ADMIN) && !capable(CAP_NET_ADMIN))
+	if (!capable_or(CAP_NET_ADMIN, CAP_SYS_ADMIN))
 		return -EPERM;
 	/*
 	 * The sock->type specifies the socket type to use.
diff --git a/net/unix/scm.c b/net/unix/scm.c
index aa27a02478dc..821be80e6c85 100644
--- a/net/unix/scm.c
+++ b/net/unix/scm.c
@@ -99,7 +99,7 @@ static inline bool too_many_unix_fds(struct task_struct *p)
 	struct user_struct *user = current_user();
 
 	if (unlikely(user->unix_inflight > task_rlimit(p, RLIMIT_NOFILE)))
-		return !capable(CAP_SYS_RESOURCE) && !capable(CAP_SYS_ADMIN);
+		return !capable_or(CAP_SYS_RESOURCE, CAP_SYS_ADMIN);
 	return false;
 }
 
-- 
2.36.0


  parent reply	other threads:[~2022-05-02 16:01 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-17 14:49 [RFC PATCH 2/2] capability: use new capable_or functionality Christian Göttsche
2022-02-17 14:49 ` [RFC PATCH 1/2] capability: add capable_or to test for multiple caps with exactly one audit message Christian Göttsche
2022-05-02 16:00   ` [PATCH v2 2/8] capability: use new capable_or functionality Christian Göttsche
2022-05-02 16:00     ` [PATCH v2 3/8] block: " Christian Göttsche
2022-05-02 16:00     ` [PATCH v2 4/8] drivers: " Christian Göttsche
2022-05-09 10:44       ` Jiri Slaby
2022-05-09 10:46       ` Hans Verkuil
2022-05-02 16:00     ` [PATCH v2 5/8] fs: " Christian Göttsche
2022-05-02 16:00     ` [PATCH v2 6/8] kernel: " Christian Göttsche
2022-05-02 16:00     ` [PATCH v2 7/8] kernel/bpf: " Christian Göttsche
2022-05-02 16:00     ` Christian Göttsche [this message]
2022-05-09 17:15       ` [PATCH v2 8/8] net: " Serge E. Hallyn
2022-05-22 17:33         ` Serge E. Hallyn
2022-05-02 16:00     ` [PATCH v2 1/8] capability: add capable_or to test for multiple caps with exactly one audit message Christian Göttsche
2022-05-09 17:12       ` Serge E. Hallyn
2022-06-15 15:26       ` [PATCH v3 2/8] capability: use new capable_any functionality Christian Göttsche
2022-06-15 15:26         ` [PATCH v3 3/8] block: " Christian Göttsche
2022-06-16  3:00           ` Bart Van Assche
2022-06-15 15:26         ` [PATCH v3 4/8] drivers: " Christian Göttsche
2022-06-15 15:45           ` Laurent Pinchart
2022-06-15 15:26         ` [PATCH v3 5/8] fs: " Christian Göttsche
2022-06-28 12:56           ` Christian Brauner
2022-06-28 14:11             ` Christian Göttsche
2022-06-15 15:26         ` [PATCH v3 6/8] kernel: " Christian Göttsche
2022-06-15 15:26         ` [PATCH v3 7/8] bpf: " Christian Göttsche
2022-06-15 15:26         ` [PATCH v3 8/8] net: " Christian Göttsche
2022-06-15 15:26         ` [PATCH v3 1/8] capability: add any wrapper to test for multiple caps with exactly one audit message Christian Göttsche
2022-06-26 22:34           ` Serge E. Hallyn
2022-08-30 15:05             ` Christian Göttsche
2022-08-30 15:10               ` Paul Moore
2022-09-02  0:56           ` Paul Moore
2022-09-02  1:35             ` Paul Moore
2022-02-17 17:29 ` [RFC PATCH 2/2] capability: use new capable_or functionality Alexei Starovoitov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220502160030.131168-7-cgzones@googlemail.com \
    --to=cgzones@googlemail.com \
    --cc=aahringo@redhat.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=selinux@vger.kernel.org \
    --cc=serge@hallyn.com \
    --cc=william.xuanziyang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.