From: Marc Kleine-Budde <mkl@pengutronix.de> To: linux-spi@vger.kernel.org, Fabio Estevam <festevam@gmail.com>, Marek Vasut <marex@denx.de> Cc: kernel@pengutronix.de, linux-imx@nxp.com, Mark Brown <broonie@kernel.org>, linux-arm-kernel@lists.infradead.org, Baruch Siach <baruch@tkos.co.il>, Marc Kleine-Budde <mkl@pengutronix.de> Subject: [PATCH v1 4/9] spi: spi-imx: spi_imx_buf_rx_swap_u32(): fix sparse warning: use swab32s() instead of cpu_to_be32() Date: Mon, 2 May 2022 19:54:52 +0200 [thread overview] Message-ID: <20220502175457.1977983-5-mkl@pengutronix.de> (raw) In-Reply-To: <20220502175457.1977983-1-mkl@pengutronix.de> This patch fixes the following sparse warning by using a swab32s() instead of a cpu_to_be32(). The driver is used on little endian systems only and we really want to swap the bytes. | drivers/spi/spi-imx.c:305:29: warning: incorrect type in assignment (different base types) | drivers/spi/spi-imx.c:305:29: expected unsigned int val | drivers/spi/spi-imx.c:305:29: got restricted __be32 [usertype] | drivers/spi/spi-imx.c:361:21: warning: incorrect type in assignment (different base types) | drivers/spi/spi-imx.c:361:21: expected unsigned int [assigned] [usertype] val | drivers/spi/spi-imx.c:361:21: got restricted __be32 [usertype] Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> --- drivers/spi/spi-imx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index 895c7514325b..86391f869444 100644 --- a/drivers/spi/spi-imx.c +++ b/drivers/spi/spi-imx.c @@ -298,7 +298,7 @@ static void spi_imx_buf_rx_swap_u32(struct spi_imx_data *spi_imx) #ifdef __LITTLE_ENDIAN bytes_per_word = spi_imx_bytes_per_word(spi_imx->bits_per_word); if (bytes_per_word == 1) - val = cpu_to_be32(val); + swab32s(&val); else if (bytes_per_word == 2) val = (val << 16) | (val >> 16); #endif @@ -354,7 +354,7 @@ static void spi_imx_buf_tx_swap_u32(struct spi_imx_data *spi_imx) bytes_per_word = spi_imx_bytes_per_word(spi_imx->bits_per_word); if (bytes_per_word == 1) - val = cpu_to_be32(val); + swab32s(&val); else if (bytes_per_word == 2) val = (val << 16) | (val >> 16); #endif -- 2.35.1
WARNING: multiple messages have this Message-ID (diff)
From: Marc Kleine-Budde <mkl@pengutronix.de> To: linux-spi@vger.kernel.org, Fabio Estevam <festevam@gmail.com>, Marek Vasut <marex@denx.de> Cc: kernel@pengutronix.de, linux-imx@nxp.com, Mark Brown <broonie@kernel.org>, linux-arm-kernel@lists.infradead.org, Baruch Siach <baruch@tkos.co.il>, Marc Kleine-Budde <mkl@pengutronix.de> Subject: [PATCH v1 4/9] spi: spi-imx: spi_imx_buf_rx_swap_u32(): fix sparse warning: use swab32s() instead of cpu_to_be32() Date: Mon, 2 May 2022 19:54:52 +0200 [thread overview] Message-ID: <20220502175457.1977983-5-mkl@pengutronix.de> (raw) In-Reply-To: <20220502175457.1977983-1-mkl@pengutronix.de> This patch fixes the following sparse warning by using a swab32s() instead of a cpu_to_be32(). The driver is used on little endian systems only and we really want to swap the bytes. | drivers/spi/spi-imx.c:305:29: warning: incorrect type in assignment (different base types) | drivers/spi/spi-imx.c:305:29: expected unsigned int val | drivers/spi/spi-imx.c:305:29: got restricted __be32 [usertype] | drivers/spi/spi-imx.c:361:21: warning: incorrect type in assignment (different base types) | drivers/spi/spi-imx.c:361:21: expected unsigned int [assigned] [usertype] val | drivers/spi/spi-imx.c:361:21: got restricted __be32 [usertype] Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> --- drivers/spi/spi-imx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index 895c7514325b..86391f869444 100644 --- a/drivers/spi/spi-imx.c +++ b/drivers/spi/spi-imx.c @@ -298,7 +298,7 @@ static void spi_imx_buf_rx_swap_u32(struct spi_imx_data *spi_imx) #ifdef __LITTLE_ENDIAN bytes_per_word = spi_imx_bytes_per_word(spi_imx->bits_per_word); if (bytes_per_word == 1) - val = cpu_to_be32(val); + swab32s(&val); else if (bytes_per_word == 2) val = (val << 16) | (val >> 16); #endif @@ -354,7 +354,7 @@ static void spi_imx_buf_tx_swap_u32(struct spi_imx_data *spi_imx) bytes_per_word = spi_imx_bytes_per_word(spi_imx->bits_per_word); if (bytes_per_word == 1) - val = cpu_to_be32(val); + swab32s(&val); else if (bytes_per_word == 2) val = (val << 16) | (val >> 16); #endif -- 2.35.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-02 18:02 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-02 17:54 [PATCH v1 0/9] spi: spi-imx: cleanups and performance improvements Marc Kleine-Budde 2022-05-02 17:54 ` Marc Kleine-Budde 2022-05-02 17:54 ` [PATCH v1 1/9] spi: spi-imx: fix sparse warning: add identifier name to function definition Marc Kleine-Budde 2022-05-02 17:54 ` Marc Kleine-Budde 2022-05-02 17:54 ` [PATCH v1 2/9] spi: spi-imx: avoid unnecessary line continuations Marc Kleine-Budde 2022-05-02 17:54 ` Marc Kleine-Budde 2022-05-02 17:54 ` [PATCH v1 3/9] spi: spi-imx: mx51_ecspi_intctrl(): prefer 'unsigned int' to bare use of 'unsigned' Marc Kleine-Budde 2022-05-02 17:54 ` Marc Kleine-Budde 2022-05-02 17:54 ` Marc Kleine-Budde [this message] 2022-05-02 17:54 ` [PATCH v1 4/9] spi: spi-imx: spi_imx_buf_rx_swap_u32(): fix sparse warning: use swab32s() instead of cpu_to_be32() Marc Kleine-Budde 2022-05-02 17:54 ` [PATCH v1 5/9] spi: spi-imx: spi_imx_buf_rx_swap_u32(): replace open coded swahw32s() Marc Kleine-Budde 2022-05-02 17:54 ` Marc Kleine-Budde 2022-05-02 17:54 ` [PATCH v1 6/9] spi: spi-imx: complete conversion from master -> controller Marc Kleine-Budde 2022-05-02 17:54 ` Marc Kleine-Budde 2022-05-02 17:54 ` [PATCH v1 7/9] spi: spi-imx: replace struct spi_imx_data::bitbang by pointer to struct spi_controller Marc Kleine-Budde 2022-05-02 17:54 ` Marc Kleine-Budde 2022-05-02 17:54 ` [PATCH v1 8/9] spi: spi-imx: add PIO polling support Marc Kleine-Budde 2022-05-02 17:54 ` Marc Kleine-Budde 2022-05-02 17:54 ` [PATCH v1 9/9] spi: spi-imx: mx51_ecspi_prepare_message(): skip writing MX51_ECSPI_CONFIG register if unchanged Marc Kleine-Budde 2022-05-02 17:54 ` Marc Kleine-Budde 2022-05-09 21:13 ` [PATCH v1 0/9] spi: spi-imx: cleanups and performance improvements Mark Brown 2022-05-09 21:13 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220502175457.1977983-5-mkl@pengutronix.de \ --to=mkl@pengutronix.de \ --cc=baruch@tkos.co.il \ --cc=broonie@kernel.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-spi@vger.kernel.org \ --cc=marex@denx.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.