From: Eugen Hristev <eugen.hristev@microchip.com> To: <linux-media@vger.kernel.org>, <hverkuil@xs4all.nl> Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <jacopo@jmondi.org>, Eugen Hristev <eugen.hristev@microchip.com> Subject: [PATCH v10 1/8] media: atmel: atmel-isc-base: use streaming status when queueing buffers Date: Tue, 3 May 2022 11:44:14 +0300 [thread overview] Message-ID: <20220503084421.40682-2-eugen.hristev@microchip.com> (raw) In-Reply-To: <20220503084421.40682-1-eugen.hristev@microchip.com> During experiments with libcamera, it looks like vb2_is_streaming returns true before our start streaming is called. Order of operations is streamon -> queue -> start_streaming ISC would have started the DMA immediately when a buffer is being added to the vbqueue if the queue is streaming. It is more safe to start the DMA after the start streaming of the driver is called. Thus, even if vb2queue is streaming, add the buffer to the dma queue of the driver instead of actually starting the DMA process, if the start streaming has not been called yet. Tho achieve this, we have to use vb2_start_streaming_called instead of vb2_is_streaming. Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> --- drivers/media/platform/atmel/atmel-isc-base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/atmel/atmel-isc-base.c b/drivers/media/platform/atmel/atmel-isc-base.c index db15770d5b88..d2cc6c99984f 100644 --- a/drivers/media/platform/atmel/atmel-isc-base.c +++ b/drivers/media/platform/atmel/atmel-isc-base.c @@ -442,7 +442,7 @@ static void isc_buffer_queue(struct vb2_buffer *vb) spin_lock_irqsave(&isc->dma_queue_lock, flags); if (!isc->cur_frm && list_empty(&isc->dma_queue) && - vb2_is_streaming(vb->vb2_queue)) { + vb2_start_streaming_called(vb->vb2_queue)) { isc->cur_frm = buf; isc_start_dma(isc); } else -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Eugen Hristev <eugen.hristev@microchip.com> To: <linux-media@vger.kernel.org>, <hverkuil@xs4all.nl> Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <jacopo@jmondi.org>, Eugen Hristev <eugen.hristev@microchip.com> Subject: [PATCH v10 1/8] media: atmel: atmel-isc-base: use streaming status when queueing buffers Date: Tue, 3 May 2022 11:44:14 +0300 [thread overview] Message-ID: <20220503084421.40682-2-eugen.hristev@microchip.com> (raw) In-Reply-To: <20220503084421.40682-1-eugen.hristev@microchip.com> During experiments with libcamera, it looks like vb2_is_streaming returns true before our start streaming is called. Order of operations is streamon -> queue -> start_streaming ISC would have started the DMA immediately when a buffer is being added to the vbqueue if the queue is streaming. It is more safe to start the DMA after the start streaming of the driver is called. Thus, even if vb2queue is streaming, add the buffer to the dma queue of the driver instead of actually starting the DMA process, if the start streaming has not been called yet. Tho achieve this, we have to use vb2_start_streaming_called instead of vb2_is_streaming. Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> --- drivers/media/platform/atmel/atmel-isc-base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/atmel/atmel-isc-base.c b/drivers/media/platform/atmel/atmel-isc-base.c index db15770d5b88..d2cc6c99984f 100644 --- a/drivers/media/platform/atmel/atmel-isc-base.c +++ b/drivers/media/platform/atmel/atmel-isc-base.c @@ -442,7 +442,7 @@ static void isc_buffer_queue(struct vb2_buffer *vb) spin_lock_irqsave(&isc->dma_queue_lock, flags); if (!isc->cur_frm && list_empty(&isc->dma_queue) && - vb2_is_streaming(vb->vb2_queue)) { + vb2_start_streaming_called(vb->vb2_queue)) { isc->cur_frm = buf; isc_start_dma(isc); } else -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-03 8:45 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-03 8:44 [PATCH v10 0/8] media: atmel: atmel-isc: various fixes Eugen Hristev 2022-05-03 8:44 ` Eugen Hristev 2022-05-03 8:44 ` Eugen Hristev [this message] 2022-05-03 8:44 ` [PATCH v10 1/8] media: atmel: atmel-isc-base: use streaming status when queueing buffers Eugen Hristev 2022-05-03 8:44 ` [PATCH v10 2/8] media: atmel: atmel-isc-base: replace is_streaming call in s_fmt_vid_cap Eugen Hristev 2022-05-03 8:44 ` Eugen Hristev 2022-05-03 8:44 ` [PATCH v10 3/8] media: atmel: atmel-isc: remove redundant comments Eugen Hristev 2022-05-03 8:44 ` Eugen Hristev 2022-05-03 8:44 ` [PATCH v10 4/8] media: atmel: atmel-sama5d2-isc: fix wrong mask in YUYV format check Eugen Hristev 2022-05-03 8:44 ` Eugen Hristev 2022-05-03 8:44 ` [PATCH v10 5/8] media: atmel: atmel-isc-base: use mutex to lock awb workq from streaming Eugen Hristev 2022-05-03 8:44 ` Eugen Hristev 2022-05-03 8:44 ` [PATCH v10 6/8] media: atmel: atmel-isc: compact the controller formats list Eugen Hristev 2022-05-03 8:44 ` Eugen Hristev 2022-05-03 8:44 ` [PATCH v10 7/8] media: atmel: atmel-sama7g5-isc: remove stray line Eugen Hristev 2022-05-03 8:44 ` Eugen Hristev 2022-05-03 8:44 ` [PATCH v10 8/8] dt-bindings: media: microchip,xisc: add bus-width of 14 Eugen Hristev 2022-05-03 8:44 ` [PATCH v10 8/8] dt-bindings: media: microchip, xisc: " Eugen Hristev
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220503084421.40682-2-eugen.hristev@microchip.com \ --to=eugen.hristev@microchip.com \ --cc=devicetree@vger.kernel.org \ --cc=hverkuil@xs4all.nl \ --cc=jacopo@jmondi.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.