All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Mickaël Salaün" <mic@digikod.net>
To: James Morris <jmorris@namei.org>, "Serge E . Hallyn" <serge@hallyn.com>
Cc: "Mickaël Salaün" <mic@digikod.net>,
	"Kees Cook" <keescook@chromium.org>,
	"Konstantin Meskhidze" <konstantin.meskhidze@huawei.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Paul Moore" <paul@paul-moore.com>,
	"Shuah Khan" <shuah@kernel.org>, "Tom Rix" <trix@redhat.com>,
	linux-kernel@vger.kernel.org,
	linux-security-module@vger.kernel.org
Subject: [PATCH v1 0/7] Landlock: Clean up coding style with clang-format
Date: Fri,  6 May 2022 18:05:06 +0200	[thread overview]
Message-ID: <20220506160513.523257-1-mic@digikod.net> (raw)

Hi,

I used a simple coding style for the initial Landlock code.  However,
this may be subject to different interpretations.  To avoid relying
on tacit knowledge or text editors for these kind of rules, let's
automate it as much as possible thanks to clang-format.  This makes the
code formatting simple, consistent and impersonal.

Several versions of clang-format can be use but they may have (small)
different behaviors for undefined/new configuration parts.  After
testing different versions, I picked clang-format-14 which is relatively
new and fixes a bug present in version 11 to 13 (visible in the Landlock
formatted code).

I'll backport these patches and enforce this formatting for all the new
Landlock patches.

This series uses a patched clang-format configuration to make it
compatible with checkpatch.pl:
https://lore.kernel.org/r/20220506160106.522341-1-mic@digikod.net

It can be applied on v5.18-rc5 .

Regards,

Mickaël Salaün (7):
  landlock: Add clang-format exceptions
  landlock: Format with clang-format
  selftests/landlock: Add clang-format exceptions
  selftests/landlock: Normalize array assignment
  selftests/landlock: Format with clang-format
  samples/landlock: Add clang-format exceptions
  samples/landlock: Format with clang-format

 include/uapi/linux/landlock.h                 |   4 +
 samples/landlock/sandboxer.c                  | 104 ++--
 security/landlock/cred.c                      |   4 +-
 security/landlock/cred.h                      |   8 +-
 security/landlock/fs.c                        |  80 +--
 security/landlock/fs.h                        |  11 +-
 security/landlock/limits.h                    |   4 +
 security/landlock/object.c                    |   6 +-
 security/landlock/object.h                    |   6 +-
 security/landlock/ptrace.c                    |  10 +-
 security/landlock/ruleset.c                   |  80 +--
 security/landlock/ruleset.h                   |  15 +-
 security/landlock/syscalls.c                  |  60 +-
 tools/testing/selftests/landlock/base_test.c  |  80 +--
 tools/testing/selftests/landlock/common.h     |  66 ++-
 tools/testing/selftests/landlock/fs_test.c    | 532 ++++++++++--------
 .../testing/selftests/landlock/ptrace_test.c  |  38 +-
 17 files changed, 615 insertions(+), 493 deletions(-)


base-commit: 5c22d35e0cc57032edd92df16f530e3c9a33c027
-- 
2.35.1


             reply	other threads:[~2022-05-06 16:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-06 16:05 Mickaël Salaün [this message]
2022-05-06 16:05 ` [PATCH v1 1/7] landlock: Add clang-format exceptions Mickaël Salaün
2022-05-06 16:05 ` [PATCH v1 2/7] landlock: Format with clang-format Mickaël Salaün
2022-05-06 16:05 ` [PATCH v1 3/7] selftests/landlock: Add clang-format exceptions Mickaël Salaün
2022-05-06 16:05 ` [PATCH v1 4/7] selftests/landlock: Normalize array assignment Mickaël Salaün
2022-05-06 16:05 ` [PATCH v1 5/7] selftests/landlock: Format with clang-format Mickaël Salaün
2022-05-06 16:05 ` [PATCH v1 6/7] samples/landlock: Add clang-format exceptions Mickaël Salaün
2022-05-06 16:05 ` [PATCH v1 7/7] samples/landlock: Format with clang-format Mickaël Salaün
2022-05-09  9:06 ` [PATCH v1 0/7] Landlock: Clean up coding style " Miguel Ojeda
2022-05-09  9:45   ` Mickaël Salaün

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220506160513.523257-1-mic@digikod.net \
    --to=mic@digikod.net \
    --cc=jmorris@namei.org \
    --cc=keescook@chromium.org \
    --cc=konstantin.meskhidze@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=ojeda@kernel.org \
    --cc=paul@paul-moore.com \
    --cc=serge@hallyn.com \
    --cc=shuah@kernel.org \
    --cc=trix@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.