All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gaosheng Cui <cuigaosheng1@huawei.com>
To: <catalin.marinas@arm.com>, <cuigaosheng1@huawei.com>,
	<will@kernel.org>, <broonie@kernel.org>, <pcc@google.com>,
	<mark.rutland@arm.com>, <keescook@chromium.org>,
	<daniel.kiss@arm.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <wangweiyang2@huawei.com>,
	<gongruiqi1@huawei.com>
Subject: [PATCH -next] arm64: add missing header dependencies
Date: Mon, 9 May 2022 14:17:51 +0800	[thread overview]
Message-ID: <20220509061751.3434059-1-cuigaosheng1@huawei.com> (raw)

We get one error when building module with processor.h:

./arch/arm64/include/asm/processor.h:263:36: error: implicit declaration of function ‘task_stack_page’;
  ((struct pt_regs *)(THREAD_SIZE + task_stack_page(p)) - 1)
./arch/arm64/include/asm/processor.h:266:42: note: in expansion of macro ‘task_pt_regs’
 #define KSTK_ESP(tsk) user_stack_pointer(task_pt_regs(tsk))

task_stack_page is declared in linux/sched/task_stack.h, so this patch
add the missing header dependencies.

Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
---
 arch/arm64/include/asm/processor.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/include/asm/processor.h b/arch/arm64/include/asm/processor.h
index 73e38d9a540c..1c239841c4d6 100644
--- a/arch/arm64/include/asm/processor.h
+++ b/arch/arm64/include/asm/processor.h
@@ -28,6 +28,7 @@
 #include <linux/build_bug.h>
 #include <linux/cache.h>
 #include <linux/init.h>
+#include <linux/sched/task_stack.h>
 #include <linux/stddef.h>
 #include <linux/string.h>
 #include <linux/thread_info.h>
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Gaosheng Cui <cuigaosheng1@huawei.com>
To: <catalin.marinas@arm.com>, <cuigaosheng1@huawei.com>,
	<will@kernel.org>, <broonie@kernel.org>, <pcc@google.com>,
	<mark.rutland@arm.com>, <keescook@chromium.org>,
	<daniel.kiss@arm.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <wangweiyang2@huawei.com>,
	<gongruiqi1@huawei.com>
Subject: [PATCH -next] arm64: add missing header dependencies
Date: Mon, 9 May 2022 14:17:51 +0800	[thread overview]
Message-ID: <20220509061751.3434059-1-cuigaosheng1@huawei.com> (raw)

We get one error when building module with processor.h:

./arch/arm64/include/asm/processor.h:263:36: error: implicit declaration of function ‘task_stack_page’;
  ((struct pt_regs *)(THREAD_SIZE + task_stack_page(p)) - 1)
./arch/arm64/include/asm/processor.h:266:42: note: in expansion of macro ‘task_pt_regs’
 #define KSTK_ESP(tsk) user_stack_pointer(task_pt_regs(tsk))

task_stack_page is declared in linux/sched/task_stack.h, so this patch
add the missing header dependencies.

Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
---
 arch/arm64/include/asm/processor.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/include/asm/processor.h b/arch/arm64/include/asm/processor.h
index 73e38d9a540c..1c239841c4d6 100644
--- a/arch/arm64/include/asm/processor.h
+++ b/arch/arm64/include/asm/processor.h
@@ -28,6 +28,7 @@
 #include <linux/build_bug.h>
 #include <linux/cache.h>
 #include <linux/init.h>
+#include <linux/sched/task_stack.h>
 #include <linux/stddef.h>
 #include <linux/string.h>
 #include <linux/thread_info.h>
-- 
2.25.1


             reply	other threads:[~2022-05-09  6:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-09  6:17 Gaosheng Cui [this message]
2022-05-09  6:17 ` [PATCH -next] arm64: add missing header dependencies Gaosheng Cui
2022-05-10 10:40 ` Will Deacon
2022-05-10 10:40   ` Will Deacon
     [not found]   ` <3b692d9f-0f76-33b8-0c22-909a24377e33@huawei.com>
2022-05-11  8:30     ` Mark Rutland
2022-05-11  8:30       ` Mark Rutland
2022-05-13  2:57 ` kernel test robot
2022-05-13  2:57   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220509061751.3434059-1-cuigaosheng1@huawei.com \
    --to=cuigaosheng1@huawei.com \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=daniel.kiss@arm.com \
    --cc=gongruiqi1@huawei.com \
    --cc=keescook@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pcc@google.com \
    --cc=wangweiyang2@huawei.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.