All of lore.kernel.org
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	qemu-devel@nongnu.org, "Sven Schnelle" <svens@stackframe.org>
Subject: [PATCH 2/6] artist: Introduce constant for max cursor size
Date: Thu, 12 May 2022 01:50:50 +0200	[thread overview]
Message-ID: <20220511235054.185435-3-deller@gmx.de> (raw)
In-Reply-To: <20220511235054.185435-1-deller@gmx.de>

Add the constant NGLE_MAX_SPRITE_SIZE which defines the currently
maximum supported cursor size.

Signed-off-by: Helge Deller <deller@gmx.de>
---
 hw/display/artist.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/hw/display/artist.c b/hw/display/artist.c
index 39fc0c4ca5..6333ee41db 100644
--- a/hw/display/artist.c
+++ b/hw/display/artist.c
@@ -98,6 +98,9 @@ struct ARTISTState {
     int draw_line_pattern;
 };

+/* hardware allows up to 64x64, but we emulate 32x32 only. */
+#define NGLE_MAX_SPRITE_SIZE    32
+
 typedef enum {
     ARTIST_BUFFER_AP = 1,
     ARTIST_BUFFER_OVERLAY = 2,
@@ -1325,11 +1328,10 @@ static void artist_realizefn(DeviceState *dev, Error **errp)
     framebuffer_update_memory_section(&s->fbsection, &buf->mr, 0,
                                       buf->width, buf->height);
     /*
-     * no idea whether the cursor is fixed size or not, so assume 32x32 which
-     * seems sufficient for HP-UX X11.
+     * Artist cursor max size
      */
-    s->cursor_height = 32;
-    s->cursor_width = 32;
+    s->cursor_height = NGLE_MAX_SPRITE_SIZE;
+    s->cursor_width = NGLE_MAX_SPRITE_SIZE;

     /*
      * These two registers are not initialized by seabios's STI implementation.
--
2.35.3



  parent reply	other threads:[~2022-05-11 23:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-11 23:50 [PATCH 0/6] hppa: Artist graphics driver fixes for HP-UX Helge Deller
2022-05-11 23:50 ` [PATCH 1/6] seabios-hppa: Update SeaBIOS-hppa to VERSION 4 Helge Deller
2022-05-11 23:50 ` Helge Deller [this message]
2022-05-11 23:50 ` [PATCH 3/6] artist: Use human-readable variable names instead of reg_xxx Helge Deller
2022-05-11 23:50 ` [PATCH 4/6] artist: Fix vertical X11 cursor position in HP-UX Helge Deller
2022-05-11 23:50 ` [PATCH 5/6] artist: Allow to turn cursor on or off Helge Deller
2022-05-11 23:50 ` [PATCH 6/6] artist: Emulate screen blanking Helge Deller
     [not found] ` <3574c102-ba23-07b9-e6df-818c53718de7@gmx.de>
2022-05-12 12:05   ` [PATCH 0/6] hppa: Artist graphics driver fixes for HP-UX Helge Deller
2022-05-16  7:19 ` Mark Cave-Ayland
2022-05-16 14:43   ` Helge Deller
2022-05-16 16:52     ` Mark Cave-Ayland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220511235054.185435-3-deller@gmx.de \
    --to=deller@gmx.de \
    --cc=f4bug@amsat.org \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=svens@stackframe.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.