From: Oliver Neukum <oneukum@suse.com>
To: linux-media@vger.kernel.org, mchehab@kernel.org, sean@mess.org,
benpicco@googlemail.com
Cc: Oliver Neukum <oneukum@suse.com>
Subject: [PATCH] xbox_remote: xbox_remote_initialize() cannot fail
Date: Thu, 12 May 2022 15:38:58 +0200 [thread overview]
Message-ID: <20220512133858.5335-1-oneukum@suse.com> (raw)
It cannot fail. Make it void.
Signed-off-by: Oliver Neukum <oneukum@suse.com>
---
drivers/media/rc/xbox_remote.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/media/rc/xbox_remote.c b/drivers/media/rc/xbox_remote.c
index 98d0b43608ad..301682af0cec 100644
--- a/drivers/media/rc/xbox_remote.c
+++ b/drivers/media/rc/xbox_remote.c
@@ -163,7 +163,7 @@ static void xbox_remote_rc_init(struct xbox_remote *xbox_remote)
rdev->dev.parent = &xbox_remote->interface->dev;
}
-static int xbox_remote_initialize(struct xbox_remote *xbox_remote,
+static void xbox_remote_initialize(struct xbox_remote *xbox_remote,
struct usb_endpoint_descriptor *endpoint_in)
{
struct usb_device *udev = xbox_remote->udev;
@@ -177,8 +177,6 @@ static int xbox_remote_initialize(struct xbox_remote *xbox_remote,
usb_fill_int_urb(xbox_remote->irq_urb, udev, pipe, xbox_remote->inbuf,
maxp, xbox_remote_irq_in, xbox_remote,
endpoint_in->bInterval);
-
- return 0;
}
/*
@@ -249,9 +247,7 @@ static int xbox_remote_probe(struct usb_interface *interface,
xbox_remote_rc_init(xbox_remote);
/* Device Hardware Initialization */
- err = xbox_remote_initialize(xbox_remote, endpoint_in);
- if (err)
- goto exit_kill_urbs;
+ xbox_remote_initialize(xbox_remote, endpoint_in);
/* Set up and register rc device */
err = rc_register_device(xbox_remote->rdev);
--
2.35.3
reply other threads:[~2022-05-12 13:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220512133858.5335-1-oneukum@suse.com \
--to=oneukum@suse.com \
--cc=benpicco@googlemail.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sean@mess.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.