From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> To: igt-dev@lists.freedesktop.org Cc: Intel-gfx@lists.freedesktop.org Subject: [Intel-gfx] [PATCH i-g-t] tests/core_hotunplug: Check sysfs reads after hotunplug Date: Fri, 13 May 2022 10:31:28 +0100 [thread overview] Message-ID: <20220513093128.1027997-1-tvrtko.ursulin@linux.intel.com> (raw) From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Leave some sysfs files open and attempt to read from them after hotunplug. Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Ashutosh Dixit <ashutosh.dixit@intel.com> --- tests/core_hotunplug.c | 62 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 62 insertions(+) diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c index 02eae19e1e16..c3831541202d 100644 --- a/tests/core_hotunplug.c +++ b/tests/core_hotunplug.c @@ -602,6 +602,59 @@ static void hotreplug_lateclose(struct hotunplug *priv) igt_assert_f(healthcheck(priv, false), "%s\n", priv->failure); } +static void hotunplug_sysfs(struct hotunplug *priv) +{ + int i915, sysfs; + struct { + int fd; + const char *path; + char buf[256]; + } *item, items[] = { + { .fd = -1, .path = "error" }, + { .fd = -1, .path = "gt_act_freq_mhz" }, + { .fd = -1, .path = "gt/gt0/rps_act_freq_mhz" }, + { .fd = -1, .path = "gt/gt0/rc6_residency_ms" }, + { .fd = -1, .path = "engine/rcs0/name" }, + { .fd = -1, .path = "engine/bcs0/name" }, + { .path = NULL }, + }; + unsigned int cnt = 0; + + pre_check(priv); + + i915 = local_drm_open_driver(false, "", " for hot unplug"); + sysfs = igt_sysfs_open(i915); + igt_require(sysfs >= 0); + for (item = &items[0]; item->path; item++) { + item->fd = openat(sysfs, item->path, O_RDONLY); + cnt += item->fd >= 0; + } + close(sysfs); + close_device(i915, " ", "sysfs open "); + + igt_require(cnt >= 3); + + device_unplug(priv, "hot ", 60); + + sleep(2); + + for (item = &items[0]; item->path; item++) { + ssize_t len; + int err; + + if (item->fd < 0) + continue; + + len = read(item->fd, item->buf, sizeof(item->buf)); + err = len < 0 ? -errno : 0; + close(item->fd); + igt_debug("%s='%s' (%d)\n", item->path, item->buf, err); + igt_assert_eq(err, -ENODEV); + } + + igt_assert_f(healthcheck(priv, false), "%s\n", priv->failure); +} + /* Main */ igt_main @@ -735,6 +788,15 @@ igt_main recover(&priv); } + igt_subtest_group { + igt_describe("Check if sysfs files left open can be safely accessed after hotunplug."); + igt_subtest("hotunplug-sysfs") + hotunplug_sysfs(&priv); + + igt_fixture + recover(&priv); + } + igt_fixture { post_healthcheck(&priv); -- 2.32.0
WARNING: multiple messages have this Message-ID (diff)
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> To: igt-dev@lists.freedesktop.org Cc: Intel-gfx@lists.freedesktop.org, Tvrtko Ursulin <tvrtko.ursulin@intel.com> Subject: [igt-dev] [PATCH i-g-t] tests/core_hotunplug: Check sysfs reads after hotunplug Date: Fri, 13 May 2022 10:31:28 +0100 [thread overview] Message-ID: <20220513093128.1027997-1-tvrtko.ursulin@linux.intel.com> (raw) From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Leave some sysfs files open and attempt to read from them after hotunplug. Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Ashutosh Dixit <ashutosh.dixit@intel.com> --- tests/core_hotunplug.c | 62 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 62 insertions(+) diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c index 02eae19e1e16..c3831541202d 100644 --- a/tests/core_hotunplug.c +++ b/tests/core_hotunplug.c @@ -602,6 +602,59 @@ static void hotreplug_lateclose(struct hotunplug *priv) igt_assert_f(healthcheck(priv, false), "%s\n", priv->failure); } +static void hotunplug_sysfs(struct hotunplug *priv) +{ + int i915, sysfs; + struct { + int fd; + const char *path; + char buf[256]; + } *item, items[] = { + { .fd = -1, .path = "error" }, + { .fd = -1, .path = "gt_act_freq_mhz" }, + { .fd = -1, .path = "gt/gt0/rps_act_freq_mhz" }, + { .fd = -1, .path = "gt/gt0/rc6_residency_ms" }, + { .fd = -1, .path = "engine/rcs0/name" }, + { .fd = -1, .path = "engine/bcs0/name" }, + { .path = NULL }, + }; + unsigned int cnt = 0; + + pre_check(priv); + + i915 = local_drm_open_driver(false, "", " for hot unplug"); + sysfs = igt_sysfs_open(i915); + igt_require(sysfs >= 0); + for (item = &items[0]; item->path; item++) { + item->fd = openat(sysfs, item->path, O_RDONLY); + cnt += item->fd >= 0; + } + close(sysfs); + close_device(i915, " ", "sysfs open "); + + igt_require(cnt >= 3); + + device_unplug(priv, "hot ", 60); + + sleep(2); + + for (item = &items[0]; item->path; item++) { + ssize_t len; + int err; + + if (item->fd < 0) + continue; + + len = read(item->fd, item->buf, sizeof(item->buf)); + err = len < 0 ? -errno : 0; + close(item->fd); + igt_debug("%s='%s' (%d)\n", item->path, item->buf, err); + igt_assert_eq(err, -ENODEV); + } + + igt_assert_f(healthcheck(priv, false), "%s\n", priv->failure); +} + /* Main */ igt_main @@ -735,6 +788,15 @@ igt_main recover(&priv); } + igt_subtest_group { + igt_describe("Check if sysfs files left open can be safely accessed after hotunplug."); + igt_subtest("hotunplug-sysfs") + hotunplug_sysfs(&priv); + + igt_fixture + recover(&priv); + } + igt_fixture { post_healthcheck(&priv); -- 2.32.0
next reply other threads:[~2022-05-13 9:31 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-13 9:31 Tvrtko Ursulin [this message] 2022-05-13 9:31 ` [igt-dev] [PATCH i-g-t] tests/core_hotunplug: Check sysfs reads after hotunplug Tvrtko Ursulin 2022-05-13 10:13 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork 2022-05-13 11:20 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork 2022-05-13 19:24 ` [Intel-gfx] [PATCH i-g-t] " Dixit, Ashutosh 2022-05-13 19:24 ` [igt-dev] " Dixit, Ashutosh
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220513093128.1027997-1-tvrtko.ursulin@linux.intel.com \ --to=tvrtko.ursulin@linux.intel.com \ --cc=Intel-gfx@lists.freedesktop.org \ --cc=igt-dev@lists.freedesktop.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.