All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Chi <andy.chi@canonical.com>
To: unlisted-recipients:; (no To-header on input)
Cc: andy.chi@canonical.com, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	Jeremy Szu <jeremy.szu@canonical.com>,
	Werner Sembach <wse@tuxedocomputers.com>,
	Kai-Heng Feng <kai.heng.feng@canonical.com>,
	Lucas Tanure <tanureal@opensource.cirrus.com>,
	Cameron Berkenpas <cam@neo-zeon.de>,
	Kailang Yang <kailang@realtek.com>,
	Yong Wu <yong.wu@mediatek.com>,
	Elia Devito <eliadevito@gmail.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: [PATCH] ALSA: hda/realtek: fix right sounds and mute/micmute LEDs for HP machine
Date: Fri, 13 May 2022 20:16:45 +0800	[thread overview]
Message-ID: <20220513121648.28584-1-andy.chi@canonical.com> (raw)

* The HP EliteBook 630 is using ALC236 codec which used 0x02 to control mute LED
  and 0x01 to control micmute LED. Therefore, add a quirk to make it works.

Signed-off-by: Andy Chi <andy.chi@canonical.com>
---
 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 33c439578a61..3a1500e487eb 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9091,6 +9091,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x8995, "HP EliteBook 855 G9", ALC287_FIXUP_CS35L41_I2C_2),
 	SND_PCI_QUIRK(0x103c, 0x89a4, "HP ProBook 440 G9", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x89a6, "HP ProBook 450 G9", ALC236_FIXUP_HP_GPIO_LED),
+	SND_PCI_QUIRK(0x103c, 0x89aa, "HP EliteBook 630 G9", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x89ac, "HP EliteBook 640 G9", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x89ae, "HP EliteBook 650 G9", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x89c3, "Zbook Studio G9", ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED),
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Andy Chi <andy.chi@canonical.com>
Cc: alsa-devel@alsa-project.org, Kailang Yang <kailang@realtek.com>,
	Lucas Tanure <tanureal@opensource.cirrus.com>,
	Jeremy Szu <jeremy.szu@canonical.com>,
	linux-kernel@vger.kernel.org, Elia Devito <eliadevito@gmail.com>,
	Takashi Iwai <tiwai@suse.com>,
	Werner Sembach <wse@tuxedocomputers.com>,
	Kai-Heng Feng <kai.heng.feng@canonical.com>,
	andy.chi@canonical.com, Cameron Berkenpas <cam@neo-zeon.de>,
	Yong Wu <yong.wu@mediatek.com>
Subject: [PATCH] ALSA: hda/realtek: fix right sounds and mute/micmute LEDs for HP machine
Date: Fri, 13 May 2022 20:16:45 +0800	[thread overview]
Message-ID: <20220513121648.28584-1-andy.chi@canonical.com> (raw)

* The HP EliteBook 630 is using ALC236 codec which used 0x02 to control mute LED
  and 0x01 to control micmute LED. Therefore, add a quirk to make it works.

Signed-off-by: Andy Chi <andy.chi@canonical.com>
---
 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 33c439578a61..3a1500e487eb 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9091,6 +9091,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x8995, "HP EliteBook 855 G9", ALC287_FIXUP_CS35L41_I2C_2),
 	SND_PCI_QUIRK(0x103c, 0x89a4, "HP ProBook 440 G9", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x89a6, "HP ProBook 450 G9", ALC236_FIXUP_HP_GPIO_LED),
+	SND_PCI_QUIRK(0x103c, 0x89aa, "HP EliteBook 630 G9", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x89ac, "HP EliteBook 640 G9", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x89ae, "HP EliteBook 650 G9", ALC236_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x89c3, "Zbook Studio G9", ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED),
-- 
2.25.1


             reply	other threads:[~2022-05-13 12:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-13 12:16 Andy Chi [this message]
2022-05-13 12:16 ` [PATCH] ALSA: hda/realtek: fix right sounds and mute/micmute LEDs for HP machine Andy Chi
2022-05-16  7:43 ` Takashi Iwai
2022-05-16  7:43   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220513121648.28584-1-andy.chi@canonical.com \
    --to=andy.chi@canonical.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=cam@neo-zeon.de \
    --cc=eliadevito@gmail.com \
    --cc=jeremy.szu@canonical.com \
    --cc=kai.heng.feng@canonical.com \
    --cc=kailang@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tanureal@opensource.cirrus.com \
    --cc=tiwai@suse.com \
    --cc=wse@tuxedocomputers.com \
    --cc=yong.wu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.