All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xianting Tian <xianting.tian@linux.alibaba.com>
To: paul.walmsley@sifive.com, aou@eecs.berkeley.edu,
	palmer@dabbelt.com, wangkefeng.wang@huawei.com,
	vitaly.wool@konsulko.com, rmk+kernel@armlinux.org.uk,
	ebiederm@xmission.com, tongtiangen@huawei.co
Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	guoren@kernel.org, mick@ics.forth.gr,
	Xianting Tian <xianting.tian@linux.alibaba.com>
Subject: [PATCH] RISC-V: Add fast call path of crash_kexec()
Date: Sun, 15 May 2022 21:14:07 +0800	[thread overview]
Message-ID: <20220515131407.946832-1-xianting.tian@linux.alibaba.com> (raw)

Currently, almost all archs (x86, arm64, mips...) support fast call
of crash_kexec() when "regs && kexec_should_crash()" is true. But
RISC-V not, it can only enter crash system via panic(). However panic()
doesn't pass the regs of the real accident scene to crash_kexec(),
it caused we can't get accurate backtrace via gdb,
	$ riscv64-linux-gnu-gdb vmlinux vmcore
	Reading symbols from vmlinux...
	[New LWP 95]
	#0  console_unlock () at kernel/printk/printk.c:2557
	2557                    if (do_cond_resched)
	(gdb) bt
	#0  console_unlock () at kernel/printk/printk.c:2557
	#1  0x0000000000000000 in ?? ()

With the patch we can get the accurate backtrace,
	$ riscv64-linux-gnu-gdb vmlinux vmcore
	Reading symbols from vmlinux...
	[New LWP 95]
	#0  0xffffffe00063a4e0 in test_thread (data=<optimized out>) at drivers/virtio/virtio_mmio.c:806
	806             *(int *)p = 0xdead;
	(gdb)
	(gdb) bt
	#0  0xffffffe00063a4e0 in test_thread (data=<optimized out>) at drivers/virtio/virtio_mmio.c:806
	#1  0x0000000000000000 in ?? ()

Test code to produce NULL address dereference,
	+extern int panic_on_oops;
	+static struct task_struct *k;
	+static int test_thread(void *data) {
	+
	+       void *p = NULL;
	+
	+       while (!panic_on_oops)
	+               msleep(2000);
	+
	+       *(int *)p = 0xdead;
	+
	+       return 0;
	+}
	+
	 static int __init virtio_mmio_init(void)
	 {
	+       k = kthread_run(test_thread, NULL, "test_thread");
	+       if (IS_ERR(k))
	+               pr_err("Couldn't create test kthread\n");
	+
	        return platform_driver_register(&virtio_mmio_driver);
	 }

Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
---
 arch/riscv/kernel/traps.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/riscv/kernel/traps.c b/arch/riscv/kernel/traps.c
index fe92e119e6a3..e666ebfa2a64 100644
--- a/arch/riscv/kernel/traps.c
+++ b/arch/riscv/kernel/traps.c
@@ -16,6 +16,7 @@
 #include <linux/mm.h>
 #include <linux/module.h>
 #include <linux/irq.h>
+#include <linux/kexec.h>
 
 #include <asm/asm-prototypes.h>
 #include <asm/bug.h>
@@ -44,6 +45,9 @@ void die(struct pt_regs *regs, const char *str)
 
 	ret = notify_die(DIE_OOPS, str, regs, 0, regs->cause, SIGSEGV);
 
+	if (regs && kexec_should_crash(current))
+		crash_kexec(regs);
+
 	bust_spinlocks(0);
 	add_taint(TAINT_DIE, LOCKDEP_NOW_UNRELIABLE);
 	spin_unlock_irq(&die_lock);
-- 
2.17.1


WARNING: multiple messages have this Message-ID (diff)
From: Xianting Tian <xianting.tian@linux.alibaba.com>
To: paul.walmsley@sifive.com, aou@eecs.berkeley.edu,
	palmer@dabbelt.com, wangkefeng.wang@huawei.com,
	vitaly.wool@konsulko.com, rmk+kernel@armlinux.org.uk,
	ebiederm@xmission.com, tongtiangen@huawei.co
Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	guoren@kernel.org, mick@ics.forth.gr,
	Xianting Tian <xianting.tian@linux.alibaba.com>
Subject: [PATCH] RISC-V: Add fast call path of crash_kexec()
Date: Sun, 15 May 2022 21:14:07 +0800	[thread overview]
Message-ID: <20220515131407.946832-1-xianting.tian@linux.alibaba.com> (raw)

Currently, almost all archs (x86, arm64, mips...) support fast call
of crash_kexec() when "regs && kexec_should_crash()" is true. But
RISC-V not, it can only enter crash system via panic(). However panic()
doesn't pass the regs of the real accident scene to crash_kexec(),
it caused we can't get accurate backtrace via gdb,
	$ riscv64-linux-gnu-gdb vmlinux vmcore
	Reading symbols from vmlinux...
	[New LWP 95]
	#0  console_unlock () at kernel/printk/printk.c:2557
	2557                    if (do_cond_resched)
	(gdb) bt
	#0  console_unlock () at kernel/printk/printk.c:2557
	#1  0x0000000000000000 in ?? ()

With the patch we can get the accurate backtrace,
	$ riscv64-linux-gnu-gdb vmlinux vmcore
	Reading symbols from vmlinux...
	[New LWP 95]
	#0  0xffffffe00063a4e0 in test_thread (data=<optimized out>) at drivers/virtio/virtio_mmio.c:806
	806             *(int *)p = 0xdead;
	(gdb)
	(gdb) bt
	#0  0xffffffe00063a4e0 in test_thread (data=<optimized out>) at drivers/virtio/virtio_mmio.c:806
	#1  0x0000000000000000 in ?? ()

Test code to produce NULL address dereference,
	+extern int panic_on_oops;
	+static struct task_struct *k;
	+static int test_thread(void *data) {
	+
	+       void *p = NULL;
	+
	+       while (!panic_on_oops)
	+               msleep(2000);
	+
	+       *(int *)p = 0xdead;
	+
	+       return 0;
	+}
	+
	 static int __init virtio_mmio_init(void)
	 {
	+       k = kthread_run(test_thread, NULL, "test_thread");
	+       if (IS_ERR(k))
	+               pr_err("Couldn't create test kthread\n");
	+
	        return platform_driver_register(&virtio_mmio_driver);
	 }

Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
---
 arch/riscv/kernel/traps.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/riscv/kernel/traps.c b/arch/riscv/kernel/traps.c
index fe92e119e6a3..e666ebfa2a64 100644
--- a/arch/riscv/kernel/traps.c
+++ b/arch/riscv/kernel/traps.c
@@ -16,6 +16,7 @@
 #include <linux/mm.h>
 #include <linux/module.h>
 #include <linux/irq.h>
+#include <linux/kexec.h>
 
 #include <asm/asm-prototypes.h>
 #include <asm/bug.h>
@@ -44,6 +45,9 @@ void die(struct pt_regs *regs, const char *str)
 
 	ret = notify_die(DIE_OOPS, str, regs, 0, regs->cause, SIGSEGV);
 
+	if (regs && kexec_should_crash(current))
+		crash_kexec(regs);
+
 	bust_spinlocks(0);
 	add_taint(TAINT_DIE, LOCKDEP_NOW_UNRELIABLE);
 	spin_unlock_irq(&die_lock);
-- 
2.17.1


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

             reply	other threads:[~2022-05-15 13:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-15 13:14 Xianting Tian [this message]
2022-05-15 13:14 ` [PATCH] RISC-V: Add fast call path of crash_kexec() Xianting Tian
2022-05-16  6:51 ` Guo Ren
2022-05-16  6:51   ` Guo Ren
2022-05-24  1:50 ` Xianting Tian
2022-05-24  1:50   ` Xianting Tian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220515131407.946832-1-xianting.tian@linux.alibaba.com \
    --to=xianting.tian@linux.alibaba.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=ebiederm@xmission.com \
    --cc=guoren@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=mick@ics.forth.gr \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=tongtiangen@huawei.co \
    --cc=vitaly.wool@konsulko.com \
    --cc=wangkefeng.wang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.