All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: fstests@vger.kernel.org
Subject: [PATCH 1/4] fstests: fix group list generation for whacky test names
Date: Mon, 16 May 2022 18:59:19 +1000	[thread overview]
Message-ID: <20220516085922.1306879-2-david@fromorbit.com> (raw)
In-Reply-To: <20220516085922.1306879-1-david@fromorbit.com>

From: Dave Chinner <dchinner@redhat.com>

Darrick noticed that tests/xfs/191-input-validation didn't get
generated properly. Fix the regex to handle this.

$ grep -I -R "^_begin_fstest" tests/xfs | \
  sed -e 's/^.*\/\([0-9]*\):_begin_fstest/\1/' |grep 191
tests/xfs/191-input-validation:_begin_fstest auto quick mkfs realtime
$
$ grep -I -R "^_begin_fstest" tests/xfs | \
  sed -e 's/^.*\/\([0-9]*\).*:_begin_fstest/\1/ ' |grep 191
191 auto quick mkfs realtime
$

Long term, we should rename that test to '191' and rip out all that
unused and unnecessary complexity for matching ascii test names
because we just don't use it. Numbers for tests are still working
just fine.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
 tools/mkgroupfile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/mkgroupfile b/tools/mkgroupfile
index 24435898..958d4e2f 100755
--- a/tools/mkgroupfile
+++ b/tools/mkgroupfile
@@ -60,7 +60,7 @@ ENDL
 
 	# Aggregate the groups each test belongs to for the group file
 	grep -I -R "^_begin_fstest" $test_dir/ | \
-		sed -e 's/^.*\/\([0-9]*\):_begin_fstest/\1/' >> $new_groups
+		sed -e 's/^.*\/\([0-9]*\).*:_begin_fstest/\1/' >> $new_groups
 
 	# Create the list of unique groups for existence checking
 	grep -I -R "^_begin_fstest" $test_dir/ | \
-- 
2.35.1


  reply	other threads:[~2022-05-16  8:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-16  8:59 [PATCH 0/3] fstests: more fixes Dave Chinner
2022-05-16  8:59 ` Dave Chinner [this message]
2022-05-16 16:20   ` [PATCH 1/4] fstests: fix group list generation for whacky test names Darrick J. Wong
2022-05-16 21:35     ` Dave Chinner
2022-05-16 22:26       ` Darrick J. Wong
2022-05-17  4:36         ` Dave Chinner
2022-05-18  0:10           ` Eric Sandeen
2022-05-20  1:58           ` Darrick J. Wong
2022-05-18  2:23         ` Zorro Lang
2022-05-16  8:59 ` [PATCH 2/4] xfs/148: make test debuggable Dave Chinner
2022-05-16  8:59 ` [PATCH 3/4] xfs/148: fix failure from bad shortform size assumptions Dave Chinner
2022-05-16 15:37   ` Darrick J. Wong
2022-05-16 21:40     ` Dave Chinner
2022-05-16  8:59 ` [PATCH 4/4] generic/081: don't run on DAX capable devices Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220516085922.1306879-2-david@fromorbit.com \
    --to=david@fromorbit.com \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.