From: Martin Kepplinger <martin.kepplinger@puri.sm> To: ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, mchehab@kernel.org Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kepplinger <martin.kepplinger@puri.sm> Subject: [PATCH] media: hantro: fix compatible string deprecation warning Date: Tue, 17 May 2022 16:35:21 +0200 [thread overview] Message-ID: <20220517143521.1670663-1-martin.kepplinger@puri.sm> (raw) of_device_is_compatible() in the end uses strlen of the string for comparison, so in this case, the condition is true even if the requested string "nxp,imx8mq-vpu-g1" is being used. The first chars containing "nxp,imx8mq-vpu" are the same. Fix this by encoding what the comment says. Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> --- This is more of a bugreport as the solution doesn't look very elegant to me. I'm happy for advice. thanks, martin drivers/staging/media/hantro/hantro_drv.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/hantro/hantro_drv.c b/drivers/staging/media/hantro/hantro_drv.c index ac232b5f7825..014fab637df0 100644 --- a/drivers/staging/media/hantro/hantro_drv.c +++ b/drivers/staging/media/hantro/hantro_drv.c @@ -923,10 +923,11 @@ static int hantro_probe(struct platform_device *pdev) /* * Support for nxp,imx8mq-vpu is kept for backwards compatibility - * but it's deprecated. Please update your DTS file to use - * nxp,imx8mq-vpu-g1 or nxp,imx8mq-vpu-g2 instead. + * but it's deprecated. */ - if (of_device_is_compatible(pdev->dev.of_node, "nxp,imx8mq-vpu")) + if ((of_device_is_compatible(pdev->dev.of_node, "nxp,imx8mq-vpu")) && + (!of_device_is_compatible(pdev->dev.of_node, "nxp,imx8mq-vpu-g1")) && + (!of_device_is_compatible(pdev->dev.of_node, "nxp,imx8mq-vpu-g2"))) dev_warn(&pdev->dev, "%s compatible is deprecated\n", match->compatible); -- 2.30.2
WARNING: multiple messages have this Message-ID (diff)
From: Martin Kepplinger <martin.kepplinger@puri.sm> To: ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, mchehab@kernel.org Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kepplinger <martin.kepplinger@puri.sm> Subject: [PATCH] media: hantro: fix compatible string deprecation warning Date: Tue, 17 May 2022 16:35:21 +0200 [thread overview] Message-ID: <20220517143521.1670663-1-martin.kepplinger@puri.sm> (raw) of_device_is_compatible() in the end uses strlen of the string for comparison, so in this case, the condition is true even if the requested string "nxp,imx8mq-vpu-g1" is being used. The first chars containing "nxp,imx8mq-vpu" are the same. Fix this by encoding what the comment says. Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> --- This is more of a bugreport as the solution doesn't look very elegant to me. I'm happy for advice. thanks, martin drivers/staging/media/hantro/hantro_drv.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/hantro/hantro_drv.c b/drivers/staging/media/hantro/hantro_drv.c index ac232b5f7825..014fab637df0 100644 --- a/drivers/staging/media/hantro/hantro_drv.c +++ b/drivers/staging/media/hantro/hantro_drv.c @@ -923,10 +923,11 @@ static int hantro_probe(struct platform_device *pdev) /* * Support for nxp,imx8mq-vpu is kept for backwards compatibility - * but it's deprecated. Please update your DTS file to use - * nxp,imx8mq-vpu-g1 or nxp,imx8mq-vpu-g2 instead. + * but it's deprecated. */ - if (of_device_is_compatible(pdev->dev.of_node, "nxp,imx8mq-vpu")) + if ((of_device_is_compatible(pdev->dev.of_node, "nxp,imx8mq-vpu")) && + (!of_device_is_compatible(pdev->dev.of_node, "nxp,imx8mq-vpu-g1")) && + (!of_device_is_compatible(pdev->dev.of_node, "nxp,imx8mq-vpu-g2"))) dev_warn(&pdev->dev, "%s compatible is deprecated\n", match->compatible); -- 2.30.2 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip
next reply other threads:[~2022-05-17 14:46 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-17 14:35 Martin Kepplinger [this message] 2022-05-17 14:35 ` [PATCH] media: hantro: fix compatible string deprecation warning Martin Kepplinger 2022-05-17 16:46 ` Robin Murphy 2022-05-17 16:46 ` Robin Murphy 2022-06-09 8:47 ` Hans Verkuil 2022-06-09 8:47 ` Hans Verkuil
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220517143521.1670663-1-martin.kepplinger@puri.sm \ --to=martin.kepplinger@puri.sm \ --cc=ezequiel@vanguardiasur.com.ar \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=linux-staging@lists.linux.dev \ --cc=mchehab@kernel.org \ --cc=p.zabel@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.