All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Alexander Aring <alex.aring@gmail.com>,
	Stefan Schmidt <stefan@datenfreihafen.org>,
	linux-wpan@vger.kernel.org
Cc: David Girault <david.girault@qorvo.com>,
	Romuald Despres <romuald.despres@qorvo.com>,
	Frederic Blain <frederic.blain@qorvo.com>,
	Nicolas Schodet <nico@ni.fr.eu.org>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, Miquel Raynal <miquel.raynal@bootlin.com>
Subject: [PATCH wpan-next v3 09/11] net: mac802154: Introduce a synchronous API for MLME commands
Date: Tue, 17 May 2022 18:34:48 +0200	[thread overview]
Message-ID: <20220517163450.240299-10-miquel.raynal@bootlin.com> (raw)
In-Reply-To: <20220517163450.240299-1-miquel.raynal@bootlin.com>

This is the slow path, we need to wait for each command to be processed
before continuing so let's introduce an helper which does the
transmission and blocks until it gets notified of its asynchronous
completion. This helper is going to be used when introducing scan
support.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
 net/mac802154/ieee802154_i.h |  1 +
 net/mac802154/tx.c           | 46 ++++++++++++++++++++++++++++++++++++
 2 files changed, 47 insertions(+)

diff --git a/net/mac802154/ieee802154_i.h b/net/mac802154/ieee802154_i.h
index a057827fc48a..b42c6ac789f5 100644
--- a/net/mac802154/ieee802154_i.h
+++ b/net/mac802154/ieee802154_i.h
@@ -125,6 +125,7 @@ extern struct ieee802154_mlme_ops mac802154_mlme_wpan;
 void ieee802154_rx(struct ieee802154_local *local, struct sk_buff *skb);
 void ieee802154_xmit_sync_worker(struct work_struct *work);
 int ieee802154_sync_and_hold_queue(struct ieee802154_local *local);
+int ieee802154_mlme_tx_one(struct ieee802154_local *local, struct sk_buff *skb);
 netdev_tx_t
 ieee802154_monitor_start_xmit(struct sk_buff *skb, struct net_device *dev);
 netdev_tx_t
diff --git a/net/mac802154/tx.c b/net/mac802154/tx.c
index 38f74b8b6740..6cc4e5c7ba94 100644
--- a/net/mac802154/tx.c
+++ b/net/mac802154/tx.c
@@ -128,6 +128,52 @@ int ieee802154_sync_and_hold_queue(struct ieee802154_local *local)
 	return ieee802154_sync_queue(local);
 }
 
+static int ieee802154_mlme_op_pre(struct ieee802154_local *local)
+{
+	return ieee802154_sync_and_hold_queue(local);
+}
+
+static int ieee802154_mlme_tx(struct ieee802154_local *local, struct sk_buff *skb)
+{
+	int ret;
+
+	/* Avoid possible calls to ->ndo_stop() when we asynchronously perform
+	 * MLME transmissions.
+	 */
+	rtnl_lock();
+
+	/* Ensure the device was not stopped, otherwise error out */
+	if (!local->open_count)
+		return -EBUSY;
+
+	ieee802154_tx(local, skb);
+	ret = ieee802154_sync_queue(local);
+
+	rtnl_unlock();
+
+	return ret;
+}
+
+static void ieee802154_mlme_op_post(struct ieee802154_local *local)
+{
+	ieee802154_release_queue(local);
+}
+
+int ieee802154_mlme_tx_one(struct ieee802154_local *local, struct sk_buff *skb)
+{
+	int ret;
+
+	ret = ieee802154_mlme_op_pre(local);
+	if (ret)
+		return ret;
+
+	ret = ieee802154_mlme_tx(local, skb);
+
+	ieee802154_mlme_op_post(local);
+
+	return ret;
+}
+
 static netdev_tx_t
 ieee802154_hot_tx(struct ieee802154_local *local, struct sk_buff *skb)
 {
-- 
2.34.1


  parent reply	other threads:[~2022-05-17 16:35 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-17 16:34 [PATCH wpan-next v3 00/11] ieee802154: Synchronous Tx support Miquel Raynal
2022-05-17 16:34 ` [PATCH wpan-next v3 01/11] net: mac802154: Rename the synchronous xmit worker Miquel Raynal
2022-05-17 16:34 ` [PATCH wpan-next v3 02/11] net: mac802154: Rename the main tx_work struct Miquel Raynal
2022-05-17 16:34 ` [PATCH wpan-next v3 03/11] net: mac802154: Enhance the error path in the main tx helper Miquel Raynal
2022-05-17 16:34 ` [PATCH wpan-next v3 04/11] net: mac802154: Follow the count of ongoing transmissions Miquel Raynal
2022-05-17 16:34 ` [PATCH wpan-next v3 05/11] net: mac802154: Bring the ability to hold the transmit queue Miquel Raynal
2022-05-18  0:37   ` Alexander Aring
2022-05-18  8:26     ` Miquel Raynal
2022-05-17 16:34 ` [PATCH wpan-next v3 06/11] net: mac802154: Create a hot tx path Miquel Raynal
2022-05-17 16:34 ` [PATCH wpan-next v3 07/11] net: mac802154: Introduce a helper to disable the queue Miquel Raynal
2022-05-17 16:34 ` [PATCH wpan-next v3 08/11] net: mac802154: Introduce a tx queue flushing mechanism Miquel Raynal
2022-05-17 16:34 ` Miquel Raynal [this message]
2022-05-18  0:41   ` [PATCH wpan-next v3 09/11] net: mac802154: Introduce a synchronous API for MLME commands Alexander Aring
2022-05-18  8:44     ` Miquel Raynal
2022-05-18 11:59       ` Alexander Aring
2022-05-18 12:12         ` Alexander Aring
2022-05-18 12:44         ` Miquel Raynal
2022-05-18 13:02           ` Alexander Aring
2022-05-17 16:34 ` [PATCH wpan-next v3 10/11] net: mac802154: Add a warning in the hot path Miquel Raynal
2022-05-18  0:58   ` Alexander Aring
2022-05-18  8:55     ` Miquel Raynal
2022-05-18 14:31       ` Alexander Aring
2022-05-18 16:29         ` Miquel Raynal
2022-05-19  1:52           ` Alexander Aring
2022-05-17 16:34 ` [PATCH wpan-next v3 11/11] net: mac802154: Add a warning in the slow path Miquel Raynal
2022-05-18  0:52   ` Alexander Aring
2022-05-18  9:37     ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220517163450.240299-10-miquel.raynal@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=alex.aring@gmail.com \
    --cc=davem@davemloft.net \
    --cc=david.girault@qorvo.com \
    --cc=frederic.blain@qorvo.com \
    --cc=kuba@kernel.org \
    --cc=linux-wpan@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nico@ni.fr.eu.org \
    --cc=pabeni@redhat.com \
    --cc=romuald.despres@qorvo.com \
    --cc=stefan@datenfreihafen.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.