All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Larumbe <adrian.larumbe@collabora.com>
To: daniel@ffwll.ch, intel-gfx@lists.freedesktop.org
Cc: adrian.larumbe@collabora.com
Subject: [Intel-gfx] [RFC PATCH v2 0/1] Replace shmem memory region and object backend
Date: Tue, 17 May 2022 21:45:12 +0100	[thread overview]
Message-ID: <20220517204513.429930-1-adrian.larumbe@collabora.com> (raw)

This patch is a second attempt at eliminating the old shmem memory region
and GEM object backend, in favour of a TTM-based one that is able to manage
objects placed on both system and local memory.

Questions addressed since previous revision:

* Creating an anonymous vfs mount for shmem files in TTM
* Fixing LLC caching properties and bit 17 swizzling before setting a TTM
bo's pages when calling get_pages
* Added handling of phys backend from TTM functions
* Added pread callback to TTM gem object backend
* In shmem_create_from_object, ensuring an shmem object we just got a filp
for has its pages marked dirty and accessed. Otherwise, the engine won't be
able to read the initial state and a GPU hung will ensue

However, one of the issues persists:

Many GPU hungs in machines of GEN <= 5. My assumption is this has something
 to do with a caching pitfall, but everywhere across the TTM backend code
 I've tried to handle object creation and getting its pages with the same
 set of caching and coherency properties as in the old shmem backend.

Adrian Larumbe (1):
  drm/i915: Replace shmem memory region and object backend with TTM

 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c   |  12 +-
 drivers/gpu/drm/i915/gem/i915_gem_mman.c     |  32 +-
 drivers/gpu/drm/i915/gem/i915_gem_object.h   |   4 +-
 drivers/gpu/drm/i915/gem/i915_gem_phys.c     |  32 +-
 drivers/gpu/drm/i915/gem/i915_gem_shmem.c    | 390 +------------------
 drivers/gpu/drm/i915/gem/i915_gem_ttm.c      | 267 ++++++++++++-
 drivers/gpu/drm/i915/gem/i915_gem_ttm.h      |   3 +
 drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c |   9 +-
 drivers/gpu/drm/i915/gt/shmem_utils.c        |  64 ++-
 drivers/gpu/drm/i915/intel_memory_region.c   |   7 +-
 10 files changed, 398 insertions(+), 422 deletions(-)

-- 
2.35.1


             reply	other threads:[~2022-05-17 20:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-17 20:45 Adrian Larumbe [this message]
2022-05-17 20:45 ` [Intel-gfx] [RFC PATCH v2 1/1] drm/i915: Replace shmem memory region and object backend with TTM Adrian Larumbe
2022-05-17 21:39   ` Ruhl, Michael J
2022-05-27 16:08     ` Adrian Larumbe
2022-06-01 19:43       ` Ruhl, Michael J
2022-06-06 20:19         ` Adrian Larumbe
2022-06-15 12:18           ` Ruhl, Michael J
2022-05-17 21:51 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Replace shmem memory region and object backend Patchwork
2022-05-17 21:51 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-05-17 22:14 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-05-18 15:00 ` [Intel-gfx] [RFC PATCH v2 0/1] " Matthew Auld
2022-05-27 15:37   ` Adrian Larumbe
2022-05-30 18:58     ` Matthew Auld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220517204513.429930-1-adrian.larumbe@collabora.com \
    --to=adrian.larumbe@collabora.com \
    --cc=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.