From: "Michal Koutný" <mkoutny@suse.com> To: cgroups@vger.kernel.org, linux-mm@kvack.org Cc: Johannes Weiner <hannes@cmpxchg.org>, Michal Hocko <mhocko@kernel.org>, Roman Gushchin <roman.gushchin@linux.dev>, Shakeel Butt <shakeelb@google.com>, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Richard Palethorpe <rpalethorpe@suse.de> Subject: [PATCH v2 2/5] selftests: memcg: Expect no low events in unprotected sibling Date: Wed, 18 May 2022 18:18:56 +0200 [thread overview] Message-ID: <20220518161859.21565-3-mkoutny@suse.com> (raw) In-Reply-To: <20220518161859.21565-1-mkoutny@suse.com> This is effectively a revert of commit cdc69458a5f3 ("cgroup: account for memory_recursiveprot in test_memcg_low()"). The case test_memcg_low will fail with memory_recursiveprot until resolved in reclaim code. However, this patch preserves the existing helpers and variables for later uses. Signed-off-by: Michal Koutný <mkoutny@suse.com> Reviewed-by: David Vernet <void@manifault.com> --- tools/testing/selftests/cgroup/test_memcontrol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/cgroup/test_memcontrol.c b/tools/testing/selftests/cgroup/test_memcontrol.c index c012db9d07d6..4924425639b0 100644 --- a/tools/testing/selftests/cgroup/test_memcontrol.c +++ b/tools/testing/selftests/cgroup/test_memcontrol.c @@ -528,7 +528,7 @@ static int test_memcg_low(const char *root) } for (i = 0; i < ARRAY_SIZE(children); i++) { - int no_low_events_index = has_recursiveprot ? 2 : 1; + int no_low_events_index = 1; oom = cg_read_key_long(children[i], "memory.events", "oom "); low = cg_read_key_long(children[i], "memory.events", "low "); -- 2.35.3
WARNING: multiple messages have this Message-ID (diff)
From: "Michal Koutný" <mkoutny-IBi9RG/b67k@public.gmane.org> To: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org Cc: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>, Michal Hocko <mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Roman Gushchin <roman.gushchin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org>, Shakeel Butt <shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kselftest-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Richard Palethorpe <rpalethorpe-l3A5Bk7waGM@public.gmane.org> Subject: [PATCH v2 2/5] selftests: memcg: Expect no low events in unprotected sibling Date: Wed, 18 May 2022 18:18:56 +0200 [thread overview] Message-ID: <20220518161859.21565-3-mkoutny@suse.com> (raw) In-Reply-To: <20220518161859.21565-1-mkoutny-IBi9RG/b67k@public.gmane.org> This is effectively a revert of commit cdc69458a5f3 ("cgroup: account for memory_recursiveprot in test_memcg_low()"). The case test_memcg_low will fail with memory_recursiveprot until resolved in reclaim code. However, this patch preserves the existing helpers and variables for later uses. Signed-off-by: Michal Koutn√Ω <mkoutny-IBi9RG/b67k@public.gmane.org> Reviewed-by: David Vernet <void-gq6j2QGBifHby3iVrkZq2A@public.gmane.org> --- tools/testing/selftests/cgroup/test_memcontrol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/cgroup/test_memcontrol.c b/tools/testing/selftests/cgroup/test_memcontrol.c index c012db9d07d6..4924425639b0 100644 --- a/tools/testing/selftests/cgroup/test_memcontrol.c +++ b/tools/testing/selftests/cgroup/test_memcontrol.c @@ -528,7 +528,7 @@ static int test_memcg_low(const char *root) } for (i = 0; i < ARRAY_SIZE(children); i++) { - int no_low_events_index = has_recursiveprot ? 2 : 1; + int no_low_events_index = 1; oom = cg_read_key_long(children[i], "memory.events", "oom "); low = cg_read_key_long(children[i], "memory.events", "low "); -- 2.35.3
next prev parent reply other threads:[~2022-05-18 16:19 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-18 16:18 Michal Koutný 2022-05-18 16:18 ` [PATCH v2 1/5] selftests: memcg: Fix compilation Michal Koutný 2022-05-18 16:18 ` Michal Koutný 2022-05-21 14:11 ` Muhammad Usama Anjum 2022-05-21 14:11 ` Muhammad Usama Anjum 2022-05-23 13:29 ` Michal Koutný 2022-05-23 13:29 ` Michal Koutný 2022-05-18 16:18 ` Michal Koutný [this message] 2022-05-18 16:18 ` [PATCH v2 2/5] selftests: memcg: Expect no low events in unprotected sibling Michal Koutný 2022-05-18 16:18 ` [PATCH v2 3/5] selftests: memcg: Adjust expected reclaim values of protected cgroups Michal Koutný 2022-05-18 16:18 ` Michal Koutný 2022-05-18 19:10 ` Roman Gushchin 2022-05-18 19:10 ` Roman Gushchin 2022-05-18 16:18 ` [PATCH v2 4/5] selftests: memcg: Remove protection from top level memcg Michal Koutný 2022-05-18 16:18 ` Michal Koutný 2022-05-18 19:10 ` Roman Gushchin 2022-05-18 19:10 ` Roman Gushchin 2022-05-18 16:18 ` [PATCH v2 5/5] selftests: memcg: Factor out common parts of memory.{low,min} tests Michal Koutný 2022-05-18 16:18 ` Michal Koutný
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220518161859.21565-3-mkoutny@suse.com \ --to=mkoutny@suse.com \ --cc=cgroups@vger.kernel.org \ --cc=hannes@cmpxchg.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-kselftest@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mhocko@kernel.org \ --cc=roman.gushchin@linux.dev \ --cc=rpalethorpe@suse.de \ --cc=shakeelb@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.