From: Conor Dooley <conor.dooley@microchip.com> To: <a.zummo@towertech.it>, <alexandre.belloni@bootlin.com> Cc: <daire.mcnamara@microchip.com>, <lewis.hanly@microchip.com>, <conor.dooley@microchip.com>, <linux-kernel@vger.kernel.org>, <linux-rtc@vger.kernel.org>, <linux-riscv@lists.infradead.org> Subject: [PATCH v4 0/2] rtc: microchip: Add driver for PolarFire SoC Date: Thu, 19 May 2022 14:55:21 +0100 [thread overview] Message-ID: <20220519135523.594347-1-conor.dooley@microchip.com> (raw) Hey all, This is technically a v4 of [0], although a fair bit of time has passed since then. In the meantime I upstreamed the dt-binding, which was in the v1, and this patch depends on the fixes to the dt-binding and device tree etc which landed in v5.18-rc5. The driver is quite substantially rewritten from the v1, as you wanted it to be switched to "binary" rather than calendar mode - so hopefully I have satisfied your concerns with the original driver. Specifically you had an significant issue with the counter being reset on startup & that is no longer the case. Thanks, Conor. Changes since v3: - invert read order of datetime registers so that they are properly aligned. reads of the upper register are aligned to the last read of the lower register - move wakeup_irq out of mpfs_rtc_dev & into probe - removed range_min since it is not set & implicity zero anyway - rewrote the remove function to not call mpfs_rtc_alarm_irq_enable(,0) Changes from v2: - move prescaler out of mpfs_rtc_dev & into probe Changes from v1: - remove duplicate and unused defines - remove oneline mpfs_rtc_set_prescaler function - dont unconditionally turn off the rtc in the init function - dont reset the rtc when init is run. - dont disable the alarm when we boot - use binary, not calendar mode - delete mpfs_rtc_init & set prescale in probe - use dev_pm_set_wake_irq rather than writing suspend/resume functions - delete calendar mode only register defines - since using binary mode, set range min to zero - set range max to max alarm value (is this acceptable?) - added a MAINTAINERS entry: when v1 was submitted there was nothing to add to, but there is now. [0] https://lore.kernel.org/linux-rtc/20210512111133.1650740-1-daire.mcnamara@microchip.com/ Conor Dooley (2): rtc: Add driver for Microchip PolarFire SoC MAINTAINERS: add PolarFire SoC's RTC MAINTAINERS | 1 + drivers/rtc/Kconfig | 10 ++ drivers/rtc/Makefile | 1 + drivers/rtc/rtc-mpfs.c | 326 +++++++++++++++++++++++++++++++++++++++++ 4 files changed, 338 insertions(+) create mode 100644 drivers/rtc/rtc-mpfs.c base-commit: c5eb0a61238dd6faf37f58c9ce61c9980aaffd7a -- 2.36.1
WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor.dooley@microchip.com> To: <a.zummo@towertech.it>, <alexandre.belloni@bootlin.com> Cc: <daire.mcnamara@microchip.com>, <lewis.hanly@microchip.com>, <conor.dooley@microchip.com>, <linux-kernel@vger.kernel.org>, <linux-rtc@vger.kernel.org>, <linux-riscv@lists.infradead.org> Subject: [PATCH v4 0/2] rtc: microchip: Add driver for PolarFire SoC Date: Thu, 19 May 2022 14:55:21 +0100 [thread overview] Message-ID: <20220519135523.594347-1-conor.dooley@microchip.com> (raw) Hey all, This is technically a v4 of [0], although a fair bit of time has passed since then. In the meantime I upstreamed the dt-binding, which was in the v1, and this patch depends on the fixes to the dt-binding and device tree etc which landed in v5.18-rc5. The driver is quite substantially rewritten from the v1, as you wanted it to be switched to "binary" rather than calendar mode - so hopefully I have satisfied your concerns with the original driver. Specifically you had an significant issue with the counter being reset on startup & that is no longer the case. Thanks, Conor. Changes since v3: - invert read order of datetime registers so that they are properly aligned. reads of the upper register are aligned to the last read of the lower register - move wakeup_irq out of mpfs_rtc_dev & into probe - removed range_min since it is not set & implicity zero anyway - rewrote the remove function to not call mpfs_rtc_alarm_irq_enable(,0) Changes from v2: - move prescaler out of mpfs_rtc_dev & into probe Changes from v1: - remove duplicate and unused defines - remove oneline mpfs_rtc_set_prescaler function - dont unconditionally turn off the rtc in the init function - dont reset the rtc when init is run. - dont disable the alarm when we boot - use binary, not calendar mode - delete mpfs_rtc_init & set prescale in probe - use dev_pm_set_wake_irq rather than writing suspend/resume functions - delete calendar mode only register defines - since using binary mode, set range min to zero - set range max to max alarm value (is this acceptable?) - added a MAINTAINERS entry: when v1 was submitted there was nothing to add to, but there is now. [0] https://lore.kernel.org/linux-rtc/20210512111133.1650740-1-daire.mcnamara@microchip.com/ Conor Dooley (2): rtc: Add driver for Microchip PolarFire SoC MAINTAINERS: add PolarFire SoC's RTC MAINTAINERS | 1 + drivers/rtc/Kconfig | 10 ++ drivers/rtc/Makefile | 1 + drivers/rtc/rtc-mpfs.c | 326 +++++++++++++++++++++++++++++++++++++++++ 4 files changed, 338 insertions(+) create mode 100644 drivers/rtc/rtc-mpfs.c base-commit: c5eb0a61238dd6faf37f58c9ce61c9980aaffd7a -- 2.36.1 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next reply other threads:[~2022-05-19 13:57 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-19 13:55 Conor Dooley [this message] 2022-05-19 13:55 ` [PATCH v4 0/2] rtc: microchip: Add driver for PolarFire SoC Conor Dooley 2022-05-19 13:55 ` [PATCH v4 1/2] rtc: Add driver for Microchip " Conor Dooley 2022-05-19 13:55 ` Conor Dooley 2022-05-19 13:55 ` [PATCH v4 2/2] MAINTAINERS: add PolarFire SoC's RTC Conor Dooley 2022-05-19 13:55 ` Conor Dooley
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220519135523.594347-1-conor.dooley@microchip.com \ --to=conor.dooley@microchip.com \ --cc=a.zummo@towertech.it \ --cc=alexandre.belloni@bootlin.com \ --cc=daire.mcnamara@microchip.com \ --cc=lewis.hanly@microchip.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=linux-rtc@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.