All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frederic Konrad via <qemu-devel@nongnu.org>
To: <qemu-devel@nongnu.org>
Cc: <qemu-arm@nongnu.org>, <peter.maydell@linaro.org>,
	<edgar.iglesias@gmail.com>, <alistair@alistair23.me>,
	<saipava@xilinx.com>, <edgari@xilinx.com>, <fkonrad@amd.com>,
	Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>,
	"Edgar E . Iglesias" <edgar.iglesias@xilinx.com>
Subject: [PATCH v2 3/4] xlnx_dp: Fix the interrupt disable logic
Date: Thu, 19 May 2022 16:38:28 +0100	[thread overview]
Message-ID: <20220519153829.356889-4-fkonrad@amd.com> (raw)
In-Reply-To: <20220519153829.356889-1-fkonrad@amd.com>

From: Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>

Fix interrupt disable logic. Mask value 1 indicates that interrupts are
disabled.

Signed-off-by: Sai Pavan Boddu <saipava@xilinx.com>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Signed-off-by: Frederic Konrad <fkonrad@amd.com>
---
 hw/display/xlnx_dp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/display/xlnx_dp.c b/hw/display/xlnx_dp.c
index 2686ca0f2e..48c0a8a661 100644
--- a/hw/display/xlnx_dp.c
+++ b/hw/display/xlnx_dp.c
@@ -888,7 +888,7 @@ static void xlnx_dp_write(void *opaque, hwaddr offset, uint64_t value,
         xlnx_dp_update_irq(s);
         break;
     case DP_INT_DS:
-        s->core_registers[DP_INT_MASK] |= ~value;
+        s->core_registers[DP_INT_MASK] |= value;
         xlnx_dp_update_irq(s);
         break;
     default:
-- 
2.25.1



  parent reply	other threads:[~2022-05-19 15:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-19 15:38 [PATCH v2 0/4] xlnx-zcu102: fix the display port Frederic Konrad via
2022-05-19 15:38 ` [PATCH v2 1/4] xlnx_dp: fix the wrong register size Frederic Konrad via
2022-05-19 15:38 ` [PATCH v2 2/4] xlnx_dp: Introduce a vblank signal Frederic Konrad via
2022-05-23 13:51   ` Peter Maydell
2022-05-24  8:30     ` Frederic Konrad
2022-05-19 15:38 ` Frederic Konrad via [this message]
2022-05-19 15:38 ` [PATCH v2 4/4] xlnx-zynqmp: fix the irq mapping for the display port and its dma Frederic Konrad via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220519153829.356889-4-fkonrad@amd.com \
    --to=qemu-devel@nongnu.org \
    --cc=alistair@alistair23.me \
    --cc=edgar.iglesias@gmail.com \
    --cc=edgar.iglesias@xilinx.com \
    --cc=edgari@xilinx.com \
    --cc=fkonrad@amd.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=sai.pavan.boddu@xilinx.com \
    --cc=saipava@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.