All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PULL 08/22] hw/intc/arm_gicv3: report correct PRIbits field in ICV_CTLR_EL1
Date: Thu, 19 May 2022 18:36:37 +0100	[thread overview]
Message-ID: <20220519173651.399295-9-peter.maydell@linaro.org> (raw)
In-Reply-To: <20220519173651.399295-1-peter.maydell@linaro.org>

As noted in the comment, the PRIbits field in ICV_CTLR_EL1 is
supposed to match the ICH_VTR_EL2 PRIbits setting; that is, it is the
virtual priority bit setting, not the physical priority bit setting.
(For QEMU currently we always implement 8 bits of physical priority,
so the PRIbits field was previously 7, since it is defined to be
"priority bits - 1".)

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20220512151457.3899052-3-peter.maydell@linaro.org
Message-id: 20220506162129.2896966-2-peter.maydell@linaro.org
---
 hw/intc/arm_gicv3_cpuif.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/intc/arm_gicv3_cpuif.c b/hw/intc/arm_gicv3_cpuif.c
index df2f8583564..ebf269b73a4 100644
--- a/hw/intc/arm_gicv3_cpuif.c
+++ b/hw/intc/arm_gicv3_cpuif.c
@@ -657,7 +657,7 @@ static uint64_t icv_ctlr_read(CPUARMState *env, const ARMCPRegInfo *ri)
      * should match the ones reported in ich_vtr_read().
      */
     value = ICC_CTLR_EL1_A3V | (1 << ICC_CTLR_EL1_IDBITS_SHIFT) |
-        (7 << ICC_CTLR_EL1_PRIBITS_SHIFT);
+        ((cs->vpribits - 1) << ICC_CTLR_EL1_PRIBITS_SHIFT);
 
     if (cs->ich_vmcr_el2 & ICH_VMCR_EL2_VEOIM) {
         value |= ICC_CTLR_EL1_EOIMODE;
-- 
2.25.1



  parent reply	other threads:[~2022-05-19 17:52 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-19 17:36 [PULL 00/22] target-arm queue Peter Maydell
2022-05-19 17:36 ` [PULL 01/22] target/arm: Postpone interpretation of stage 2 descriptor attribute bits Peter Maydell
2022-05-19 17:36 ` [PULL 02/22] target/arm: Factor out FWB=0 specific part of combine_cacheattrs() Peter Maydell
2022-05-19 17:36 ` [PULL 03/22] target/arm: Implement FEAT_S2FWB Peter Maydell
2022-05-19 17:36 ` [PULL 04/22] target/arm: Enable FEAT_S2FWB for -cpu max Peter Maydell
2022-05-19 17:36 ` [PULL 05/22] target/arm: Implement FEAT_IDST Peter Maydell
2022-05-19 17:36 ` [PULL 06/22] target/arm: Drop unsupported_encoding() macro Peter Maydell
2022-05-19 17:36 ` [PULL 07/22] hw/intc/arm_gicv3_cpuif: Handle CPUs that don't specify GICv3 parameters Peter Maydell
2022-05-19 17:36 ` Peter Maydell [this message]
2022-05-19 17:36 ` [PULL 09/22] hw/intc/arm_gicv3_kvm.c: Stop using GIC_MIN_BPR constant Peter Maydell
2022-05-19 17:36 ` [PULL 10/22] hw/intc/arm_gicv3: Support configurable number of physical priority bits Peter Maydell
2022-05-19 17:36 ` [PULL 11/22] hw/intc/arm_gicv3: Use correct number of priority bits for the CPU Peter Maydell
2022-05-19 17:36 ` [PULL 12/22] hw/intc/arm_gicv3: Provide ich_num_aprs() Peter Maydell
2022-05-19 17:36 ` [PULL 13/22] Fix aarch64 debug register names Peter Maydell
2022-05-19 17:36 ` [PULL 14/22] hw/adc/zynq-xadc: Use qemu_irq typedef Peter Maydell
2022-05-19 17:36 ` [PULL 15/22] target/arm/helper.c: Delete stray obsolete comment Peter Maydell
2022-05-19 17:36 ` [PULL 16/22] target/arm: Make number of counters in PMCR follow the CPU Peter Maydell
2022-05-19 17:36 ` [PULL 17/22] hw/arm/virt: Fix incorrect non-secure flash dtb node name Peter Maydell
2022-05-19 17:36 ` [PULL 18/22] hw/arm/virt: Drop #size-cells and #address-cells from gpio-keys dtb node Peter Maydell
2022-05-19 17:36 ` [PULL 19/22] ptimer: Rename PTIMER_POLICY_DEFAULT to PTIMER_POLICY_LEGACY Peter Maydell
2022-05-19 17:36 ` [PULL 20/22] target/arm: Fix PAuth keys access checks for disabled SEL2 Peter Maydell
2022-05-19 17:36 ` [PULL 21/22] target/arm: Enable FEAT_HCX for -cpu max Peter Maydell
2022-05-19 17:36 ` [PULL 22/22] target/arm: Use FIELD definitions for CPACR, CPTR_ELx Peter Maydell
2022-05-19 20:29 ` [PULL 00/22] target-arm queue Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220519173651.399295-9-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.