From: Juerg Haefliger <juerg.haefliger@canonical.com> To: paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Juerg Haefliger <juergh@canonical.com> Subject: [PATCH 1/3] riscv: Kconfig: Fix indentation and add comments Date: Fri, 20 May 2022 14:02:30 +0200 [thread overview] Message-ID: <20220520120232.148310-2-juergh@canonical.com> (raw) In-Reply-To: <20220520120232.148310-1-juergh@canonical.com> The convention for indentation seems to be a single tab. Help text is further indented by an additional two whitespaces. Fix the lines that violate these rules. While add it, add trailing comments to endmenu statements for better readability. Signed-off-by: Juerg Haefliger <juergh@canonical.com> --- arch/riscv/Kconfig | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig index 00fd9c548f26..4507847d7c9c 100644 --- a/arch/riscv/Kconfig +++ b/arch/riscv/Kconfig @@ -328,11 +328,11 @@ config RISCV_ISA_C bool "Emit compressed instructions when building Linux" default y help - Adds "C" to the ISA subsets that the toolchain is allowed to emit - when building Linux, which results in compressed instructions in the - Linux binary. + Adds "C" to the ISA subsets that the toolchain is allowed to emit + when building Linux, which results in compressed instructions in the + Linux binary. - If you don't know what to do here, say Y. + If you don't know what to do here, say Y. config FPU bool "FPU support" @@ -343,7 +343,7 @@ config FPU If you don't know what to do here, say Y. -endmenu +endmenu # "Platform type" menu "Kernel features" @@ -394,7 +394,7 @@ config CRASH_DUMP For more details see Documentation/admin-guide/kdump/kdump.rst -endmenu +endmenu # "Kernel features" menu "Boot options" @@ -430,7 +430,6 @@ config CMDLINE_EXTEND cases where the provided arguments are insufficient and you don't want to or cannot modify them. - config CMDLINE_FORCE bool "Always use the default kernel command string" help @@ -522,7 +521,7 @@ config XIP_PHYS_ADDR be linked for and stored to. This address is dependent on your own flash usage. -endmenu +endmenu # "Boot options" config BUILTIN_DTB bool @@ -533,12 +532,12 @@ menu "Power management options" source "kernel/power/Kconfig" -endmenu +endmenu # "Power management options" menu "CPU Power Management" source "drivers/cpuidle/Kconfig" -endmenu +endmenu # "CPU Power Management" source "arch/riscv/kvm/Kconfig" -- 2.32.0
WARNING: multiple messages have this Message-ID (diff)
From: Juerg Haefliger <juerg.haefliger@canonical.com> To: paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Juerg Haefliger <juergh@canonical.com> Subject: [PATCH 1/3] riscv: Kconfig: Fix indentation and add comments Date: Fri, 20 May 2022 14:02:30 +0200 [thread overview] Message-ID: <20220520120232.148310-2-juergh@canonical.com> (raw) In-Reply-To: <20220520120232.148310-1-juergh@canonical.com> The convention for indentation seems to be a single tab. Help text is further indented by an additional two whitespaces. Fix the lines that violate these rules. While add it, add trailing comments to endmenu statements for better readability. Signed-off-by: Juerg Haefliger <juergh@canonical.com> --- arch/riscv/Kconfig | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig index 00fd9c548f26..4507847d7c9c 100644 --- a/arch/riscv/Kconfig +++ b/arch/riscv/Kconfig @@ -328,11 +328,11 @@ config RISCV_ISA_C bool "Emit compressed instructions when building Linux" default y help - Adds "C" to the ISA subsets that the toolchain is allowed to emit - when building Linux, which results in compressed instructions in the - Linux binary. + Adds "C" to the ISA subsets that the toolchain is allowed to emit + when building Linux, which results in compressed instructions in the + Linux binary. - If you don't know what to do here, say Y. + If you don't know what to do here, say Y. config FPU bool "FPU support" @@ -343,7 +343,7 @@ config FPU If you don't know what to do here, say Y. -endmenu +endmenu # "Platform type" menu "Kernel features" @@ -394,7 +394,7 @@ config CRASH_DUMP For more details see Documentation/admin-guide/kdump/kdump.rst -endmenu +endmenu # "Kernel features" menu "Boot options" @@ -430,7 +430,6 @@ config CMDLINE_EXTEND cases where the provided arguments are insufficient and you don't want to or cannot modify them. - config CMDLINE_FORCE bool "Always use the default kernel command string" help @@ -522,7 +521,7 @@ config XIP_PHYS_ADDR be linked for and stored to. This address is dependent on your own flash usage. -endmenu +endmenu # "Boot options" config BUILTIN_DTB bool @@ -533,12 +532,12 @@ menu "Power management options" source "kernel/power/Kconfig" -endmenu +endmenu # "Power management options" menu "CPU Power Management" source "drivers/cpuidle/Kconfig" -endmenu +endmenu # "CPU Power Management" source "arch/riscv/kvm/Kconfig" -- 2.32.0 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-05-20 12:03 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-20 12:02 [PATCH 0/3] riscv: Kconfig: Style cleanups Juerg Haefliger 2022-05-20 12:02 ` Juerg Haefliger 2022-05-20 12:02 ` Juerg Haefliger [this message] 2022-05-20 12:02 ` [PATCH 1/3] riscv: Kconfig: Fix indentation and add comments Juerg Haefliger 2022-05-20 12:02 ` [PATCH 2/3] riscv: Kconfig.erratas: Add comments Juerg Haefliger 2022-05-20 12:02 ` Juerg Haefliger 2022-05-20 12:02 ` [PATCH 3/3] riscv: Kconfig.socs: " Juerg Haefliger 2022-05-20 12:02 ` Juerg Haefliger 2022-07-01 4:07 ` [PATCH 0/3] riscv: Kconfig: Style cleanups Palmer Dabbelt 2022-07-01 4:07 ` Palmer Dabbelt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220520120232.148310-2-juergh@canonical.com \ --to=juerg.haefliger@canonical.com \ --cc=aou@eecs.berkeley.edu \ --cc=juergh@canonical.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.