All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bernhard Beschow <shentey@gmail.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, "Bernhard Beschow" <shentey@gmail.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Eduardo Habkost" <eduardo@habkost.net>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>
Subject: [PATCH v2 04/10] hw/i386/pc: Unexport functions used only internally
Date: Fri, 20 May 2022 20:01:03 +0200	[thread overview]
Message-ID: <20220520180109.8224-5-shentey@gmail.com> (raw)
In-Reply-To: <20220520180109.8224-1-shentey@gmail.com>

Signed-off-by: Bernhard Beschow <shentey@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
---
 hw/i386/pc.c         | 4 ++--
 include/hw/i386/pc.h | 3 ---
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 2ffaac52fb..d7583045a0 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -570,7 +570,7 @@ static const char * const fdc_container_path[] = {
  * Locate the FDC at IO address 0x3f0, in order to configure the CMOS registers
  * and ACPI objects.
  */
-ISADevice *pc_find_fdc0(void)
+static ISADevice *pc_find_fdc0(void)
 {
     int i;
     Object *container;
@@ -714,7 +714,7 @@ static const int ne2000_io[NE2000_NB_MAX] = { 0x300, 0x320, 0x340, 0x360,
                                               0x280, 0x380 };
 static const int ne2000_irq[NE2000_NB_MAX] = { 9, 10, 11, 3, 4, 5 };
 
-void pc_init_ne2k_isa(ISABus *bus, NICInfo *nd)
+static void pc_init_ne2k_isa(ISABus *bus, NICInfo *nd)
 {
     static int nb_ne2k = 0;
 
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index 38be346a13..cb491fc43b 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -166,7 +166,6 @@ void pc_basic_device_init(struct PCMachineState *pcms,
                           ISADevice **rtc_state,
                           bool create_fdctrl,
                           uint32_t hpet_irqs);
-void pc_init_ne2k_isa(ISABus *bus, NICInfo *nd);
 void pc_cmos_init(PCMachineState *pcms,
                   BusState *ide0, BusState *ide1,
                   ISADevice *s);
@@ -177,8 +176,6 @@ typedef void (*cpu_set_smm_t)(int smm, void *arg);
 
 void pc_i8259_create(ISABus *isa_bus, qemu_irq *i8259_irqs);
 
-ISADevice *pc_find_fdc0(void);
-
 /* port92.c */
 #define PORT92_A20_LINE "a20"
 
-- 
2.36.1



  parent reply	other threads:[~2022-05-20 18:04 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-20 18:00 [PATCH v2 00/10] Random cleanup patches Bernhard Beschow
2022-05-20 18:01 ` [PATCH v2 01/10] hw: Reuse TYPE_I8042 define Bernhard Beschow
2022-05-21  9:46   ` Mark Cave-Ayland
2022-05-20 18:01 ` [PATCH v2 02/10] hw/audio/cs4231a: Const'ify global tables Bernhard Beschow
2022-05-20 18:01 ` [PATCH v2 03/10] hw/i386/pc: Unexport PC_CPU_MODEL_IDS macro Bernhard Beschow
2022-05-20 18:01 ` Bernhard Beschow [this message]
2022-05-20 18:01 ` [PATCH v2 05/10] hw/i386/pc: Remove orphan declarations Bernhard Beschow
2022-05-20 18:01 ` [PATCH v2 06/10] hw/ppc/e500: Remove unused BINARY_DEVICE_TREE_FILE Bernhard Beschow
2022-05-26 21:33   ` Daniel Henrique Barboza
2022-05-20 18:01 ` [PATCH v2 07/10] hw/net/fsl_etsec/etsec: Remove obsolete and unused etsec_create() Bernhard Beschow
2022-05-21  9:48   ` Mark Cave-Ayland
2022-05-20 18:01 ` [PATCH v2 08/10] accel/tcg/cpu-exec: Unexport dump_drift_info() Bernhard Beschow
2022-05-20 18:02   ` Bernhard Beschow
2022-05-22 22:38   ` Philippe Mathieu-Daudé via
2022-05-20 18:01 ` [PATCH v2 09/10] accel/tcg: Inline dump_opcount_info() and remove it Bernhard Beschow
2022-05-20 18:03   ` Bernhard Beschow
2022-05-22 22:39   ` Philippe Mathieu-Daudé via
2022-05-20 18:01 ` [PATCH v2 10/10] docs/devel: Fix link to developer mailing lists Bernhard Beschow
2022-05-20 18:03   ` Bernhard Beschow
2022-05-21  9:55 ` [PATCH v2 00/10] Random cleanup patches Mark Cave-Ayland
2022-05-23 19:30   ` Daniel Henrique Barboza
2022-06-03 10:42   ` Bernhard Beschow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220520180109.8224-5-shentey@gmail.com \
    --to=shentey@gmail.com \
    --cc=eduardo@habkost.net \
    --cc=f4bug@amsat.org \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.