From: Ziyang Xuan <william.xuanziyang@huawei.com>
To: <miquel.raynal@bootlin.com>, <a.zummo@towertech.it>,
<alexandre.belloni@bootlin.com>, <linux-rtc@vger.kernel.org>,
<linux-renesas-soc@vger.kernel.org>
Cc: <william.xuanziyang@huawei.com>
Subject: [PATCH] rtc: rzn1: fix inconsistent IS_ERR and PTR_ERR
Date: Mon, 23 May 2022 09:57:25 +0800 [thread overview]
Message-ID: <20220523015725.198244-1-william.xuanziyang@huawei.com> (raw)
It is inconsistent IS_ERR and PTR_ERR for rtc->rtcdev in rzn1_rtc_probe().
Generated by coccinelle script:
scripts/coccinelle/tests/odd_ptr_err.cocci
Fixes: deeb4b5393e1 ("rtc: rzn1: Add new RTC driver")
Signed-off-by: Ziyang Xuan <william.xuanziyang@huawei.com>
---
drivers/rtc/rtc-rzn1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c
index f92d1398b0f1..4cf54af8a8c3 100644
--- a/drivers/rtc/rtc-rzn1.c
+++ b/drivers/rtc/rtc-rzn1.c
@@ -348,7 +348,7 @@ static int rzn1_rtc_probe(struct platform_device *pdev)
rtc->rtcdev = devm_rtc_allocate_device(&pdev->dev);
if (IS_ERR(rtc->rtcdev))
- return PTR_ERR(rtc);
+ return PTR_ERR(rtc->rtcdev);
rtc->rtcdev->range_min = RTC_TIMESTAMP_BEGIN_2000;
rtc->rtcdev->range_max = RTC_TIMESTAMP_END_2099;
--
2.25.1
next reply other threads:[~2022-05-23 1:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 1:57 Ziyang Xuan [this message]
2022-05-23 7:58 ` [PATCH] rtc: rzn1: fix inconsistent IS_ERR and PTR_ERR Miquel Raynal
2022-05-24 6:09 [PATCH] rtc: rzn1: Fix " Haowen Bai
2022-05-24 7:19 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220523015725.198244-1-william.xuanziyang@huawei.com \
--to=william.xuanziyang@huawei.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.