From: marcandre.lureau@redhat.com
To: qemu-devel@nongnu.org
Cc: "Konstantin Kostiuk" <kkostiuk@redhat.com>,
"Michael Roth" <michael.roth@amd.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [PATCH v4 12/15] qga/wixl: require Mingw_bin
Date: Tue, 24 May 2022 12:34:50 +0200 [thread overview]
Message-ID: <20220524103453.162665-13-marcandre.lureau@redhat.com> (raw)
In-Reply-To: <20220524103453.162665-1-marcandre.lureau@redhat.com>
From: Marc-André Lureau <marcandre.lureau@redhat.com>
No clear reason to make guesses here.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
---
qga/installer/qemu-ga.wxs | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs
index 8a19aa1656..651db6e51c 100644
--- a/qga/installer/qemu-ga.wxs
+++ b/qga/installer/qemu-ga.wxs
@@ -4,15 +4,6 @@
<?error Define Arch to 32 or 64?>
<?endif?>
- <?ifndef var.Mingw_bin?>
- <?if $(var.Arch) = "64"?>
- <?define Mingw_bin=/usr/x86_64-w64-mingw32/sys-root/mingw/bin ?>
- <?endif?>
- <?if $(var.Arch) = "32"?>
- <?define Mingw_bin=/usr/i686-w64-mingw32/sys-root/mingw/bin ?>
- <?endif?>
- <?endif?>
-
<?if $(var.Arch) = "64"?>
<?define ArchLib=libgcc_s_seh-1.dll?>
<?define GaProgramFilesFolder="ProgramFiles64Folder" ?>
--
2.36.1
next prev parent reply other threads:[~2022-05-24 11:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 10:34 [PATCH v4 00/15] Misc cleanups marcandre.lureau
2022-05-24 10:34 ` [PATCH v4 01/15] include: move qemu_*_exec_dir() to cutils marcandre.lureau
2022-05-24 10:34 ` [PATCH v4 02/15] util/win32: simplify qemu_get_local_state_dir() marcandre.lureau
2022-05-24 10:34 ` [PATCH v4 03/15] tests: make libqmp buildable for win32 marcandre.lureau
2022-05-24 10:34 ` [PATCH v4 04/15] qga: flatten safe_open_or_create() marcandre.lureau
2022-05-24 10:34 ` [PATCH v4 05/15] qga: add qga_open_cloexec() helper marcandre.lureau
2022-05-24 14:55 ` Markus Armbruster
2022-05-24 10:34 ` [PATCH v4 06/15] qga: use qga_open_cloexec() for safe_open_or_create() marcandre.lureau
2022-05-24 14:53 ` Markus Armbruster
2022-05-24 10:34 ` [PATCH v4 07/15] qga: throw an Error in ga_channel_open() marcandre.lureau
2022-05-24 14:56 ` Markus Armbruster
2022-05-24 10:34 ` [PATCH v4 08/15] qga: replace qemu_open_old() with qga_open_cloexec() marcandre.lureau
2022-05-24 10:34 ` [PATCH v4 09/15] qga: make build_fs_mount_list() return a bool marcandre.lureau
2022-05-24 10:34 ` [PATCH v4 10/15] test/qga: use G_TEST_DIR to locate os-release test file marcandre.lureau
2022-05-24 10:34 ` [PATCH v4 11/15] qga/wixl: prefer variables over environment marcandre.lureau
2022-05-24 10:34 ` marcandre.lureau [this message]
2022-05-24 10:34 ` [PATCH v4 13/15] qga/wixl: simplify some pre-processing marcandre.lureau
2022-05-24 10:34 ` [PATCH v4 14/15] qga/wixl: replace QEMU_GA_MSI_MINGW_BIN_PATH with glib bindir marcandre.lureau
2022-05-24 10:34 ` [PATCH v4 15/15] test/qga: use g_auto wherever sensible marcandre.lureau
2022-05-25 14:13 ` Konstantin Kostiuk
2022-05-25 14:17 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220524103453.162665-13-marcandre.lureau@redhat.com \
--to=marcandre.lureau@redhat.com \
--cc=armbru@redhat.com \
--cc=kkostiuk@redhat.com \
--cc=michael.roth@amd.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.