All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
To: dri-devel@lists.freedesktop.org
Cc: "Nícolas F . R . A . Prado" <nfraprado@collabora.com>,
	"Tomeu Vizoso" <tomeu.vizoso@collabora.com>,
	"David Airlie" <airlied@linux.ie>,
	linux-kernel@vger.kernel.org,
	"Steven Price" <steven.price@arm.com>,
	"Alyssa Rosenzweig" <alyssa.rosenzweig@collabora.com>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>
Subject: [PATCH v2 5/9] drm/panfrost: Add HW_ISSUE_TTRX_3485 quirk
Date: Wed, 25 May 2022 10:57:50 -0400	[thread overview]
Message-ID: <20220525145754.25866-6-alyssa.rosenzweig@collabora.com> (raw)
In-Reply-To: <20220525145754.25866-1-alyssa.rosenzweig@collabora.com>

TTRX_3485 requires the infamous "dummy job" workaround. I have this
workaround implemented in a local branch, but I have not yet hit a case
that requires it so I cannot test whether the implementation is correct.
In the mean time, add the quirk bit so we can document which platforms
may need it in the future.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Steven Price <steven.price@arm.com>
---
 drivers/gpu/drm/panfrost/panfrost_issues.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/panfrost/panfrost_issues.h b/drivers/gpu/drm/panfrost/panfrost_issues.h
index e35807e4b743..4d41e0a13867 100644
--- a/drivers/gpu/drm/panfrost/panfrost_issues.h
+++ b/drivers/gpu/drm/panfrost/panfrost_issues.h
@@ -132,6 +132,9 @@ enum panfrost_hw_issue {
 	 * to hang */
 	HW_ISSUE_TTRX_3076,
 
+	/* Must issue a dummy job before starting real work to prevent hangs */
+	HW_ISSUE_TTRX_3485,
+
 	HW_ISSUE_END
 };
 
-- 
2.35.1


WARNING: multiple messages have this Message-ID (diff)
From: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
To: dri-devel@lists.freedesktop.org
Cc: "Rob Herring" <robh@kernel.org>,
	"Tomeu Vizoso" <tomeu.vizoso@collabora.com>,
	"Steven Price" <steven.price@arm.com>,
	"Alyssa Rosenzweig" <alyssa.rosenzweig@collabora.com>,
	"David Airlie" <airlied@linux.ie>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Nícolas F . R . A . Prado" <nfraprado@collabora.com>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2 5/9] drm/panfrost: Add HW_ISSUE_TTRX_3485 quirk
Date: Wed, 25 May 2022 10:57:50 -0400	[thread overview]
Message-ID: <20220525145754.25866-6-alyssa.rosenzweig@collabora.com> (raw)
In-Reply-To: <20220525145754.25866-1-alyssa.rosenzweig@collabora.com>

TTRX_3485 requires the infamous "dummy job" workaround. I have this
workaround implemented in a local branch, but I have not yet hit a case
that requires it so I cannot test whether the implementation is correct.
In the mean time, add the quirk bit so we can document which platforms
may need it in the future.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Steven Price <steven.price@arm.com>
---
 drivers/gpu/drm/panfrost/panfrost_issues.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/panfrost/panfrost_issues.h b/drivers/gpu/drm/panfrost/panfrost_issues.h
index e35807e4b743..4d41e0a13867 100644
--- a/drivers/gpu/drm/panfrost/panfrost_issues.h
+++ b/drivers/gpu/drm/panfrost/panfrost_issues.h
@@ -132,6 +132,9 @@ enum panfrost_hw_issue {
 	 * to hang */
 	HW_ISSUE_TTRX_3076,
 
+	/* Must issue a dummy job before starting real work to prevent hangs */
+	HW_ISSUE_TTRX_3485,
+
 	HW_ISSUE_END
 };
 
-- 
2.35.1


  parent reply	other threads:[~2022-05-25 14:58 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-25 14:57 [PATCH v2 0/9] drm/panfrost: Valhall (JM) support Alyssa Rosenzweig
2022-05-25 14:57 ` Alyssa Rosenzweig
2022-05-25 14:57 ` [PATCH v2 1/9] dt-bindings: Add compatible for Mali Valhall (JM) Alyssa Rosenzweig
2022-05-25 14:57   ` Alyssa Rosenzweig
2022-05-26  1:56   ` Rob Herring
2022-05-26  1:56     ` Rob Herring
2022-05-26  8:49   ` Steven Price
2022-05-26  8:49     ` Steven Price
2022-05-25 14:57 ` [PATCH v2 2/9] drm/panfrost: Handle HW_ISSUE_TTRX_2968_TTRX_3162 Alyssa Rosenzweig
2022-05-25 14:57   ` Alyssa Rosenzweig
2022-05-25 14:57 ` [PATCH v2 3/9] drm/panfrost: Constify argument to has_hw_issue Alyssa Rosenzweig
2022-05-25 14:57   ` Alyssa Rosenzweig
2022-05-25 14:57 ` [PATCH v2 4/9] drm/panfrost: Handle HW_ISSUE_TTRX_3076 Alyssa Rosenzweig
2022-05-25 14:57   ` Alyssa Rosenzweig
2022-05-25 14:57 ` Alyssa Rosenzweig [this message]
2022-05-25 14:57   ` [PATCH v2 5/9] drm/panfrost: Add HW_ISSUE_TTRX_3485 quirk Alyssa Rosenzweig
2022-05-25 14:57 ` [PATCH v2 6/9] drm/panfrost: Add "clean only safe" feature bit Alyssa Rosenzweig
2022-05-25 14:57   ` Alyssa Rosenzweig
2022-05-25 14:57 ` [PATCH v2 7/9] drm/panfrost: Don't set L2_MMU_CONFIG quirks Alyssa Rosenzweig
2022-05-25 14:57   ` Alyssa Rosenzweig
2022-05-25 14:57 ` [PATCH v2 8/9] drm/panfrost: Add Mali-G57 "Natt" support Alyssa Rosenzweig
2022-05-25 14:57   ` Alyssa Rosenzweig
2022-05-26  8:49   ` Steven Price
2022-05-26  8:49     ` Steven Price
2022-05-25 14:57 ` [PATCH v2 9/9] drm/panfrost: Add arm,mali-valhall-jm compatible Alyssa Rosenzweig
2022-05-25 14:57   ` Alyssa Rosenzweig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220525145754.25866-6-alyssa.rosenzweig@collabora.com \
    --to=alyssa.rosenzweig@collabora.com \
    --cc=airlied@linux.ie \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nfraprado@collabora.com \
    --cc=steven.price@arm.com \
    --cc=tomeu.vizoso@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.