All of lore.kernel.org
 help / color / mirror / Atom feed
From: Saravana Kannan <saravanak@google.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Kevin Hilman <khilman@kernel.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
	Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
	Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Daniel Scally <djrscally@gmail.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
	David Ahern <dsahern@kernel.org>
Cc: Saravana Kannan <saravanak@google.com>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	John Stultz <jstultz@google.com>,
	Nathan Chancellor <nathan@kernel.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	kernel-team@android.com, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org, iommu@lists.linux-foundation.org,
	netdev@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-acpi@vger.kernel.org
Subject: [RFC PATCH v1 2/9] pinctrl: devicetree: Delete usage of driver_deferred_probe_check_state()
Date: Thu, 26 May 2022 01:15:41 -0700	[thread overview]
Message-ID: <20220526081550.1089805-3-saravanak@google.com> (raw)
In-Reply-To: <20220526081550.1089805-1-saravanak@google.com>

Now that fw_devlink=on by default and fw_devlink supports
"pinctrl-[0-8]" property, the execution will never get to the point
where driver_deferred_probe_check_state() is called before the supplier
has probed successfully or before deferred probe timeout has expired.

So, delete the call and replace it with -ENODEV.

Signed-off-by: Saravana Kannan <saravanak@google.com>
---
 drivers/pinctrl/devicetree.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/devicetree.c b/drivers/pinctrl/devicetree.c
index 3fb238714718..ef898ee8ca6b 100644
--- a/drivers/pinctrl/devicetree.c
+++ b/drivers/pinctrl/devicetree.c
@@ -129,7 +129,7 @@ static int dt_to_map_one_config(struct pinctrl *p,
 		np_pctldev = of_get_next_parent(np_pctldev);
 		if (!np_pctldev || of_node_is_root(np_pctldev)) {
 			of_node_put(np_pctldev);
-			ret = driver_deferred_probe_check_state(p->dev);
+			ret = -ENODEV;
 			/* keep deferring if modules are enabled */
 			if (IS_ENABLED(CONFIG_MODULES) && !allow_default && ret < 0)
 				ret = -EPROBE_DEFER;
-- 
2.36.1.124.g0e6072fb45-goog


WARNING: multiple messages have this Message-ID (diff)
From: Saravana Kannan via iommu <iommu@lists.linux-foundation.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	 Kevin Hilman <khilman@kernel.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	 Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
	Joerg Roedel <joro@8bytes.org>,  Will Deacon <will@kernel.org>,
	Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	 Russell King <linux@armlinux.org.uk>,
	"David S. Miller" <davem@davemloft.net>,
	 Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	 Linus Walleij <linus.walleij@linaro.org>,
	 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Daniel Scally <djrscally@gmail.com>,
	 Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	 Sakari Ailus <sakari.ailus@linux.intel.com>,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
	 David Ahern <dsahern@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
	linux-acpi@vger.kernel.org,
	Saravana Kannan <saravanak@google.com>,
	linux-pm@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Nathan Chancellor <nathan@kernel.org>,
	linux-gpio@vger.kernel.org, iommu@lists.linux-foundation.org,
	Mark Brown <broonie@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	John Stultz <jstultz@google.com>,
	kernel-team@android.com,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: [RFC PATCH v1 2/9] pinctrl: devicetree: Delete usage of driver_deferred_probe_check_state()
Date: Thu, 26 May 2022 01:15:41 -0700	[thread overview]
Message-ID: <20220526081550.1089805-3-saravanak@google.com> (raw)
In-Reply-To: <20220526081550.1089805-1-saravanak@google.com>

Now that fw_devlink=on by default and fw_devlink supports
"pinctrl-[0-8]" property, the execution will never get to the point
where driver_deferred_probe_check_state() is called before the supplier
has probed successfully or before deferred probe timeout has expired.

So, delete the call and replace it with -ENODEV.

Signed-off-by: Saravana Kannan <saravanak@google.com>
---
 drivers/pinctrl/devicetree.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/devicetree.c b/drivers/pinctrl/devicetree.c
index 3fb238714718..ef898ee8ca6b 100644
--- a/drivers/pinctrl/devicetree.c
+++ b/drivers/pinctrl/devicetree.c
@@ -129,7 +129,7 @@ static int dt_to_map_one_config(struct pinctrl *p,
 		np_pctldev = of_get_next_parent(np_pctldev);
 		if (!np_pctldev || of_node_is_root(np_pctldev)) {
 			of_node_put(np_pctldev);
-			ret = driver_deferred_probe_check_state(p->dev);
+			ret = -ENODEV;
 			/* keep deferring if modules are enabled */
 			if (IS_ENABLED(CONFIG_MODULES) && !allow_default && ret < 0)
 				ret = -EPROBE_DEFER;
-- 
2.36.1.124.g0e6072fb45-goog

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

  parent reply	other threads:[~2022-05-26  8:16 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-26  8:15 [RFC PATCH v1 0/9] deferred_probe_timeout logic clean up Saravana Kannan
2022-05-26  8:15 ` Saravana Kannan via iommu
2022-05-26  8:15 ` [RFC PATCH v1 1/9] PM: domains: Delete usage of driver_deferred_probe_check_state() Saravana Kannan
2022-05-26  8:15   ` Saravana Kannan via iommu
2022-05-26  8:15 ` Saravana Kannan [this message]
2022-05-26  8:15   ` [RFC PATCH v1 2/9] pinctrl: devicetree: " Saravana Kannan via iommu
2022-05-30  9:22   ` Geert Uytterhoeven
2022-05-30  9:22     ` Geert Uytterhoeven
2022-06-05  3:41     ` Saravana Kannan
2022-06-05  3:41       ` Saravana Kannan via iommu
2022-06-06 10:17       ` Andy Shevchenko
2022-06-06 10:17         ` Andy Shevchenko
2022-05-26  8:15 ` [RFC PATCH v1 3/9] net: mdio: " Saravana Kannan
2022-05-26  8:15   ` Saravana Kannan via iommu
2022-05-26  8:15 ` [RFC PATCH v1 4/9] Revert "driver core: Set default deferred_probe_timeout back to 0." Saravana Kannan
2022-05-26  8:15   ` Saravana Kannan via iommu
2022-05-30  9:12   ` Geert Uytterhoeven
2022-05-30  9:12     ` Geert Uytterhoeven
2022-06-05  3:18     ` Saravana Kannan
2022-06-05  3:18       ` Saravana Kannan via iommu
2022-06-05  4:12       ` Saravana Kannan
2022-06-05  4:12         ` Saravana Kannan via iommu
2022-05-26  8:15 ` [RFC PATCH v1 5/9] driver core: Set fw_devlink.strict=1 by default Saravana Kannan
2022-05-26  8:15   ` Saravana Kannan via iommu
2022-05-26  8:15 ` [RFC PATCH v1 6/9] iommu/of: Delete usage of driver_deferred_probe_check_state() Saravana Kannan via iommu
2022-05-26  8:15   ` Saravana Kannan
2022-05-26  8:15 ` [RFC PATCH v1 7/9] driver core: Add fw_devlink_unblock_may_probe() helper function Saravana Kannan via iommu
2022-05-26  8:15   ` Saravana Kannan
2022-05-30  9:46   ` Andy Shevchenko
2022-05-30  9:46     ` Andy Shevchenko
2022-05-26  8:15 ` [RFC PATCH v1 8/9] net: ipconfig: Force fw_devlink to unblock any devices that might probe Saravana Kannan via iommu
2022-05-26  8:15   ` Saravana Kannan
2022-06-07 12:36   ` Geert Uytterhoeven
2022-06-07 12:36     ` Geert Uytterhoeven
2022-05-26  8:15 ` [RFC PATCH v1 9/9] driver core: Delete driver_deferred_probe_check_state() Saravana Kannan via iommu
2022-05-26  8:15   ` Saravana Kannan
2022-05-30  8:49 ` [RFC PATCH v1 0/9] deferred_probe_timeout logic clean up Sebastian Andrzej Siewior
2022-05-30  8:49   ` Sebastian Andrzej Siewior
2022-06-05  3:45   ` Saravana Kannan
2022-06-05  3:45     ` Saravana Kannan via iommu
2022-05-30  9:38 ` Geert Uytterhoeven
2022-05-30  9:38   ` Geert Uytterhoeven
2022-06-05  3:47   ` Saravana Kannan
2022-06-05  3:47     ` Saravana Kannan via iommu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220526081550.1089805-3-saravanak@google.com \
    --to=saravanak@google.com \
    --cc=andrew@lunn.ch \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bigeasy@linutronix.de \
    --cc=broonie@kernel.org \
    --cc=davem@davemloft.net \
    --cc=djrscally@gmail.com \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=hkallweit1@gmail.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=jstultz@google.com \
    --cc=kernel-team@android.com \
    --cc=khilman@kernel.org \
    --cc=kuba@kernel.org \
    --cc=len.brown@intel.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=nathan@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pavel@ucw.cz \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=ulf.hansson@linaro.org \
    --cc=will@kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.