From: Saravana Kannan <saravanak@google.com> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "Rafael J. Wysocki" <rafael@kernel.org>, Kevin Hilman <khilman@kernel.org>, Ulf Hansson <ulf.hansson@linaro.org>, Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>, Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>, Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>, Russell King <linux@armlinux.org.uk>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Linus Walleij <linus.walleij@linaro.org>, Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>, David Ahern <dsahern@kernel.org> Cc: Saravana Kannan <saravanak@google.com>, kernel-team@android.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, iommu@lists.linux-foundation.org, netdev@vger.kernel.org, linux-gpio@vger.kernel.org Subject: [PATCH v2 8/9] iommu/of: Delete usage of driver_deferred_probe_check_state() Date: Wed, 1 Jun 2022 00:07:04 -0700 [thread overview] Message-ID: <20220601070707.3946847-9-saravanak@google.com> (raw) In-Reply-To: <20220601070707.3946847-1-saravanak@google.com> Now that fw_devlink=on and fw_devlink.strict=1 by default and fw_devlink supports iommu DT properties, the execution will never get to the point where driver_deferred_probe_check_state() is called before the supplier has probed successfully or before deferred probe timeout has expired. So, delete the call and replace it with -ENODEV. Signed-off-by: Saravana Kannan <saravanak@google.com> --- drivers/iommu/of_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c index 5696314ae69e..41f4eb005219 100644 --- a/drivers/iommu/of_iommu.c +++ b/drivers/iommu/of_iommu.c @@ -40,7 +40,7 @@ static int of_iommu_xlate(struct device *dev, * a proper probe-ordering dependency mechanism in future. */ if (!ops) - return driver_deferred_probe_check_state(dev); + return -ENODEV; if (!try_module_get(ops->owner)) return -ENODEV; -- 2.36.1.255.ge46751e96f-goog
WARNING: multiple messages have this Message-ID (diff)
From: Saravana Kannan via iommu <iommu@lists.linux-foundation.org> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "Rafael J. Wysocki" <rafael@kernel.org>, Kevin Hilman <khilman@kernel.org>, Ulf Hansson <ulf.hansson@linaro.org>, Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>, Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>, Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>, Russell King <linux@armlinux.org.uk>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Linus Walleij <linus.walleij@linaro.org>, Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>, David Ahern <dsahern@kernel.org> Cc: Saravana Kannan <saravanak@google.com>, linux-pm@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, iommu@lists.linux-foundation.org, kernel-team@android.com Subject: [PATCH v2 8/9] iommu/of: Delete usage of driver_deferred_probe_check_state() Date: Wed, 1 Jun 2022 00:07:04 -0700 [thread overview] Message-ID: <20220601070707.3946847-9-saravanak@google.com> (raw) In-Reply-To: <20220601070707.3946847-1-saravanak@google.com> Now that fw_devlink=on and fw_devlink.strict=1 by default and fw_devlink supports iommu DT properties, the execution will never get to the point where driver_deferred_probe_check_state() is called before the supplier has probed successfully or before deferred probe timeout has expired. So, delete the call and replace it with -ENODEV. Signed-off-by: Saravana Kannan <saravanak@google.com> --- drivers/iommu/of_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c index 5696314ae69e..41f4eb005219 100644 --- a/drivers/iommu/of_iommu.c +++ b/drivers/iommu/of_iommu.c @@ -40,7 +40,7 @@ static int of_iommu_xlate(struct device *dev, * a proper probe-ordering dependency mechanism in future. */ if (!ops) - return driver_deferred_probe_check_state(dev); + return -ENODEV; if (!try_module_get(ops->owner)) return -ENODEV; -- 2.36.1.255.ge46751e96f-goog _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2022-06-01 7:07 UTC|newest] Thread overview: 127+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-01 7:06 [PATCH v2 0/9] deferred_probe_timeout logic clean up Saravana Kannan via iommu 2022-06-01 7:06 ` Saravana Kannan 2022-06-01 7:06 ` [PATCH v2 1/9] PM: domains: Delete usage of driver_deferred_probe_check_state() Saravana Kannan 2022-06-01 7:06 ` Saravana Kannan via iommu 2022-06-09 11:44 ` Ulf Hansson 2022-06-09 11:44 ` Ulf Hansson 2022-06-09 19:29 ` Saravana Kannan 2022-06-09 19:29 ` Saravana Kannan via iommu 2022-06-21 7:28 ` Tony Lindgren 2022-06-21 7:28 ` Tony Lindgren 2022-06-21 19:34 ` Saravana Kannan 2022-06-21 19:34 ` Saravana Kannan via iommu 2022-06-22 4:58 ` Tony Lindgren 2022-06-22 4:58 ` Tony Lindgren 2022-06-22 19:09 ` Saravana Kannan 2022-06-22 19:09 ` Saravana Kannan via iommu 2022-06-23 7:01 ` Tony Lindgren 2022-06-23 7:01 ` Tony Lindgren 2022-06-23 8:21 ` Saravana Kannan 2022-06-23 8:21 ` Saravana Kannan via iommu 2022-06-27 9:10 ` Tony Lindgren 2022-06-27 9:10 ` Tony Lindgren 2022-06-30 23:10 ` Saravana Kannan 2022-06-30 23:10 ` Saravana Kannan via iommu 2022-06-30 23:26 ` Rob Herring 2022-06-30 23:26 ` Rob Herring 2022-06-30 23:30 ` Saravana Kannan 2022-06-30 23:30 ` Saravana Kannan via iommu 2022-07-01 5:33 ` Tony Lindgren 2022-07-01 5:33 ` Tony Lindgren 2022-07-01 6:12 ` Tony Lindgren 2022-07-01 6:12 ` Tony Lindgren 2022-07-01 8:10 ` Saravana Kannan 2022-07-01 8:10 ` Saravana Kannan via iommu 2022-07-01 8:26 ` Saravana Kannan via iommu 2022-07-01 8:26 ` Saravana Kannan 2022-07-01 13:00 ` Tony Lindgren 2022-07-01 13:00 ` Tony Lindgren 2022-07-12 7:12 ` Tony Lindgren 2022-07-13 0:49 ` Saravana Kannan 2022-07-13 8:06 ` Tony Lindgren 2022-07-01 15:08 ` Sudeep Holla 2022-07-01 15:08 ` Sudeep Holla 2022-07-01 19:13 ` Saravana Kannan 2022-07-01 19:13 ` Saravana Kannan via iommu 2022-07-05 8:44 ` Saravana Kannan 2022-07-05 8:44 ` Saravana Kannan via iommu 2022-07-01 7:38 ` Geert Uytterhoeven 2022-07-01 7:38 ` Geert Uytterhoeven 2022-06-23 12:08 ` Alexander Stein 2022-06-23 12:08 ` Alexander Stein 2022-07-01 0:37 ` Saravana Kannan 2022-07-01 0:37 ` Saravana Kannan via iommu 2022-07-01 6:01 ` (EXT) " Alexander Stein 2022-07-01 6:01 ` Alexander Stein 2022-07-01 7:02 ` Saravana Kannan 2022-07-01 7:02 ` Saravana Kannan via iommu 2022-07-04 7:07 ` (EXT) " Alexander Stein 2022-07-04 7:07 ` Alexander Stein 2022-07-05 1:24 ` Saravana Kannan 2022-07-05 1:24 ` Saravana Kannan via iommu 2022-07-06 13:02 ` Re: " Alexander Stein 2022-07-06 13:02 ` Alexander Stein 2022-07-13 0:45 ` Saravana Kannan 2022-07-14 6:41 ` Alexander Stein 2022-07-15 22:08 ` Saravana Kannan 2022-07-01 7:30 ` Geert Uytterhoeven 2022-07-01 7:30 ` Geert Uytterhoeven 2022-06-01 7:06 ` [PATCH v2 2/9] pinctrl: devicetree: " Saravana Kannan 2022-06-01 7:06 ` Saravana Kannan via iommu 2022-06-01 7:06 ` [PATCH v2 3/9] net: mdio: " Saravana Kannan 2022-06-01 7:06 ` Saravana Kannan via iommu 2022-07-05 9:11 ` Geert Uytterhoeven 2022-07-05 9:11 ` Geert Uytterhoeven 2022-07-13 1:40 ` Saravana Kannan 2022-07-13 11:39 ` Geert Uytterhoeven 2022-08-15 8:38 ` Geert Uytterhoeven 2022-06-01 7:07 ` [PATCH v2 4/9] driver core: Add wait_for_init_devices_probe helper function Saravana Kannan 2022-06-01 7:07 ` Saravana Kannan via iommu 2022-06-01 7:07 ` [PATCH v2 5/9] net: ipconfig: Relax fw_devlink if we need to mount a network rootfs Saravana Kannan 2022-06-01 7:07 ` Saravana Kannan via iommu 2022-06-01 7:07 ` [PATCH v2 6/9] Revert "driver core: Set default deferred_probe_timeout back to 0." Saravana Kannan 2022-06-01 7:07 ` Saravana Kannan via iommu 2022-07-20 17:31 ` Geert Uytterhoeven 2022-07-20 19:01 ` Saravana Kannan 2022-07-21 8:40 ` Geert Uytterhoeven 2022-06-01 7:07 ` [PATCH v2 7/9] driver core: Set fw_devlink.strict=1 by default Saravana Kannan 2022-06-01 7:07 ` Saravana Kannan via iommu 2022-06-22 7:47 ` Sascha Hauer 2022-06-22 7:47 ` Sascha Hauer 2022-06-22 8:44 ` Linus Walleij 2022-06-22 8:44 ` Linus Walleij 2022-06-22 10:52 ` Andy Shevchenko 2022-06-22 10:52 ` Andy Shevchenko 2022-06-22 11:18 ` Sascha Hauer 2022-06-22 11:18 ` Sascha Hauer 2022-06-22 19:40 ` Saravana Kannan via iommu 2022-06-22 19:40 ` Saravana Kannan 2022-06-22 20:35 ` Saravana Kannan 2022-06-22 20:35 ` Saravana Kannan via iommu 2022-06-22 22:30 ` Saravana Kannan 2022-06-22 22:30 ` Saravana Kannan via iommu 2022-06-28 13:09 ` Linus Walleij 2022-06-28 13:09 ` Linus Walleij 2022-06-01 7:07 ` Saravana Kannan [this message] 2022-06-01 7:07 ` [PATCH v2 8/9] iommu/of: Delete usage of driver_deferred_probe_check_state() Saravana Kannan via iommu 2022-08-19 14:26 ` Jean-Philippe Brucker 2022-06-01 7:07 ` [PATCH v2 9/9] driver core: Delete driver_deferred_probe_check_state() Saravana Kannan 2022-06-01 7:07 ` Saravana Kannan via iommu 2022-06-07 18:07 ` [PATCH v2 0/9] deferred_probe_timeout logic clean up Geert Uytterhoeven 2022-06-07 18:07 ` Geert Uytterhoeven 2022-06-08 0:55 ` Saravana Kannan via iommu 2022-06-08 0:55 ` Saravana Kannan 2022-06-08 4:17 ` Saravana Kannan via iommu 2022-06-08 4:17 ` Saravana Kannan 2022-06-08 10:25 ` Geert Uytterhoeven 2022-06-08 10:25 ` Geert Uytterhoeven 2022-06-08 18:12 ` Saravana Kannan 2022-06-08 18:12 ` Saravana Kannan via iommu 2022-06-08 18:47 ` Geert Uytterhoeven 2022-06-08 18:47 ` Geert Uytterhoeven 2022-06-08 21:07 ` Saravana Kannan 2022-06-08 21:07 ` Saravana Kannan via iommu 2022-06-08 22:49 ` Jakub Kicinski 2022-06-08 22:49 ` Jakub Kicinski 2022-06-08 23:15 ` Saravana Kannan via iommu 2022-06-08 23:15 ` Saravana Kannan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220601070707.3946847-9-saravanak@google.com \ --to=saravanak@google.com \ --cc=andrew@lunn.ch \ --cc=davem@davemloft.net \ --cc=dsahern@kernel.org \ --cc=edumazet@google.com \ --cc=gregkh@linuxfoundation.org \ --cc=hkallweit1@gmail.com \ --cc=iommu@lists.linux-foundation.org \ --cc=joro@8bytes.org \ --cc=kernel-team@android.com \ --cc=khilman@kernel.org \ --cc=kuba@kernel.org \ --cc=len.brown@intel.com \ --cc=linus.walleij@linaro.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=netdev@vger.kernel.org \ --cc=pabeni@redhat.com \ --cc=pavel@ucw.cz \ --cc=rafael@kernel.org \ --cc=ulf.hansson@linaro.org \ --cc=will@kernel.org \ --cc=yoshfuji@linux-ipv6.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.