All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shiyang Ruan <ruansy.fnst@fujitsu.com>
To: <linux-kernel@vger.kernel.org>, <linux-xfs@vger.kernel.org>,
	<nvdimm@lists.linux.dev>, <linux-fsdevel@vger.kernel.org>
Cc: <djwong@kernel.org>, <david@fromorbit.com>, <hch@infradead.org>
Subject: [PATCH] xfs: fail dax mount if reflink is enabled on a partition
Date: Thu, 9 Jun 2022 22:34:35 +0800	[thread overview]
Message-ID: <20220609143435.393724-1-ruansy.fnst@fujitsu.com> (raw)

Failure notification is not supported on partitions.  So, when we mount
a reflink enabled xfs on a partition with dax option, let it fail with
-EINVAL code.

Signed-off-by: Shiyang Ruan <ruansy.fnst@fujitsu.com>
---
 fs/xfs/xfs_super.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
index 8495ef076ffc..a3c221841fa6 100644
--- a/fs/xfs/xfs_super.c
+++ b/fs/xfs/xfs_super.c
@@ -348,8 +348,10 @@ xfs_setup_dax_always(
 		goto disable_dax;
 	}
 
-	if (xfs_has_reflink(mp)) {
-		xfs_alert(mp, "DAX and reflink cannot be used together!");
+	if (xfs_has_reflink(mp) &&
+	    bdev_is_partition(mp->m_ddev_targp->bt_bdev)) {
+		xfs_alert(mp,
+			"DAX and reflink cannot work with multi-partitions!");
 		return -EINVAL;
 	}
 
-- 
2.36.1




             reply	other threads:[~2022-06-09 14:35 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-09 14:34 Shiyang Ruan [this message]
2022-06-10  5:46 ` [PATCH] xfs: fail dax mount if reflink is enabled on a partition Christoph Hellwig
2022-07-01  0:31 ` Darrick J. Wong
2022-07-01  5:14   ` Shiyang Ruan
2022-07-21 12:43     ` ruansy.fnst
2022-07-21 14:06   ` ruansy.fnst
2022-07-21 16:16     ` Darrick J. Wong
2022-07-29  3:55       ` ruansy.fnst
2022-07-29  4:54         ` Darrick J. Wong
2022-08-03  6:47           ` ruansy.fnst
2022-08-04  0:51             ` Darrick J. Wong
2022-08-04  1:36               ` Shiyang Ruan
2022-09-08 13:46               ` Shiyang Ruan
2022-09-09 13:01                 ` Brian Foster
2022-09-14  6:44                   ` Yang, Xiao/杨 晓
2022-09-14  9:38                     ` Yang, Xiao/杨 晓
2022-09-14 12:34                       ` Brian Foster
2022-09-14 16:28                         ` Darrick J. Wong
2022-09-15 10:14                           ` Yang, Xiao/杨 晓
2022-09-16  2:04                             ` Yang, Xiao/杨 晓
2022-09-20  2:38                               ` Yang, Xiao/杨 晓
2022-09-30  0:56                                 ` Gotou, Yasunori/五島 康文
2022-09-30  0:56                                   ` [dm-devel] " Gotou, Yasunori/五島 康文
2022-10-04  0:12                                   ` Darrick J. Wong
2022-10-04  0:12                                     ` [dm-devel] " Darrick J. Wong
2022-10-04  4:12                                     ` Gotou, Yasunori/五島 康文
2022-10-04  4:12                                       ` [dm-devel] " Gotou, Yasunori/五島 康文
2022-10-04 18:26                                       ` Darrick J. Wong
2022-10-04 18:26                                         ` Darrick J. Wong
2022-10-20 14:17                                         ` Yang, Xiao/杨 晓
2022-10-20 14:17                                           ` [dm-devel] " Yang, Xiao/杨 晓
2022-10-22  2:11                                           ` Darrick J. Wong
2022-10-22  2:11                                             ` [dm-devel] " Darrick J. Wong
     [not found]                                             ` <09f522cd-e846-12ee-d662-14f34a2977c4@fujitsu.com>
2022-10-23  7:04                                               ` yangx.jy
2022-10-23  7:04                                                 ` [dm-devel] " yangx.jy
2022-10-23 22:00                                             ` Dave Chinner
2022-10-23 22:00                                               ` [dm-devel] " Dave Chinner
2022-10-24  3:17                                               ` ruansy.fnst
2022-10-24  3:17                                                 ` ruansy.fnst
2022-10-24  4:05                                                 ` Darrick J. Wong
2022-10-24  4:05                                                   ` [dm-devel] " Darrick J. Wong
2022-10-24  5:31                                                 ` Dave Chinner
2022-10-24  5:31                                                   ` [dm-devel] " Dave Chinner
2022-10-25 14:26                                                   ` ruansy.fnst
2022-10-25 14:26                                                     ` [dm-devel] " ruansy.fnst
2022-10-25 17:56                                                     ` Darrick J. Wong
2022-10-25 17:56                                                       ` [dm-devel] " Darrick J. Wong
2022-10-27 21:08                                                       ` Darrick J. Wong
2022-10-27 21:08                                                         ` [dm-devel] " Darrick J. Wong
2022-10-28  1:37                                                         ` Dan Williams
2022-10-28  1:37                                                           ` [dm-devel] " Dan Williams
2022-10-30  9:31                                                           ` Shiyang Ruan
2022-10-30  9:31                                                             ` [dm-devel] " Shiyang Ruan
2022-11-02  0:45                                                             ` Darrick J. Wong
2022-11-02  0:45                                                               ` [dm-devel] " Darrick J. Wong
2022-11-02  5:17                                                               ` ruansy.fnst
2022-11-02  5:17                                                                 ` [dm-devel] " ruansy.fnst
2022-11-03  2:32                                                                 ` Dave Chinner
2022-11-03  2:32                                                                   ` [dm-devel] " Dave Chinner
2022-10-24 17:12                                               ` Dan Williams
2022-10-24 17:12                                                 ` [dm-devel] " Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220609143435.393724-1-ruansy.fnst@fujitsu.com \
    --to=ruansy.fnst@fujitsu.com \
    --cc=david@fromorbit.com \
    --cc=djwong@kernel.org \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=nvdimm@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.